From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id ED6E9A496 for ; Mon, 15 Jan 2018 15:31:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 06:31:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,364,1511856000"; d="scan'208";a="19842583" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jan 2018 06:30:56 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Jan 2018 14:30:55 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.46]) by irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002; Mon, 15 Jan 2018 14:30:54 +0000 From: "Trahe, Fiona" To: "Jozwiak, TomaszX" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Jozwiak, TomaszX" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] crypto/qat: fix out-of-bounds compiler error Thread-Index: AQHTjghQTTS8RgeCckm/8b6S7/89KqN0/puw Date: Mon, 15 Jan 2018 14:30:53 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435892F87FE@IRSMSX101.ger.corp.intel.com> References: <1516024409-7659-1-git-send-email-tomaszx.jozwiak@intel.com> In-Reply-To: <1516024409-7659-1-git-send-email-tomaszx.jozwiak@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjE2OTk5OWEtNGQwMC00ZWRkLThkMWQtODQ3MzMyMzljYzk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVxOE9xT0VLa2xIa0xpRGhJdUhLUUN1Tld0RDQrdGpqV3Q0UzlPSUlxNWM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix out-of-bounds compiler error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 14:31:05 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Monday, January 15, 2018 1:53 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Jozwiak, TomaszX > Subject: [dpdk-dev] [PATCH] crypto/qat: fix out-of-bounds compiler error >=20 > This commit fixes > - bpi_cipher_encrypt to prevent before 'array subscript is > above array bounds' error > - bpi_cipher_decrypt to prevent before 'array subscript is > above array bounds' error > - right cast from qat_cipher_get_block_size function. > This function can return -EFAULT in case of any error, > and that value must be cast to int instead of uint8_t > - typo in error message >=20 > A performance improvement was added to bpi_cipher_encrypt and > bpi_cipher_decrypt as well. >=20 > Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode") >=20 > Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe