DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node
@ 2018-03-09 18:00 Lee Roberts
  2018-03-09 18:17 ` Trahe, Fiona
  0 siblings, 1 reply; 3+ messages in thread
From: Lee Roberts @ 2018-03-09 18:00 UTC (permalink / raw)
  To: john.griffin, fiona.trahe, deepak.k.jain; +Cc: dev, Lee Roberts

rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
for its socket_id rather than the socket_id of the initializing process.

Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
---
 drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c
index bf83740..82641aa 100644
--- a/drivers/crypto/qat/rte_qat_cryptodev.c
+++ b/drivers/crypto/qat/rte_qat_cryptodev.c
@@ -130,7 +130,7 @@ static int crypto_qat_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 {
 	struct rte_cryptodev_pmd_init_params init_params = {
 		.name = "",
-		.socket_id = rte_socket_id(),
+		.socket_id = pci_dev->device.numa_node,
 		.private_data_size = sizeof(struct qat_pmd_private),
 		.max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
 	};
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node
  2018-03-09 18:00 [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node Lee Roberts
@ 2018-03-09 18:17 ` Trahe, Fiona
  2018-03-26  9:03   ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2018-03-09 18:17 UTC (permalink / raw)
  To: Lee Roberts, Griffin, John, Jain, Deepak K; +Cc: dev, Trahe, Fiona

Hi Lee,
Thanks for investigating this.

> -----Original Message-----
> From: Lee Roberts [mailto:lee.roberts@hpe.com]
> Sent: Friday, March 9, 2018 6:01 PM
> To: Griffin, John <john.griffin@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; Lee Roberts <lee.roberts@hpe.com>
> Subject: [PATCH] assign QAT cryptodev to correct NUMA node
> 
> rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
> for its socket_id rather than the socket_id of the initializing process.
> 
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node
  2018-03-09 18:17 ` Trahe, Fiona
@ 2018-03-26  9:03   ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-03-26  9:03 UTC (permalink / raw)
  To: Trahe, Fiona, Lee Roberts, Griffin, John, Jain, Deepak K
  Cc: dev, Trahe, Fiona



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona
> Sent: Friday, March 9, 2018 6:18 PM
> To: Lee Roberts <lee.roberts@hpe.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA
> node
> 
> Hi Lee,
> Thanks for investigating this.
> 
> > -----Original Message-----
> > From: Lee Roberts [mailto:lee.roberts@hpe.com]
> > Sent: Friday, March 9, 2018 6:01 PM
> > To: Griffin, John <john.griffin@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> > Cc: dev@dpdk.org; Lee Roberts <lee.roberts@hpe.com>
> > Subject: [PATCH] assign QAT cryptodev to correct NUMA node
> >
> > rte_cryptodev_pmd_init_params should use NUMA node of the QAT
> device
> > for its socket_id rather than the socket_id of the initializing process.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Modified title to "crypto/qat: assign device to correct NUMA node"

Applied to dpdk-next-crypto.
Thanks,

Pablo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-26  9:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 18:00 [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node Lee Roberts
2018-03-09 18:17 ` Trahe, Fiona
2018-03-26  9:03   ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).