From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <fiona.trahe@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 36A034C8F for <dev@dpdk.org>; Tue, 20 Mar 2018 20:25:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 12:25:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,336,1517904000"; d="scan'208";a="29734718" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 20 Mar 2018 12:25:12 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 19:25:11 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by irsmsx155.ger.corp.intel.com ([169.254.14.50]) with mapi id 14.03.0319.002; Tue, 20 Mar 2018 19:25:11 +0000 From: "Trahe, Fiona" <fiona.trahe@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Richardson, Bruce" <bruce.richardson@intel.com> CC: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "lironh@marvell.com" <lironh@marvell.com>, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder Thread-Index: AQHTwFmPQTJtHno8KE2KuPMFBjS7JaPZRFOAgAAFxICAAA9YAIAAB2uAgAAgg6A= Date: Tue, 20 Mar 2018 19:25:11 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358935DB6B@IRSMSX101.ger.corp.intel.com> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180320160624.GB18022@ltp-pvn> <20180320170120.GA4260@bricha3-MOBL.ger.corp.intel.com> <2404641.e51pahgxmm@xps> In-Reply-To: <2404641.e51pahgxmm@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRmM2Y1MWYtM2FlYi00ZjBmLWJlYjMtYTQ3ODQ4YWE3ODU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkxcL3VlVGpZSjZyRXpTVEdUTHlIeUFXUGF6TEpYRVBXcnQzRnY3ZXlWVVwvQT0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 Mar 2018 19:25:15 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, March 20, 2018 5:28 PM > To: Richardson, Bruce <bruce.richardson@intel.com> > Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>; jerin.jacob@cavium= networks.com; > santosh.shukla@caviumnetworks.com; Burakov, Anatoly <anatoly.burakov@inte= l.com>; > lironh@marvell.com; Trahe, Fiona <fiona.trahe@intel.com>; shreyansh.jain@= nxp.com; > hemant.agrawal@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder >=20 > 20/03/2018 18:01, Bruce Richardson: > > On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > > > Hi Thomas, > > > > > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > > > 20/03/2018 15:40, Pavan Nikhilesh: > > > > > Add driver/common folder and skeleton makefile for adding commonl= y > > > > > used functions across mempool, event and net devices. > > > > > > > > I am not sure there is a real benefit of introducing such new > > > > directory. Is it only solving the choice of where you add files us= ed > > > > by several drivers? Is drivers/bus/X/ the directory of choice for > > > > platform shared files? > > > > > > drivers/bus doesn't seem to be a appropriate abstraction common API's > > > used across multiple PMD's. > > > > > > This change is in regards with the discussion on ml: > > > http://dpdk.org/ml/archives/dev/2018-March/092822.html > > > > > > drivers/common seems to be a popular opinion but maybe we could use > > > something like drivers/SoC or if you have something in mind please > > > suggest. > > > > > I think drivers/common is a better solution as it's not just platform b= uses > > or SoC's that this occurs with. Even PCI devices can export multiple > > functions, such as in the QAT case, which leads to the case where you h= ave > > shared code between different driver classes. I don't think the PCI bus > > driver is a good place to put QAT shared code. :-) >=20 > If drivers X and Y share some code, it is possible to link files from > X directory in Y library. >=20 > If we want a more explicit and separate directory for shared code, > what would be the name of the sub-directories? > drivers/common/qat? > drivers/common/octeontx? > drivers/common/marvell? > drivers/common/mellanox? >=20 [Fiona] Yes. We plan to add drivers/common/qat.