From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DAC00A491 for ; Thu, 19 Apr 2018 12:53:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 03:53:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,468,1517904000"; d="scan'208";a="221662090" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga005.fm.intel.com with ESMTP; 19 Apr 2018 03:53:30 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX102.ger.corp.intel.com ([169.254.2.164]) with mapi id 14.03.0319.002; Thu, 19 Apr 2018 11:53:30 +0100 From: "Trahe, Fiona" To: Arnon Warshavsky , "thomas@monjalon.net" , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver Thread-Index: AQHT16PtbnCcKj6h+k224g95KqN0SqQH6XvA Date: Thu, 19 Apr 2018 10:53:29 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589376D31@IRSMSX101.ger.corp.intel.com> References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-2-git-send-email-arnon@qwilt.com> In-Reply-To: <1524117669-25729-2-git-send-email-arnon@qwilt.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmExZDkxODktYzgwOS00OTRjLWE2NjUtOGY1OWViNDY1ZTMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlvbFREbzVrMkxaYjJseTlWOU5DZG1ZVGdzWFZpeXRtaW1XbWpmNE5INms9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 10:53:33 -0000 Hi Arnon, Can you change subject to crypto/dpaa:... please as it's only affecting tha= t driver. Fiona > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Arnon Warshavsky > Sent: Thursday, April 19, 2018 7:01 AM > To: thomas@monjalon.net; Burakov, Anatoly ; Lu= , Wenzhuo > ; Doherty, Declan ; > jerin.jacob@caviumnetworks.com; Richardson, Bruce ; Yigit, Ferruh > > Cc: dev@dpdk.org; arnon@qwilt.com > Subject: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances = in crypto driver >=20 > replace panic calls with log and return value. >=20 > -- > v2: > - reformat error message to include literal string in a single line > v4: replace -1 return value with -ENOMEM >=20 > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++--- > drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++--- > 2 files changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 23012e3..d465a2d 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops =3D= { > RTE_CACHE_LINE_SIZE, > rte_socket_id()); >=20 > - if (cryptodev->data->dev_private =3D=3D NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (cryptodev->data->dev_private =3D=3D NULL) { > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device da= ta", > + __func__); > + return -ENOMEM; > + } > } >=20 > dpaa2_dev->cryptodev =3D cryptodev; > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec= /dpaa_sec.c > index b685220..7b63650 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -2356,9 +2356,11 @@ struct rte_security_ops dpaa_sec_security_ops =3D = { > RTE_CACHE_LINE_SIZE, > rte_socket_id()); >=20 > - if (cryptodev->data->dev_private =3D=3D NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (cryptodev->data->dev_private =3D=3D NULL) { > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device da= ta", > + __func__); > + return -ENOMEM; > + } > } >=20 > dpaa_dev->crypto_dev =3D cryptodev; > -- > 1.8.3.1