From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 15BA2AABF for ; Tue, 8 May 2018 16:44:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 07:44:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,378,1520924400"; d="scan'208";a="54175356" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga001.jf.intel.com with ESMTP; 08 May 2018 07:43:59 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.179]) by irsmsx110.ger.corp.intel.com ([169.254.15.125]) with mapi id 14.03.0319.002; Tue, 8 May 2018 15:43:58 +0100 From: "Trahe, Fiona" To: Shally Verma , "De Lara Guarch, Pablo" CC: "Doherty, Declan" , "pathreya@caviumnetworks.com" , "ssahu@caviumnetworks.com" , "agupta@caviumnetworks.com" , "dev@dpdk.org" , Sunila Sahu , Ashish Gupta Thread-Topic: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev Thread-Index: AQHTzNDof2qZjz+93UiLxJuEoWC5PaQl4Tfg Date: Tue, 8 May 2018 14:43:57 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com> References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com> <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTVkZWU4ZTQtNjVhZC00OTkzLTk4OTYtNDU1ZTUwMjc4Yjg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZhc2tMaWlMSUpjVFFcL3MramJMTWZVNHgyZlZoS1NmT3hmaHJhT1VueXc0PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 14:44:02 -0000 Hi Shally, > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona ; > pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetwo= rks.com; > dev@dpdk.org; Sunila Sahu ; Ashish Gupta > > Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev >=20 > struct rte_cryptodev_sym_session * > rte_cryptodev_sym_session_create(struct rte_mempool *mp) > { > struct rte_cryptodev_sym_session *sess; >=20 > /* Allocate a session structure from the session pool */ > - if (rte_mempool_get(mp, (void **)&sess)) { > + if (rte_mempool_get(mp, (void *)&sess)) { [Fiona] Are you introducing a bug here? The fn expects a void ** Also this will need rebasing - the latest code has an extra byte.