* [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
@ 2018-05-15 20:21 Pablo de Lara
2018-05-18 10:17 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2018-05-15 20:21 UTC (permalink / raw)
To: declan.doherty; +Cc: dev, Pablo de Lara, stable
qp->temp_digest is already an array of uint8_t,
so no need to cast to uint8_t*.
Fixes: baf1e63bfd65 ("crypto/aesni_gcm: do not append digest")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index c907551a5..bc5ee1b73 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -352,7 +352,7 @@ post_process_gcm_crypto_op(struct aesni_gcm_qp *qp,
session->op == AESNI_GMAC_OP_VERIFY) {
uint8_t *digest;
- uint8_t *tag = (uint8_t *)&qp->temp_digest;
+ uint8_t *tag = qp->temp_digest;
if (session->op == AESNI_GMAC_OP_VERIFY)
digest = op->sym->auth.digest.data;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
2018-05-15 20:21 [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast Pablo de Lara
@ 2018-05-18 10:17 ` Trahe, Fiona
2018-05-18 13:57 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2018-05-18 10:17 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Tuesday, May 15, 2018 9:21 PM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
>
> qp->temp_digest is already an array of uint8_t,
> so no need to cast to uint8_t*.
>
> Fixes: baf1e63bfd65 ("crypto/aesni_gcm: do not append digest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
2018-05-18 10:17 ` Trahe, Fiona
@ 2018-05-18 13:57 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-18 13:57 UTC (permalink / raw)
To: Trahe, Fiona, Doherty, Declan; +Cc: dev, stable
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, May 18, 2018 11:17 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Tuesday, May 15, 2018 9:21 PM
> > To: Doherty, Declan <declan.doherty@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast
> >
> > qp->temp_digest is already an array of uint8_t,
> > so no need to cast to uint8_t*.
> >
> > Fixes: baf1e63bfd65 ("crypto/aesni_gcm: do not append digest")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-18 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 20:21 [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast Pablo de Lara
2018-05-18 10:17 ` Trahe, Fiona
2018-05-18 13:57 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).