* [dpdk-dev] [PATCH] compressdev: remove unused driver id
@ 2018-05-21 22:38 Pablo de Lara
2018-05-22 9:26 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2018-05-21 22:38 UTC (permalink / raw)
To: fiona.trahe, ashish.gupta; +Cc: dev, Pablo de Lara
Driver id field is not set/used anywhere,
so it should be removed from rte_compressdev structure.
Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_compressdev/rte_compressdev_internal.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h
index 9ec44f2c1..22ceac66e 100644
--- a/lib/librte_compressdev/rte_compressdev_internal.h
+++ b/lib/librte_compressdev/rte_compressdev_internal.h
@@ -79,9 +79,6 @@ struct rte_compressdev {
struct rte_device *device;
/**< Backing device */
- uint8_t driver_id;
- /**< comp driver identifier*/
-
__extension__
uint8_t attached : 1;
/**< Flag indicating the device is attached */
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] compressdev: remove unused driver id
2018-05-21 22:38 [dpdk-dev] [PATCH] compressdev: remove unused driver id Pablo de Lara
@ 2018-05-22 9:26 ` Trahe, Fiona
2018-05-22 10:08 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2018-05-22 9:26 UTC (permalink / raw)
To: De Lara Guarch, Pablo, ashish.gupta; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, May 21, 2018 11:39 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; ashish.gupta@caviumnetworks.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] compressdev: remove unused driver id
>
> Driver id field is not set/used anywhere,
> so it should be removed from rte_compressdev structure.
>
> Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] compressdev: remove unused driver id
2018-05-22 9:26 ` Trahe, Fiona
@ 2018-05-22 10:08 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-22 10:08 UTC (permalink / raw)
To: Trahe, Fiona, ashish.gupta; +Cc: dev
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, May 22, 2018 10:26 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> ashish.gupta@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] compressdev: remove unused driver id
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, May 21, 2018 11:39 PM
> > To: Trahe, Fiona <fiona.trahe@intel.com>;
> > ashish.gupta@caviumnetworks.com
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] compressdev: remove unused driver id
> >
> > Driver id field is not set/used anywhere, so it should be removed from
> > rte_compressdev structure.
> >
> > Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-22 10:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 22:38 [dpdk-dev] [PATCH] compressdev: remove unused driver id Pablo de Lara
2018-05-22 9:26 ` Trahe, Fiona
2018-05-22 10:08 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).