From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E78311BF38 for ; Wed, 27 Jun 2018 19:35:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 10:35:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="50388078" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga007.fm.intel.com with ESMTP; 27 Jun 2018 10:35:09 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.148]) by irsmsx110.ger.corp.intel.com ([169.254.15.152]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 18:35:08 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH 2/2] compressdev: add huffman encoding flags Thread-Index: AQHUDh6yQMXtK9DRJ0ak6KNxEVnKCaR0N4Qw///0r4CAADF/EA== Date: Wed, 27 Jun 2018 17:35:07 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435895B6052@IRSMSX101.ger.corp.intel.com> References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180627055031.24394-2-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B435895B5E2C@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQxOWNjNWYtNGU5ZC00ZDdmLWE2ZGEtNTAwNzllMDMxN2MxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZlwvYzBUOTdTcHE5YmZCXC9KR2NpckxkVzFTSVpaU1N4bEoycmFqbjRtakgzbUlVMlZ3R2FHSmJhZGN5VGoxVEZrIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 17:35:12 -0000 > > > + case RTE_COMP_FF_HUFFMAN_FIXED: > > > + return "HUFFMAN_FIXED"; > > > + case RTE_COMP_FF_HUFFMAN_DYNAMIC: > > > + return "HUFFMAN_DYNAMIC"; > > [Fiona] Thanks for adding this. > > Just in case any other algos are added in future which also use Huffman > > encoding I'd suggest renaming to include DEFLATE, e.g. > > RTE_COMP_FF_DFL_HUFFMAN_FIXED/DYNAMIC >=20 > Since these flags are set per algorithm (in capabilities), > do you think it is needed to specify DEFLATE? >=20 [Fiona] You're right, I forgot that. So better not to include DEFLATE.=20