From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 14C261B4B6 for ; Fri, 29 Jun 2018 12:08:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 03:08:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="236578639" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga005.jf.intel.com with ESMTP; 29 Jun 2018 03:08:28 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Jun 2018 11:08:27 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.148]) by irsmsx155.ger.corp.intel.com ([169.254.14.241]) with mapi id 14.03.0319.002; Fri, 29 Jun 2018 11:08:27 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUDlSIjKUGy2I/+Um/WVwIbM7X4KR3A7ng Date: Fri, 29 Jun 2018 10:08:26 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435895B7A21@IRSMSX101.ger.corp.intel.com> References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180627121622.48069-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180627121622.48069-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTRlYjZmOWQtMmE1OC00YjE1LWJhZTQtZjhiOTE2OWIzNmVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieWIxM2JmZU81ZlAxSjNCOHBYanR5aWdGRzFkT1wvTkN5SitDQ0czbGtBM1M2OVRoK0htQllaMjRxQTBmXC9RZTROIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 10:08:37 -0000 Hi Pablo, The Chained mbufs feature in doc/guides/compressdevs/features/default.ini n= eeds updating with this change. Also while you're updating it I think we wanted to rename By-Pass? To Pass-= thru? Fiona > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, June 27, 2018 1:16 PM > To: Trahe, Fiona ; ashish.gupta@caviumnetworks.com= ; Daly, Lee > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag >=20 > The current mbuf scatter gather feature flag is > too ambiguous, as it is not clear if input and/or output > buffers can be scatter gather mbufs or not. >=20 > Therefore, three new flags will replace this flag: > - RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT > - RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT > - RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT >=20 > Note that out-of-place flat buffers is supported by default > and in-place is not supported by the library. >=20 > Signed-off-by: Pablo de Lara > --- >=20 > Changes in v2: > - Fixed typos > - Rephrased comments >=20 > doc/guides/rel_notes/release_18_08.rst | 6 ++++++ > lib/librte_compressdev/rte_comp.c | 8 ++++++-- > lib/librte_compressdev/rte_comp.h | 30 ++++++++++++++++++++--------= -- > 3 files changed, 32 insertions(+), 12 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_note= s/release_18_08.rst > index bc0124295..18c8b4bd1 100644 > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -60,6 +60,12 @@ API Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* compressdev: Feature flag ``RTE_COMP_FF_MBUF_SCATTER_GATHER`` is > + replaced with the following more explicit flags: > + - ``RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT`` > + - ``RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT`` > + - ``RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT`` > + >=20 > ABI Changes > ----------- > diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/r= te_comp.c > index d596ba872..ea7692ae7 100644 > --- a/lib/librte_compressdev/rte_comp.c > +++ b/lib/librte_compressdev/rte_comp.c > @@ -14,8 +14,12 @@ rte_comp_get_feature_name(uint64_t flag) > return "STATEFUL_COMPRESSION"; > case RTE_COMP_FF_STATEFUL_DECOMPRESSION: > return "STATEFUL_DECOMPRESSION"; > - case RTE_COMP_FF_MBUF_SCATTER_GATHER: > - return "MBUF_SCATTER_GATHER"; > + case RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT: > + return "OUT_OF_PLACE_SGL_IN_SGL_OUT"; > + case RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT: > + return "OUT_OF_PLACE_SGL_IN_FB_OUT"; > + case RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT: > + return "OUT_OF_PLACE_FB_IN_SGL_OUT"; > case RTE_COMP_FF_MULTI_PKT_CHECKSUM: > return "MULTI_PKT_CHECKSUM"; > case RTE_COMP_FF_ADLER32_CHECKSUM: > diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/r= te_comp.h > index 5b513c77e..f3742dafb 100644 > --- a/lib/librte_compressdev/rte_comp.h > +++ b/lib/librte_compressdev/rte_comp.h > @@ -30,23 +30,33 @@ extern "C" { > /**< Stateful compression is supported */ > #define RTE_COMP_FF_STATEFUL_DECOMPRESSION (1ULL << 1) > /**< Stateful decompression is supported */ > -#define RTE_COMP_FF_MBUF_SCATTER_GATHER (1ULL << 2) > -/**< Scatter-gather mbufs are supported */ > -#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 3) > +#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT (1ULL << 2) > +/**< Out-of-place Scatter-gather (SGL) mbufs are > + * supported in input and output > + */ > +#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT (1ULL << 3) > +/**< Out-of-place Scatter-gather (SGL) mbufs are supported > + * in input, combined with flat buffers (FB) in output > + */ > +#define RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT (1ULL << 4) > +/**< Out-of-place Scatter-gather (SGL) mbufs are supported > + * in output, combined with flat buffers (FB) in input > + */ > +#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 5) > /**< Adler-32 Checksum is supported */ > -#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 4) > +#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 6) > /**< CRC32 Checksum is supported */ > -#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 5) > +#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 7) > /**< Adler-32/CRC32 Checksum is supported */ > -#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 6) > +#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 8) > /**< Generation of checksum across multiple stateless packets is support= ed */ > -#define RTE_COMP_FF_SHA1_HASH (1ULL << 7) > +#define RTE_COMP_FF_SHA1_HASH (1ULL << 9) > /**< SHA1 Hash is supported */ > -#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 8) > +#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 10) > /**< SHA256 Hash of SHA2 family is supported */ > -#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 9) > +#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 11) > /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is supp= orted */ > -#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 10) > +#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 12) > /**< Private xforms created by the PMD can be shared > * across multiple stateless operations. If not set, then app needs > * to create as many priv_xforms as it expects to have stateless > -- > 2.14.4