From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C9F9F1BF0C for ; Fri, 6 Jul 2018 15:41:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2018 06:41:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,316,1526367600"; d="scan'208";a="64911549" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 06 Jul 2018 06:41:04 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.136]) by irsmsx110.ger.corp.intel.com ([169.254.15.152]) with mapi id 14.03.0319.002; Fri, 6 Jul 2018 14:41:03 +0100 From: "Trahe, Fiona" To: Shally Verma , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "nmurthy@caviumnetworks.com" , Umesh Kartha , Sunila Sahu , Ashish Gupta , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations Thread-Index: AQHUEuInXM4b29bLUECYT7VFr6BXCqSCELFQ Date: Fri, 6 Jul 2018 13:41:03 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435895C88E3@IRSMSX103.ger.corp.intel.com> References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1530631466-26427-3-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzEyOWIzMjktOGZhYy00OWNjLWJhOTEtODhmNjBlZjdkYjk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSjArd1NKTHQ4bkpnMFlkOXhNN2ZnSmcwWG16YmwwNkV0REU5VmlJMm1qOGFaMGxqXC9QNTBlam1CQ0JiYVhsWm8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:41:09 -0000 Hi Shally, Umesh, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; nmurthy@caviumnetworks.com= ; Umesh Kartha > ; Sunila Sahu ; Ashish > Gupta > Subject: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operatio= ns //snip// > + > +int __rte_experimental > +rte_cryptodev_asym_session_set_private_data( > + struct rte_cryptodev_asym_session *sess, > + void *data, > + uint16_t size) > +{ > + uint16_t off_set =3D sizeof(void *) * nb_drivers; > + uint8_t *private_data_present =3D (uint8_t *)sess + off_set; > + > + if (sess =3D=3D NULL) > + return -EINVAL; > + > + *private_data_present =3D 1; > + off_set +=3D sizeof(uint8_t); > + rte_memcpy((uint8_t *)sess + off_set, data, size); > + return 0; > +} > + > +void * __rte_experimental > +rte_cryptodev_asym_session_get_app_private_data( > + struct rte_cryptodev_asym_session *sess) [Fiona] The set api should be renamed if the get function is renamed.=20 However, I'd suggest leaving out these functions unless they're really need= ed for asymm. Are they just here for consistency with the sym functions? The sym functions are still experimental and I think the names should be ch= anged to use user_data instead of private_data. I've just sent a patch to the mailing list about this - it would be better = to resolve that naming issue first and add corresponding fns later to this api if needed.=20