From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D88537CB0 for ; Thu, 11 Oct 2018 12:13:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 03:13:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,368,1534834800"; d="scan'208";a="77195395" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 11 Oct 2018 03:04:03 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 Oct 2018 11:04:02 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.4]) by IRSMSX156.ger.corp.intel.com ([169.254.3.178]) with mapi id 14.03.0319.002; Thu, 11 Oct 2018 11:04:02 +0100 From: "Trahe, Fiona" To: "akhil.goyal@nxp.com" , "Daly, Lee" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH 3/3] doc: update ISA-L guide to reflect checksum support Thread-Index: AQHUX+xXIsDFZ8l6wUCUkDfZT89FXaUZ0aqw Date: Thu, 11 Oct 2018 10:04:01 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589649061@IRSMSX101.ger.corp.intel.com> References: <1539102109-9311-1-git-send-email-lee.daly@intel.com> <1539102109-9311-3-git-send-email-lee.daly@intel.com> In-Reply-To: <1539102109-9311-3-git-send-email-lee.daly@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTg4Y2IwY2MtMzgzNy00YjQ5LWE3MzAtMWFjNzRiYzRjZjc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicFpya2huem5XM0ZEd1p6ckttNkY3Vit1ck1oMEhieldtYVdlQ1BGQ3k5STZhWlU0MDFxak1yT1dsNzN0U1EwVSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] doc: update ISA-L guide to reflect checksum support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 10:13:43 -0000 Hi Lee, > +If you request a checksum for compression, the checksum field in the ope= ration > +structure, ``op->input_chksum``, will be filled with the checksum of the= input data. > + [Fiona] This is not correct - the checksum will always be in the op->output= _chksum The input_chksum field is for generating a checksum across the uncompressed= data of multiple related ops > +If you request a checksum for decompression, the checksum field in the o= peration > +structure, ``op->output_chksum``, will be filled with the checksum of th= e output data. > + > +.. Note:: > + > + For the compression case above, your output buffer will need to be larg= e enough to hold the compressed > data plus a scratchpad for the checksum at the end, the scratchpad is 8 b= ytes for CRC32 and 4 bytes for > Adler32. [Fiona] In the compression case is there no need for this scratchpad?