From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4D8AA7D4E for ; Wed, 17 Oct 2018 16:33:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 07:33:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="78747126" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga007.fm.intel.com with ESMTP; 17 Oct 2018 07:33:38 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.4]) by IRSMSX154.ger.corp.intel.com ([169.254.12.130]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 15:33:37 +0100 From: "Trahe, Fiona" To: "Daly, Lee" , "Verma, Shally" CC: "Jozwiak, TomaszX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUZJkxcIGln+39A0uVljPKIaOJxKUjgX3w Date: Wed, 17 Oct 2018 14:33:36 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358964F1CB@IRSMSX101.ger.corp.intel.com> References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM0ZjJjZTktMDE5YS00NGRkLWIxODctNmZjNjcyOTAxZDlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWlmOGdEbHZkU3ZNMmZmYmFmXC9aZTFpWFhRK0tGMHJIRlNYdXBxcFwvXC9FaHV2Y3dCMWRHeHFUNXF5NlJiSmw0ZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 14:33:40 -0000 Hi Shally, Lee, > -----Original Message----- > From: Daly, Lee > Sent: Monday, October 15, 2018 8:10 AM > To: Verma, Shally > Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, Fi= ona > ; akhil.goyal@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance me= asurement >=20 > Thanks for your input Shally see comments below. >=20 >=20 > I will be reviewing these changes while Tomasz is out this week. >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally > > Sent: Friday, October 12, 2018 11:16 AM > > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > > Fiona ; akhil.goyal@nxp.com; De Lara Guarch, Pab= lo > > > > Cc: De@dpdk.org; Lara@dpdk.org; Guarch@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance > > measurement > > /// > >Also, why do we need --max-num- > > sgl-segs as an input option from user? Shouldn't input_sz and seg_sz > > internally decide on num-segs? > > Or is it added to serve some other different purpose? > Will have to get back to you on this one, seems illogical to get this inp= ut from user, > But I will have to do further investigation to find if there was a differ= ent purpose. [Fiona] Some PMDs have a limit on how many links can be in an sgl chain, e.= g. in QAT case the=20 PMD allocates a pool of internal structures of a suitable size during devic= e initialisation, this is not=20 a hard limit but can be configured in .config to give the user control over= the memory resources allocated. This perf-tool max-num-sgl-segs is so the user can pick a value <=3D whatev= er the PMD's max is.