From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9F0F21B11D for ; Wed, 17 Oct 2018 18:45:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 09:45:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,393,1534834800"; d="scan'208";a="89077491" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by FMSMGA003.fm.intel.com with ESMTP; 17 Oct 2018 09:45:18 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.4]) by IRSMSX108.ger.corp.intel.com ([169.254.11.187]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 17:45:17 +0100 From: "Trahe, Fiona" To: "Verma, Shally" , "Daly, Lee" CC: "Jozwiak, TomaszX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUZJkxcIGln+39A0uVljPKIaOJxKUjgX3wgAAEmACAAB780A== Date: Wed, 17 Oct 2018 16:45:17 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358964F45C@IRSMSX101.ger.corp.intel.com> References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> <348A99DA5F5B7549AA880327E580B4358964F1CB@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM0ZjJjZTktMDE5YS00NGRkLWIxODctNmZjNjcyOTAxZDlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWlmOGdEbHZkU3ZNMmZmYmFmXC9aZTFpWFhRK0tGMHJIRlNYdXBxcFwvXC9FaHV2Y3dCMWRHeHFUNXF5NlJiSmw0ZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 16:45:23 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Wednesday, October 17, 2018 8:43 AM > To: Trahe, Fiona ; Daly, Lee > Cc: Jozwiak, TomaszX ; dev@dpdk.org; akhil.goy= al@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance me= asurement >=20 >=20 >=20 > >-----Original Message----- > >From: Trahe, Fiona > >Sent: 17 October 2018 20:04 > >To: Daly, Lee ; Verma, Shally > >Cc: Jozwiak, TomaszX ; dev@dpdk.org; akhil.go= yal@nxp.com; Trahe, Fiona > > >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance m= easurement > > > >External Email > > > >Hi Shally, Lee, > > > >> -----Original Message----- > >> From: Daly, Lee > >> Sent: Monday, October 15, 2018 8:10 AM > >> To: Verma, Shally > >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe,= Fiona > >> ; akhil.goyal@nxp.com > >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance= measurement > >> > >> Thanks for your input Shally see comments below. > >> > >> > >> I will be reviewing these changes while Tomasz is out this week. > >> > >> > -----Original Message----- > >> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally > >> > Sent: Friday, October 12, 2018 11:16 AM > >> > To: Jozwiak, TomaszX ; dev@dpdk.org; Trah= e, > >> > Fiona ; akhil.goyal@nxp.com; De Lara Guarch, = Pablo > >> > > >> > Cc: De@dpdk.org; Lara@dpdk.org; Guarch@dpdk.org > >> > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performan= ce > >> > measurement > >> > > >/// > > > >> >Also, why do we need --max-num- > >> > sgl-segs as an input option from user? Shouldn't input_sz and seg_sz > >> > internally decide on num-segs? > >> > Or is it added to serve some other different purpose? > >> Will have to get back to you on this one, seems illogical to get this = input from user, > >> But I will have to do further investigation to find if there was a dif= ferent purpose. > > > >[Fiona] Some PMDs have a limit on how many links can be in an sgl chain,= e.g. in QAT case the > >PMD allocates a pool of internal structures of a suitable size during de= vice initialisation, this is not > >a hard limit but can be configured in .config to give the user control o= ver the memory resources allocated. > >This perf-tool max-num-sgl-segs is so the user can pick a value <=3D wha= tever the PMD's max is. >=20 > Then also, I believe this could be taken care internally by an app. > App can choose convenient number of sgl segs as per PMD capability and in= put sz and chunk sz selected by > user. > Just my thoughts. [Fiona] Then we'd need to add this capability to the API, e.g. add uint16_t= max_nb_segments_per_sgl into the rte_compressdev_info struct. Special case 0 means no limit. We did consider this before, I can't remember why we didn't do it, I think = it's needed. I'll push an API patch for this in 19.02 and we can remove the --max-num-sg= l-segs param from=20 the performance tool and hardcode it in the tool in the meantime. Ok?