From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4F42C201 for ; Sat, 10 Nov 2018 01:54:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Nov 2018 16:54:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,485,1534834800"; d="scan'208";a="103145049" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 09 Nov 2018 16:54:27 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.134]) by IRSMSX106.ger.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0415.000; Sat, 10 Nov 2018 00:54:27 +0000 From: "Trahe, Fiona" To: "Jozwiak, TomaszX" , "Verma, Shally" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUYhSi4y6CnzH9EkWMpywfOc0JkaU8YTsAgASfRQCAAYnoAIAAA0IAgAAOBwCAAG4XAIABOJkAgAOUM0A= Date: Sat, 10 Nov 2018 00:54:26 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896741A1@IRSMSX101.ger.corp.intel.com> References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTliNWU5NDktMzlkOS00MmQzLWI1ZTQtYzRlOTkxMjljODNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXVzUnFhWmNqeUdjdFhtNmR5anlvVUhXa0VvZmhvYW1cL09OTTlETkVyVVwvMHdGdnZjd2pVQlRMd1ZOWVp5WnJoIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 00:54:30 -0000 Hi Shally, Tomasz, > > >> >> >> >+ /* Window size */ > > >> >> >> >+ if (test_data->window_sz !=3D -1) { > > >> >> >> >+ if (param_range_check(test_data->window_sz, > > >> >> >> >+ &cap->window_size) > > >> >> >> What if cap->window_size is 0 i.e. implementation default? > > >> >> > > > >> >> >TJ: You probably mean cap->window_size.increment =3D 0 (because > > >> >> >cap->window_size is a structure). In that case we check if > > >> >> >test_data->window_sz >=3Dmin and test_data->window_sz <=3D max > > only, > > >> >> because increment =3D 0 means (base on compression API) we have o= nly > > >> >> one value of windows_size (no range is supported). > > >> >> But PMD can set min and max too 0 for such case. > > >> > > > >> >TJ: I can't see any issue in that case too. Maybe I don't understan= d > > >> >what you > > >> mean but the logic is as follow: > > >> >1) if you pass '--window-sz ...' param. into command line your > > >> >intention is to force that value of window size during test. We > > >> >check is this > > >> value is allow (by param_range_check() function). > > >> >2) if you plan to use default value - just don't pass '--window-sz' > > >> >param. in command line at all. In that case we get windows size fro= m > > >> >window_size.max field, so if window_size.min=3D window_size.max=3D0 > > >> test_data->window_sz will be zero, as well. > > >> >If you mean that behavior is not good - I will be grateful for othe= r > > >> suggestions. > > >> > > >> This is fine. but I am thinking of 3rd case here: > > >> c) user pass window sz but PMD window_sz.min =3D max =3D 0, then use= r > > >> requested windowsz is not applicable right?! > > > > > >In that case - true. There'll be fail : > > >"Compress device does not support this window size\n"); So what is you= r > > >proposal for that case? > > > > > We can set to window size to implementation default and add in diagnost= ic > > of used window sz for test run. > > No need to fail here I believe. [Fiona] For Window size capability reported by the PMD in the info struct=20 it is not valid to report min=3D0, max=3D0. The PMD must report the range i= t can handle - the API doesn't suggest otherwise.=20 On the xform a specific window size is requested of the PMD, if it doesn't = support this it's allowed to fall back to a lower size according to the API. However that doesn't mean the PMD can pick any size if it doesn't support t= he requested size, i.e. it can't pick a bigger size, just a smaller one.=20 If an application requests a smaller window size than a PMD supports, it can be that the decompression engine will be unable to decompress if a larger window is used, so the PMD=20 should only fall back to a smaller size. Based on above, I think the perf tool behaviour is ok.=20 It should pass the user requested value to the PMD if the PMD capabilities = support it. If not it should fail. If the user wants to measure with a different window= size they can pass in that parameter. The functional test suite can be used to validate the case where the PMD falls back - this is not what the perf tool is for. Does this make sense? @Shally, do you think we need an API change to support an unlimited set of = window sizes? If so can you explain why? =20