From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8581F1B57F for ; Tue, 18 Dec 2018 15:43:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 06:43:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,368,1539673200"; d="scan'208";a="128850114" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga004.fm.intel.com with ESMTP; 18 Dec 2018 06:43:10 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.237]) by IRSMSX102.ger.corp.intel.com ([169.254.2.29]) with mapi id 14.03.0415.000; Tue, 18 Dec 2018 14:43:09 +0000 From: "Trahe, Fiona" To: Stephen Hemminger CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "shally.verma@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" , "Luse, Paul E" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUgHH0iBHC0Frsi0+jiJBhoUExD6VX5t6AgADy5OCAAB0HgIArxwTw Date: Tue, 18 Dec 2018 14:43:08 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896A4B55@IRSMSX101.ger.corp.intel.com> References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> <20181120100703.34c462e9@xeon-e3> In-Reply-To: <20181120100703.34c462e9@xeon-e3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjA0N2I4ZTctZTZlMy00MzJkLWE5YjctZjNmZGJmNjdjNDhlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRitibXJRbE5ZRjNZTlA3a0VJQUVxczRzbW84eDhIcGVmY1wvZVZ3UVhMWVpiRzRneHJlMzN4alFDa0NqeFwvekRGIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 14:43:13 -0000 Hi Stephen //snip// > > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to spec= ify where processing is done > > > > > > On Tue, 20 Nov 2018 01:39:48 +0000 > > > Fiona Trahe wrote: > > > > > > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE > > > > is added. A PMD which processes operations using a software > > > > acceleration engine should set this if the bulk of the > > > > processing is done during the dequeue. It should leave it > > > > cleared if the bulk of the processing is done during the > > > > enqueue (default). > > > > An application may find this useful for tuning. > > > > > > > > Signed-off-by: Fiona Trahe > > > > > > What application? or is this "if we build it they will come?" > > [Fiona] Our storage team asked for this, so not quite. > > Seems like it might by generically useful, so a bit of the latter too := ) > > Would you prefer I removed that line? >=20 > Hopefully, there would be one or more open source projects using the API. > I just did a survey of DPDK an 1/3 of it is never used by any open source > project. Hate to see more dead code and special cases created. >=20 > At least, some example code in examples would help. Something like a simp= le > in memory compressed storage server using a network API (SMB?/SSH?/FTP?) [Fiona] There is no compressdev sample app yet.=20 However I've double-checked with the SPDK team, they're currently integrati= ng compressdev and intend to push a patch to SPDK - a storage open-source proj= ect - using this flag.