From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
Date: Fri, 21 Dec 2018 17:44:38 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435896A8F91@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8978035399B@irsmsx112.ger.corp.intel.com>
Hi Pablo,
Thanks for reviewing
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, December 21, 2018 4:52 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> Subject: RE: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
>
>
>
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> > akhil.goyal@nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> > mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.
[Fiona] It did previously print a message saying the device doesn't support
the test case, so I think more of a style change than a bug. I think this way is clearer but
not necessary to backport cause only really of interest to developers and
dev of new test cases are usually done on latest.
>
> Thanks,
> Pablo
next prev parent reply other threads:[~2018-12-21 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 0:02 Fiona Trahe
2018-12-21 11:52 ` De Lara Guarch, Pablo
2018-12-21 17:44 ` Trahe, Fiona [this message]
2019-01-11 11:04 ` De Lara Guarch, Pablo
2019-01-11 11:13 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435896A8F91@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).