From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5408B1B9EC for ; Fri, 21 Dec 2018 18:44:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2018 09:44:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,382,1539673200"; d="scan'208";a="112442663" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 21 Dec 2018 09:44:40 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.237]) by irsmsx105.ger.corp.intel.com ([169.254.7.247]) with mapi id 14.03.0415.000; Fri, 21 Dec 2018 17:44:39 +0000 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD Thread-Index: AQHUmMB+Gk0UBF6DjU2jITBim7r5w6WJFcGAgABg/3A= Date: Fri, 21 Dec 2018 17:44:38 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896A8F91@IRSMSX101.ger.corp.intel.com> References: <1545350539-7065-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTc1ODhkNWUtNGNkMi00ODgxLWI4YzUtMWI0MzY0ODc5MmI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaEVubGxtTzE4cEd1b05WSDZ1NDEyM1QyXC8wcmh0UENDaHFwRENBdFduZW5Gd1JyV20zR1Y0UExhdm5lQTlWU0UifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 17:44:42 -0000 Hi Pablo, Thanks for reviewing > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, December 21, 2018 4:52 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Zhang, Roy Fan ; akhil.goyal@nxp.com > Subject: RE: [PATCH] test/crypto: don't attempt unsupported SGL tests on = aesni mb PMD >=20 >=20 >=20 > > -----Original Message----- > > From: Trahe, Fiona > > Sent: Friday, December 21, 2018 12:02 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Trahe, Fion= a > > ; Zhang, Roy Fan ; > > akhil.goyal@nxp.com > > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on ae= sni > > mb PMD > > > > Remove AESNI_MB flag from SGL test cases which it doesn't support. > > > > Signed-off-by: Fiona Trahe >=20 > Patch looks good, but I wonder if this is a fix and therefore, if it need= s to be backported. [Fiona] It did previously print a message saying the device doesn't support the test case, so I think more of a style change than a bug. I think this = way is clearer but not necessary to backport cause only really of interest to developers and dev of new test cases are usually done on latest. >=20 > Thanks, > Pablo