From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CBB229E4 for ; Thu, 17 Jan 2019 12:37:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 03:37:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="117424747" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga008.fm.intel.com with ESMTP; 17 Jan 2019 03:37:26 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 11:37:25 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.213]) by irsmsx111.ger.corp.intel.com ([169.254.2.160]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 11:37:25 +0000 From: "Trahe, Fiona" To: Anoob Joseph , Akhil Goyal , "De Lara Guarch, Pablo" CC: Jerin Jacob Kollanukkaran , "Narayana Prasad Raju Athreya" , Shally Verma , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH] doc: announce ABI change for cryptodev config Thread-Index: AQHUrkiNRSYeo6tWnUGaZWm74s8S2KWzUDxQ Date: Thu, 17 Jan 2019 11:37:25 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896CBFFB@IRSMSX101.ger.corp.intel.com> References: <1547717928-21203-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1547717928-21203-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDhmZGUwMWEtMTdhNC00ZTQxLWJiMGUtYjQ3OTNiZWJkOWQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidmZnRUhMYWRORU05WjZyQklrVkUySmtEbzA4Y1RpRDFtXC9CMDJEUU5LT1wvQU9yY1BhenZDU1lyQSs3TEJONWhYIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:37:29 -0000 Hi Joseph, > -----Original Message----- > From: Anoob Joseph [mailto:anoobj@marvell.com] > Sent: Thursday, January 17, 2019 9:40 AM > To: Akhil Goyal ; De Lara Guarch, Pablo ; Trahe, > Fiona > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran ; Narayana > Prasad Raju Athreya ; Shally Verma ; dev@dpdk.org > Subject: [PATCH] doc: announce ABI change for cryptodev config >=20 > Add new field ff_enable in rte_cryptodev_config. This enables > applications to control the features enabled on the crypto device. >=20 > Proposed new layout: >=20 > /** Crypto device configuration structure */ > struct rte_cryptodev_config { > int socket_id; /**< Socket to allocate resources on */ > uint16_t nb_queue_pairs; > /**< Number of queue pairs to configure on device */ > + uint64_t ff_enable; > + /**< Feature flags to be enabled on the device. Only the features set > + * on rte_cryptodev_info.feature_flags are allowed to be set. > + */ > }; >=20 > For eth devices, rte_eth_conf.rx_mode.offloads and > rte_eth_conf.tx_mode.offloads fields are used by applications to > control the offloads enabled on the eth device. This proposal adds a > similar ability for the crypto device. [Fiona] I'm unfamiliar with eth config so can you explain a bit more how th= is works? e.g. if a crypto device's info says it supports =20 RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING RTE_CRYPTODEV_FF_CPU_AESNI RTE_CRYPTODEV_FF_SECURITY RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT these things are all already enabled. Is the param a way to disable some of them? If so, it would be better to call it ff_disable. And to limit it to the subset of features that it makes sense to disable. i.e. why would an application disable chaining or any of the SGL flags? It = would just add extra cycles in the PMD to error check on these cases, instead the appl can just not se= nd such commands. And it doesn't make sense to disable AESNI or RTE_CRYPTODEV_FF_HW_ACCELERAT= ED. Actually I can't see what an application would want to achieve by disabling= any flag?