From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 90D475F72 for ; Tue, 5 Feb 2019 14:02:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2019 05:02:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,564,1539673200"; d="scan'208";a="141719903" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 05 Feb 2019 05:02:26 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.213]) by IRSMSX104.ger.corp.intel.com ([169.254.5.101]) with mapi id 14.03.0415.000; Tue, 5 Feb 2019 13:02:26 +0000 From: "Trahe, Fiona" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "shally.verma@caviumnetworks.com" , "sunila.sahu@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "umesh.kartha@caviumnetworks.com" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH] cryptodev: rework mod exp and mod inv comments Thread-Index: AQHUvUPghMkAYs4YjE+p1ztTM8jvHqXRJ71Q Date: Tue, 5 Feb 2019 13:02:25 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896DA2DA@IRSMSX101.ger.corp.intel.com> References: <20190205111319.2104-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190205111319.2104-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjgxNWMyYTAtZTM5Mi00MWEzLWE4NDktZTRjODRiMmUzYTU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic2lWMWFndWRxMEdNdjBSN2YzOGMzeVAzQk02M0JGR2FpUFhKM1JNWFRiXC93dWlqZkZQNGt4RkpaZkYxV1lPMUoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: rework mod exp and mod inv comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2019 13:02:30 -0000 Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Tuesday, February 5, 2019 11:13 AM > To: dev@dpdk.org > Cc: shally.verma@caviumnetworks.com; sunila.sahu@caviumnetworks.com; > ashish.gupta@caviumnetworks.com; umesh.kartha@caviumnetworks.com; Trahe, = Fiona > ; akhil.goyal@nxp.com; Kusztal, ArkadiuszX > Subject: [PATCH] cryptodev: rework mod exp and mod inv comments >=20 > This patch changes modular exponentiation and modular multiplicative > inverse API comments to make it more precise. >=20 > Signed-off-by: Arek Kusztal > + * In case this number is equal to zero driver set crypto op > + * status field to RTE_CRYPTO_OP_STATUS_ERROR [Fiona] grammar nit - ....the driver should set the crypto op..... > - * Structure describing modulus inverse xform params > + * Structure describing modular multiplicative inverse transform xform p= arams [Fiona] grammar nit - no need for transform and xform - one will do.=20 > + * In case this number is equal to zero driver set crypto op > + * status field to RTE_CRYPTO_OP_STATUS_ERROR [Fiona] grammar nit - same comment as above=20 > + * > + * This number need to be relatively prime to base > + * in corresponding Modular Multiplicative Inverse > + * rte_crypto_mod_op_param > */ [Fiona] grammar nit - "The number needs..." or "This number should be"=20 > struct rte_crypto_mod_op_param { > rte_crypto_param base; > /**< > - * Pointer to base of modular exponentiation/inversion data in > - * Octet-string network byte order format. > + * Pointer to base of modular exponentiation/multiplicative > + * inverse data in Octet-string network byte order format. [Fiona] grammar nit - octet-string - no need for capitalisation > + * > + * In case Multiplicative Inverse is used this number need > + * to be relatively prime to modulus in corresponding Modular > + * Multiplicative Inverse rte_crypto_modinv_xform [Fiona] grammar nit - same comment as above