From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 057F0F94 for ; Mon, 4 Mar 2019 15:47:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2019 06:47:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,440,1544515200"; d="scan'208";a="119477664" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga007.jf.intel.com with ESMTP; 04 Mar 2019 06:47:55 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.185]) by irsmsx105.ger.corp.intel.com ([169.254.7.72]) with mapi id 14.03.0415.000; Mon, 4 Mar 2019 14:47:54 +0000 From: "Trahe, Fiona" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" , "Trahe, Fiona" Thread-Topic: [PATCH] crypto/aesni_mb: support newer version library only Thread-Index: AQHU0oBK4QuthCpOv0a5OoUE3Sj5BKX7jPUA Date: Mon, 4 Mar 2019 14:47:54 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896FE842@IRSMSX101.ger.corp.intel.com> References: <20190304114717.18152-1-roy.fan.zhang@intel.com> In-Reply-To: <20190304114717.18152-1-roy.fan.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2MzODA4MjMtNjdjMC00ZTU3LWE4NDQtNmQ2OGVmNTYyMDk5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1wvY0pEdnVwTnBjRlp1VkNMdkpZSjBJOTlKeTdmSkpSQXJpMzhJMEYwcjVJNFZQZ1lJWFA0TXYrWTJDRVJHTFQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: support newer version library only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 14:47:58 -0000 Hi Fan, > -----Original Message----- > From: Zhang, Roy Fan > Sent: Monday, March 4, 2019 11:47 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Zhang, Roy Fan ; Kuszta= l, ArkadiuszX > ; Trahe, Fiona > Subject: [PATCH] crypto/aesni_mb: support newer version library only >=20 > As stated in 19.02 deprecation notice, this patch updates the > aesni_mb PMD to remove the support of older Intel-ipsec-mb > library version eariler than 0.52. >=20 > Signed-off-by: Fan Zhang > --- > Although the PMD dependency to the library is changed, the ABI/API > are not updated as the APIs to access the PMD remains intact. When > the user compile the PMD a error message "IPSec MB version >=3D > 0.52" will be displayed to inform the user to update the library. >=20 > doc/guides/cryptodevs/aesni_mb.rst | 8 +- > doc/guides/rel_notes/deprecation.rst | 3 - > drivers/crypto/aesni_mb/Makefile | 21 +- > drivers/crypto/aesni_mb/aesni_mb_ops.h | 302 ----- > drivers/crypto/aesni_mb/meson.build | 13 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c | 1313 --------------= ------ > .../crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c | 745 ----------- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 37 - > 8 files changed, 16 insertions(+), 2426 deletions(-) > delete mode 100644 drivers/crypto/aesni_mb/aesni_mb_ops.h > delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c > delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c >=20 > diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/a= esni_mb.rst > index 47f2ecc2f..d3567d279 100644 > --- a/doc/guides/cryptodevs/aesni_mb.rst > +++ b/doc/guides/cryptodevs/aesni_mb.rst > @@ -57,10 +57,7 @@ Limitations >=20 > * Chained mbufs are not supported. > * Only in-place is currently supported (destination address is the same = as source address). > -* RTE_CRYPTO_AEAD_AES_GCM only works properly when the multi-buffer libr= ary is > - 0.51.0 or newer. > -* RTE_CRYPTO_HASH_AES_GMAC is supported by library version v0.51 or late= r. > -* RTE_CRYPTO_HASH_SHA* is supported by library version v0.52 or later. > +* Only support Intel multi buffer library version 0.52 or later. >=20 >=20 > Installation > @@ -92,7 +89,8 @@ and the Multi-Buffer library version supported by them: > 17.05 - 17.08 0.45 - 0.48 > 17.11 0.47 - 0.48 > 18.02 0.48 > - 18.05+ 0.49+ > + 18.05 0.49 > + 19.02+ 0.52+ [Fiona] shouldn't this be=20 19.05+ 0.52+