From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: Ankur Dwivedi <adwivedi@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Suheil Chandran <schandran@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison
Date: Mon, 11 Mar 2019 10:41:29 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B43589711D42@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1552283715-18723-1-git-send-email-anoobj@marvell.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
> Sent: Monday, March 11, 2019 5:56 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch,
> Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Ankur Dwivedi <adwivedi@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Narayana Prasad Raju Athreya <pathreya@marvell.com>; Suheil
> Chandran <schandran@marvell.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison
>
> The string compare to the length of driver name might give false
> positives when there are drivers with similar names (one being the
> subset of another).
>
> Following is such a naming which could result in false positive.
> 1. crypto_driver
> 2. crypto_driver1
>
> When strncmp with len = strlen("crypto_driver") is done, it could give
> a false positive when compared against "crypto_driver1". For such cases,
> 'strlen + 1' is done, so that the NULL termination also would be
> considered for the comparison.
>
> Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices")
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
next prev parent reply other threads:[~2019-03-11 10:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 11:26 [dpdk-dev] [PATCH] " Anoob Joseph
2019-02-20 15:41 ` Anoob Joseph
2019-02-21 17:03 ` Trahe, Fiona
2019-02-22 4:47 ` Anoob Joseph
2019-02-22 15:39 ` Trahe, Fiona
2019-02-23 6:11 ` Anoob Joseph
2019-02-25 11:52 ` Trahe, Fiona
2019-02-28 6:48 ` Anoob Joseph
2019-02-28 8:51 ` Akhil Goyal
2019-02-28 9:27 ` Anoob Joseph
2019-02-28 10:20 ` Akhil Goyal
2019-02-28 14:30 ` Trahe, Fiona
2019-03-01 6:24 ` Anoob Joseph
2019-03-07 5:51 ` Anoob Joseph
2019-03-11 5:55 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2019-03-11 10:41 ` Trahe, Fiona [this message]
2019-03-19 4:38 ` Anoob Joseph
2019-03-19 4:38 ` Anoob Joseph
2019-03-19 13:42 ` Akhil Goyal
2019-03-19 13:42 ` Akhil Goyal
2019-03-19 14:06 ` Akhil Goyal
2019-03-19 14:06 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B43589711D42@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=schandran@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).