Re: [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD

["Trahe, Fiona" <fiona.trahe@intel.com>]

Hi Arek,

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 27, 2019 11:17 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD
> 
> This patch adds Poll Mode Driver for asymmetric crypto
> functions of Intel QuickAssist Technology hardware.
> 
> It contains plain driver with no functions implmented, specific
> algorithms will be introduced in separate patches.
> 
> This patch depends on a QAT PF driver for device initialization. See
> the file docs/guides/cryptodevs/qat.rst for configuration details.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
//snip///

> +void
> +qat_asym_process_response(void **op, uint8_t *resp,
> +		void *op_cookie)
> +{
> +	struct icp_qat_fw_pke_resp *resp_msg =
> +			(struct icp_qat_fw_pke_resp *)resp;
> +	struct rte_crypto_op *rx_op = (struct rte_crypto_op *)(uintptr_t)
> +			(resp_msg->opaque);
> +	struct qat_asym_op_cookie *cookie = op_cookie;
> +
> +	*op = rx_op;
> +	rx_op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
> +
[Fiona] Need to check for response_type == NULL - don't use the resp_status field in this case - get the error from the cookie instead.