From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 55B705398 for ; Wed, 27 Mar 2019 19:19:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 11:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="144387423" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 27 Mar 2019 11:19:06 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 18:19:05 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.230]) by irsmsx111.ger.corp.intel.com ([169.254.2.24]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 18:19:05 +0000 From: "Trahe, Fiona" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD Thread-Index: AQHU5I807E3mj6fGLEi8b+6KPYqNzaYfyMkA Date: Wed, 27 Mar 2019 18:19:04 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358972086A@IRSMSX101.ger.corp.intel.com> References: <20190327111720.13732-1-arkadiuszx.kusztal@intel.com> <20190327111720.13732-3-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190327111720.13732-3-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGRjNmMyZDMtYzIxZi00ZWRhLWFmNGEtMmJlYzY1NTU3NzYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN3RadkZYd2FDbVo3QmRoT1FVUDNaSCtzbzNSREMzN2I2N0xhSXhTTGhuejFYZ0xqUDIyRXJVcENKS3ZZakJnVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 18:19:09 -0000 Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 27, 2019 11:17 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > > Subject: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD >=20 > This patch adds Poll Mode Driver for asymmetric crypto > functions of Intel QuickAssist Technology hardware. >=20 > It contains plain driver with no functions implmented, specific > algorithms will be introduced in separate patches. >=20 > This patch depends on a QAT PF driver for device initialization. See > the file docs/guides/cryptodevs/qat.rst for configuration details. >=20 > Signed-off-by: Arek Kusztal //snip/// > +void > +qat_asym_process_response(void **op, uint8_t *resp, > + void *op_cookie) > +{ > + struct icp_qat_fw_pke_resp *resp_msg =3D > + (struct icp_qat_fw_pke_resp *)resp; > + struct rte_crypto_op *rx_op =3D (struct rte_crypto_op *)(uintptr_t) > + (resp_msg->opaque); > + struct qat_asym_op_cookie *cookie =3D op_cookie; > + > + *op =3D rx_op; > + rx_op->status =3D RTE_CRYPTO_OP_STATUS_NOT_PROCESSED; > + [Fiona] Need to check for response_type =3D=3D NULL - don't use the resp_st= atus field in this case - get the error from the cookie instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79117A05D3 for ; Wed, 27 Mar 2019 19:19:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4B9C5689; Wed, 27 Mar 2019 19:19:10 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 55B705398 for ; Wed, 27 Mar 2019 19:19:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 11:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="144387423" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 27 Mar 2019 11:19:06 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 18:19:05 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.230]) by irsmsx111.ger.corp.intel.com ([169.254.2.24]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 18:19:05 +0000 From: "Trahe, Fiona" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD Thread-Index: AQHU5I807E3mj6fGLEi8b+6KPYqNzaYfyMkA Date: Wed, 27 Mar 2019 18:19:04 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358972086A@IRSMSX101.ger.corp.intel.com> References: <20190327111720.13732-1-arkadiuszx.kusztal@intel.com> <20190327111720.13732-3-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190327111720.13732-3-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGRjNmMyZDMtYzIxZi00ZWRhLWFmNGEtMmJlYzY1NTU3NzYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN3RadkZYd2FDbVo3QmRoT1FVUDNaSCtzbzNSREMzN2I2N0xhSXhTTGhuejFYZ0xqUDIyRXJVcENKS3ZZakJnVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327181904.QlAHz0hgrNYsxtus7UjxgO4pWsz3c86oEv52zmR2bRw@z> Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 27, 2019 11:17 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > > Subject: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD >=20 > This patch adds Poll Mode Driver for asymmetric crypto > functions of Intel QuickAssist Technology hardware. >=20 > It contains plain driver with no functions implmented, specific > algorithms will be introduced in separate patches. >=20 > This patch depends on a QAT PF driver for device initialization. See > the file docs/guides/cryptodevs/qat.rst for configuration details. >=20 > Signed-off-by: Arek Kusztal //snip/// > +void > +qat_asym_process_response(void **op, uint8_t *resp, > + void *op_cookie) > +{ > + struct icp_qat_fw_pke_resp *resp_msg =3D > + (struct icp_qat_fw_pke_resp *)resp; > + struct rte_crypto_op *rx_op =3D (struct rte_crypto_op *)(uintptr_t) > + (resp_msg->opaque); > + struct qat_asym_op_cookie *cookie =3D op_cookie; > + > + *op =3D rx_op; > + rx_op->status =3D RTE_CRYPTO_OP_STATUS_NOT_PROCESSED; > + [Fiona] Need to check for response_type =3D=3D NULL - don't use the resp_st= atus field in this case - get the error from the cookie instead.