From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <fiona.trahe@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A691C1B5EC for <dev@dpdk.org>; Wed, 17 Apr 2019 13:32:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 04:32:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208";a="292293338" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 17 Apr 2019 04:32:02 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 12:32:02 +0100 From: "Trahe, Fiona" <fiona.trahe@intel.com> To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [PATCH] doc: add cryptodev gcm iv deprecation notice Thread-Index: AQHU9PEJ2WNgiU+25EeZ1tGBhGLsUKZAN6Qg Date: Wed, 17 Apr 2019 11:32:01 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589743C1B@IRSMSX101.ger.corp.intel.com> References: <20190417074113.10896-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190417074113.10896-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjVkMjg0YWMtZTBiOC00YTQ1LWIzMmMtZmJlMTc1MzY4YWYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRDhUeGZnc1owNitUeHhNXC92ejZqQkdUZlQxSk42OEpJbUJlQ21RYlV3aXBScncrVkZLWHVxM1ZMOWZIdWdsNDAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Apr 2019 11:32:05 -0000 > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, April 17, 2019 8:41 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara Gu= arch, Pablo > <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal= @intel.com> > Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice >=20 > This patch adds deprecation notice of changing iv behaviour > when using Galois Counter Mode of operation. Right now IV of > all supported sizes can be used. [Fiona] nit - I would say "With this change..." rather than "Right now..." Apart from this Acked-by: Fiona Trahe <fiona.trahe@intel.com> >=20 > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index ba39c2d..76eb166 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -87,3 +87,9 @@ Deprecation Notices > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xf= orms > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > + > +* cryptodev: support for using IV with all sizes is added, J0 still can > + be used but only when IV length in following structs ``rte_crypto_auth= _xform``, > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or= equal > + to one it means it represents IV, when is set to zero it means J0 is u= sed > + directly, in this case 16 bytes of J0 need to be passed. > -- > 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6CCE8A00E6 for <public@inbox.dpdk.org>; Wed, 17 Apr 2019 13:32:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DBFD1B5ED; Wed, 17 Apr 2019 13:32:07 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A691C1B5EC for <dev@dpdk.org>; Wed, 17 Apr 2019 13:32:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 04:32:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208";a="292293338" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 17 Apr 2019 04:32:02 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 12:32:02 +0100 From: "Trahe, Fiona" <fiona.trahe@intel.com> To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [PATCH] doc: add cryptodev gcm iv deprecation notice Thread-Index: AQHU9PEJ2WNgiU+25EeZ1tGBhGLsUKZAN6Qg Date: Wed, 17 Apr 2019 11:32:01 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589743C1B@IRSMSX101.ger.corp.intel.com> References: <20190417074113.10896-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190417074113.10896-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjVkMjg0YWMtZTBiOC00YTQ1LWIzMmMtZmJlMTc1MzY4YWYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRDhUeGZnc1owNitUeHhNXC92ejZqQkdUZlQxSk42OEpJbUJlQ21RYlV3aXBScncrVkZLWHVxM1ZMOWZIdWdsNDAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190417113201.GShrhcWg9MThHZiePs2KYI3x8KwMX12yo-zUvK7bWJg@z> > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, April 17, 2019 8:41 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara Gu= arch, Pablo > <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal= @intel.com> > Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice >=20 > This patch adds deprecation notice of changing iv behaviour > when using Galois Counter Mode of operation. Right now IV of > all supported sizes can be used. [Fiona] nit - I would say "With this change..." rather than "Right now..." Apart from this Acked-by: Fiona Trahe <fiona.trahe@intel.com> >=20 > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index ba39c2d..76eb166 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -87,3 +87,9 @@ Deprecation Notices > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xf= orms > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > + > +* cryptodev: support for using IV with all sizes is added, J0 still can > + be used but only when IV length in following structs ``rte_crypto_auth= _xform``, > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or= equal > + to one it means it represents IV, when is set to zero it means J0 is u= sed > + directly, in this case 16 bytes of J0 need to be passed. > -- > 2.1.0