From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D4DE7A045E for ; Mon, 27 May 2019 18:01:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B06749E4; Mon, 27 May 2019 18:01:05 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 09D91A3 for ; Mon, 27 May 2019 18:01:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 09:01:02 -0700 X-ExtLoop1: 1 Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 27 May 2019 09:01:02 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.10]) by IRSMSX109.ger.corp.intel.com ([169.254.13.162]) with mapi id 14.03.0415.000; Mon, 27 May 2019 17:01:01 +0100 From: "Trahe, Fiona" To: "Daly, Lee" , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [PATCH] compress/isal: fix use after free Thread-Index: AQHVD+bprY3U4gIlWEmnUtvcDd47v6Z/Krow Date: Mon, 27 May 2019 16:00:59 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589773168@IRSMSX101.ger.corp.intel.com> References: <20190521144713.12046-1-stephen@networkplumber.org> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcxMzcxN2YtN2Q5OC00YjRiLWE2ZTktM2FjNzUwZTNlMGQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ3duYlY4NFNVSmZBRTJQTEJCWUw1U2RYQXJQUGJSY2JMVGppdUxmWVRVNlZHQU9HVXo5MWZBU2ZsdjdDczRUbyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compress/isal: fix use after free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Daly, Lee > Sent: Tuesday, May 21, 2019 4:08 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH] compress/isal: fix use after free >=20 > Hi Stephen, > Thanks for the patch. >=20 > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Tuesday, May 21, 2019 3:47 PM > > To: Daly, Lee > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: [PATCH] compress/isal: fix use after free > > > > The release function was using qp->stream after already releasing it an= d the > > null pointer checking was missing. > > > > Also since rte_free(NULL) is a no-op, remove unnecessary checks for NUL= L. > > > > Coverity issure: 340860 > > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionalit= y") > > Signed-off-by: Stephen Hemminger > > --- Acked-by: Lee Daly Acked-by: Fiona Trahe