From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 284F9A00E6 for ; Thu, 13 Jun 2019 16:16:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 639E91D5DD; Thu, 13 Jun 2019 16:16:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1C0481D5D4 for ; Thu, 13 Jun 2019 16:16:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 07:16:18 -0700 X-ExtLoop1: 1 Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 13 Jun 2019 07:16:17 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 15:16:16 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.80]) by IRSMSX156.ger.corp.intel.com ([169.254.3.125]) with mapi id 14.03.0415.000; Thu, 13 Jun 2019 15:16:16 +0100 From: "Trahe, Fiona" To: "Nowak, DamianX" , "dev@dpdk.org" CC: "Kusztal, ArkadiuszX" , Akhil Goyal , "De Lara Guarch, Pablo" , "Trahe, Fiona" Thread-Topic: [PATCH v2 02/10] cryptodev: add digest encrypted feature flag Thread-Index: AQHVHRkdus+DoeYy9Eifzk7x0hsge6aZqUeQ Date: Thu, 13 Jun 2019 14:16:15 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358978FC17@IRSMSX101.ger.corp.intel.com> References: <20190603145048.2596-1-damianx.nowak@intel.com> <20190607100608.16212-1-damianx.nowak@intel.com> <20190607100608.16212-3-damianx.nowak@intel.com> In-Reply-To: <20190607100608.16212-3-damianx.nowak@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQxMmUyYjktZjRiMy00Njc0LTk4ODctNDUxMzJkNDliMTYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ2lUSFo1aVp3WDNQXC9OS0lvWHlmNDRlU3IrODQrSlFuUHhoZ0s5TFNDTW1HU2ZyeUN5UXVSMXYyYllyK01BR04ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 02/10] cryptodev: add digest encrypted feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Damian, > -----Original Message----- > From: Nowak, DamianX > Sent: Friday, June 7, 2019 11:06 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX ; Nowak, > DamianX > Subject: [PATCH v2 02/10] cryptodev: add digest encrypted feature flag >=20 > Some PMDs can only support digest being > encrypted separately in auth-cipher operations. > Thus it is required to add feature flag in PMD > to reflect if it does support digest-appended > both: digest generation with encryption and > decryption with digest verification. >=20 > Signed-off-by: Damian Nowak > --- > lib/librte_cryptodev/rte_cryptodev.c | 2 ++ > lib/librte_cryptodev/rte_cryptodev.h | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/= rte_cryptodev.c > index 00c2cf4..f657192 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -490,6 +490,8 @@ rte_cryptodev_get_feature_name(uint64_t flag) > return "RSA_PRIV_OP_KEY_EXP"; > case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT: > return "RSA_PRIV_OP_KEY_QT"; > + case RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED: > + return "DIGEST_ENCRYPTED"; [Fiona] This feature flag should be added to the matrix here: http://doc.dpdk.org/guides/cryptodevs/overview.html#supported-feature-flags