Re: [dpdk-dev] [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto

["Trahe, Fiona" <fiona.trahe@intel.com>]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, July 3, 2019 4:38 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; shally.verma@caviumnetworks.com;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto
> 
> Most things from v1 were simplified according to Shally adn Fiona comments.
> No more rfc details in comments and some things were shortened.
> There is no more struct for padding too, but only union for
> PSS and OAEP.
> Added test case for padding none with encryption (pkcs padding is done in test)
> ps. I will send signature padding none signature case soon.
> 
> Major changes comparing to current version:
> - Cipher field was introduced
> - Added guide to use none padding
> - Field for singature verification when padding none selected was added
> 	(as there is no Public-Decrypt)
> - Padding union was created
> - PKCS1-v1_5 Block type 0 was removed
> - Fixed all wrong comments (prime numbers etc.)
> 
> v2:
> - Field for singature verification when padding none selected was added
> - Removed details from RFC
> - Simplified padding struct
> - Added padding none test case
> 
> Arek Kusztal (3):
>   cryptodev: rework api of rsa algorithm
>   crypto/openssl: rework openssl rsa implementation
>   test: rework rsa test implementation
> 
>  app/test/test_cryptodev_asym.c           |  44 +++++++--
>  app/test/test_cryptodev_asym_util.h      |  52 +++++++++++
>  drivers/crypto/openssl/rte_openssl_pmd.c |  67 ++++++++------
>  lib/librte_cryptodev/rte_crypto_asym.h   | 150 ++++++++++++++++++++++++-------
>  4 files changed, 243 insertions(+), 70 deletions(-)
> 
> --
> 2.1.0
[Fiona] There are a few spelling mistakes still, but as this API is still experimental and will
have further changes in 19.11 which can address those, I would not like to block this patchset now, so
Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>