From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 5675368C8 for ; Mon, 24 Mar 2014 23:37:54 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id n12so3814226wgh.0 for ; Mon, 24 Mar 2014 15:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=te8UFG4uDvuw9l3PFj9NzElIzEPKVB5+jjgPCf2c6ow=; b=dvZjQTtYdfHJU4x1M5PEbZDhl4AQ3zmO3mPsoMpuqIxMA+noIIUzX0W/s8XFddAjY6 f5UAA4BZAMGXxf5iDOKcGHPApF6EwAKupN2I0E0thUpWSMr2GlhM7RyNB3VZ19p+gp0w OyzfhkvKX505ONFqWA5iPmN4fm4G7UzKS2i6Yx9fs+ccrBKmdb1xIlR1Cj86/989+5j/ v1bfonjylMH4GTwcEhLx8aRJBO3WFKiVZSgmfiUw6GJ30SwcTslNENvztc8c5cPQbZwT 5WUiFhMFvw4NaCJ0vz3QLvUOm8raDTf5RUJb7xHbvWnmIghSSqKXal6qUIg5gzj0CGf3 L8Lg== X-Gm-Message-State: ALoCoQnjNzF/voo0vunxIjVChAqYxeAOCSAXsynprpsm4Rg1e/DiP8k/l7WA8f9lk67ff+WhD4YA X-Received: by 10.180.188.229 with SMTP id gd5mr18907400wic.54.1395700767018; Mon, 24 Mar 2014 15:39:27 -0700 (PDT) Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213]) by mx.google.com with ESMTPSA id f3sm43671070wiv.2.2014.03.24.15.39.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Mar 2014 15:39:26 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" , Olivier MATZ Date: Mon, 24 Mar 2014 23:39:25 +0100 Message-ID: <34903726.bp1idtuf7I@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.6-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com> References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <5315D081.20506@6wind.com> <59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Mar 2014 22:37:54 -0000 Hi, 04/03/2014 13:14, Richardson, Bruce: > 04/03/2014 14:09, Olivier MATZ: > > My initial concern was that --use-device has 2 different significations, > > depending on the format of arguments: > > - instanciate a virtual driver if it looks like a vdev name > > - add a PCI device to the whitelist if it looks like a pci address > > I also find strange that instanciating a virtual device changes the PCI > > mode to whitelist, even if it could be fixed by adding a specific argument > > for that. > > [BR] I agree that having the mode change silently like that was probably not > the best design. I therefore, agree that a flag should be used to switch > from normal to whitelist mode, I just think that thereafter the devices of > whatever type should all be enumerated using a common flag parameter. I think we should split this in 2 functions because they have totally different meaning: - create a virtual device and instantiate a driver - whitelist a physical device for driver probing Using the same option for vdev and whitelist would be even more confusing in case of blacklist because drivers would probe explicitly listed vdevs and PCI devs which are not blacklisted. -- Thomas