From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8B540A0547;
	Wed, 15 Jun 2022 20:58:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 75912427EB;
	Wed, 15 Jun 2022 20:58:33 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 74326410D0
 for <dev@dpdk.org>; Wed, 15 Jun 2022 20:58:31 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id E0D373200D00;
 Wed, 15 Jun 2022 14:58:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Wed, 15 Jun 2022 14:58:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm2; t=1655319509; x=
 1655405909; bh=ie3QcHiisPC/ziiHpoA9k773xVohiJNzDB+PfhjxKAc=; b=e
 DmcUc7JQotaPCflxPHQklmUYO3NhvafiRsY/St7J5T1iPGV0AIQ8iW3T2PGWasbX
 GmltjMvNqMbNXgu9+/HlDaT43jtQ0JnVNr/mH4STrJ4Y5/kax4LTpSmt3L7GtYaD
 aABgh2CIK8k6tdCUgqcNNe872mBbS9EbXwSrLmUGbyz6G4zr4kkotskZrJmeSahE
 Glkv9jfeB3DKKDDGNSENpgqlEQ9OTKjhzFZi2CzkXyBfcBXPCugdlWKeWh1WpV5q
 EpVNS3fnuXfU/UtJvrTRmIyZN4TJDf51nhPv5TOy58v2a4LsgU8P7N1eVcgxrZGb
 cKzgDAz98bBQ/fdsAPYtg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655319509; x=
 1655405909; bh=ie3QcHiisPC/ziiHpoA9k773xVohiJNzDB+PfhjxKAc=; b=j
 wlf5JP7cDY6ZzlR4RSWiNB2Tc4ANJhI7F28snYX5P3oL1eb65HAbEBhgKVllgDK2
 mM/ueYrbDxJwyStxZbufH7b9rhYjeugy66o8DlG5Bs3rnTeAkGfGq6SNBKnyC5Gc
 3bwbhHz85pwpskSptDG/M/tqfXxh3rTQMSMBYJo37eDv2uXxnH2oSSS0T3KnDman
 sz5HcMv8188IHRp75iawTpoIYvT5Ayyj0QHEmGxiMTrl+GUWvte1K8T92r0es1s0
 nP+sIAiP6K8MDpY1AaZ4NkVk+x/KKYcNHZfEdgVr9RzkUOVgUqMiMdzMYfFlqTs6
 MGCPgSBOj8zkJv+LqwGcQ==
X-ME-Sender: <xms:1SuqYgQvPacZzLh5itgQTwtgZbzDzOoOCdxkznMV0EfXOlaU11DJ1g>
 <xme:1SuqYty48EQkkLqtqEcWv3CU0cyYAFOzIYGi2RBynWGEv6FX4MwbvGnS6GdHutbaQ
 wsxOBvyKvPPb6Th5w>
X-ME-Received: <xmr:1SuqYt21xMquTD4IJlo6yk0iTTLE4Z1NKKINB_yLFFgrmXmp3vtGak4VBly8T9G2UsLovoNNRF3Wua4cY4_Rw-FRtQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvuddguddvkecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho
 mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
 cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt
 ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:1SuqYkBpxaOiHNh65n_RItFjr7gyjmyHgLo0XLc7R7hxL67PcoPFFQ>
 <xmx:1SuqYpgU4drZkURszM4zFVu0wDIFbY9W0jqtCor0-1Q364yWNwPoJA>
 <xmx:1SuqYgrxXLffHGMYgLWHVuAqusbZMPsOU86-Xp2xbBDUGLAuouHd4g>
 <xmx:1SuqYpZcaMpiyBkureopZGOahL6mN5TWPZ176Nh4rZOBBf-Ie6YahQ>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 15 Jun 2022 14:58:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jakub Palider <jpalider@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence
Date: Wed, 15 Jun 2022 20:58:27 +0200
Message-ID: <3490937.iZASKD2KPV@thomas>
In-Reply-To: <PH0PR18MB45735A778D450E5498267760D5AD9@PH0PR18MB4573.namprd18.prod.outlook.com>
References: <20220613222143.1436424-1-jpalider@marvell.com>
 <5848204.lOV4Wx5bFT@thomas>
 <PH0PR18MB45735A778D450E5498267760D5AD9@PH0PR18MB4573.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

15/06/2022 10:46, Jakub Palider:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Wednesday, June 15, 2022 8:21 AM
> > To: Jakub Palider <jpalider@marvell.com>
> > Cc: dev@dpdk.org; david.marchand@redhat.com
> > Subject: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > 14/06/2022 00:21, jpalider@marvell.com:
> > > +		SEQ[0] = "Coverity issue";
> > > +		SEQ[1] = "Bugzilla ID";
> > > +		SEQ[2] = "Fixes";
> > > +		SEQ[3] = "Cc";
> > > +		SEQ[4] = "^$";
> > > +		SEQ[5] = "Suggested-by";
> > > +		SEQ[6] = "Reported-by";
> > > +		SEQ[7] = "Signed-off-by";
> > > +		latest = 0;
> > 
> > Do you think you could check that Review, Ack and Test are added after the
> > first Signed-off?
> 
> Ok, thank you for clarification. So any further Signed-offs need not to be in a particular 
> sequence as long as the first one precedes Review/Ack/Test (these 3 in any order).

Yes

> > > +Tag order
> > > +~~~~~~~~~
> > > +
> > > +There is a pattern indicating how certain tags should relate to each other.
> > > +
> > > +Example of proper tag sequence::
> > > +
> > > +     Coverity issue:
> > > +     Bugzilla ID:
> > > +     Fixes:
> > > +     Cc:
> > > +
> > > +     Suggested-by:
> > > +     Reported-by:
> > > +     Signed-off-by:
> > 
> > Given it is an example, you could add Reviewed-by, Acked-by and Tested-by.
> 
> Sure, I will restore it.
> 
> > > +
> > > +Between first and second tag section there is and empty line.
> > > +
> > > +While ``Signed-off-by:`` is an obligatory tag and must exists in each
> > > +commit, all other tags are optional. Any tag, as long as it is in
> > > +proper location to other adjacent tags (if present), may occur multiple
> > times.
> > > +
> > > +Other tags shall be laid out in a chronological order.
> > 
> > Yes, after the first Signed-off-by.
> 
> Side question: what about Sponsored-by, I noticed it appeared just recently?

It is a way to add the name of a company wishing to appear.
There is no constraint on it, it can be anywhere I think.
If it is in chronological order, it looks better before the Signed-off.
I think we should not advertise it here, because real names are more useful.