From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m13-44.163.com (m13-44.163.com [220.181.13.44]) by dpdk.org (Postfix) with ESMTP id 9B6C3292D for ; Tue, 22 Aug 2017 06:45:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=eNH/k VukrwATdszEyVxHUHgkMOOkIvNDoxZw6QMioyE=; b=Ke7aGfoiV7U8kqWH8I3l9 w1iOMg9NpuOBuGv0oMpnvva9rl8yQmYNUb4YWH3S0A+zjSAfyPfaFl0qKaQ+GIbA RiyClXms5+IcObdiTInn+wzC03LwLnr9Vpv/VROkAnxKeBRzAqjXVIZQinfDiF/D b4zWqpNXvYKq36m0jX1jBk= Received: from zimeiw$163.com ( [131.228.2.21] ) by ajax-webmail-wmsvr44 (Coremail) ; Tue, 22 Aug 2017 12:45:26 +0800 (CST) X-Originating-IP: [131.228.2.21] Date: Tue, 22 Aug 2017 12:45:26 +0800 (CST) From: zimeiw To: dev@dpdk.org X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com In-Reply-To: <2f4bdab7-9873-e293-26fd-36ef5f2d80a1@126.com> References: <2f4bdab7-9873-e293-26fd-36ef5f2d80a1@126.com> X-CM-CTRLDATA: 1mWkn2Zvb3Rlcl9odG09ODE4OjU2 MIME-Version: 1.0 Message-ID: <34912f2e.542d.15e084275cd.Coremail.zimeiw@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: LMGowABHT+_ptptZdX2cAA--.61334W X-CM-SenderInfo: 52lpvxrz6rljoofrz/xtbBUQc80laDvFh5xAAAs0 X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Intel 82599ES send packets failed on dpdk-17.05.1 after traffic testing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 04:45:35 -0000 aGksCk15IHRlc3QgZW52IGlzIGRlbGwgVDQzMCBzZXJ2ZXIsIE5JQyBpcyBpbnRlbCA4MjU5OUVT LgpJIGludGVncmF0ZSBteSBhcHAgd2l0aCBkcGRrLTE3LjA1LjEgdmVyc2lvbi4gYWZ0ZXIgZG8g c29tZSB0Y3AgdHJhZmZpYyB0ZXN0aW5nLCBhcHAgY2FuIHJlY2VpdmUgcGFja2V0cyBmcm9tIHRo ZSA4MjU5OSBOSUMsIGJ1dCA4MjU5OSBOSUMgc2VuZCBwYWNrZXRzIGZhaWxlZC4KQnV0IG15IGFw cCB3aXRoIGRwZGstMTcuMDIgd29ya3Mgd2VsbC4gCgoKSWYgYW55IGNoYW5nZSB3aXRoIGl4Z2Jl IGRyaXZlcj8gb3IgbmVlZCBzb21lIGFkZGl0aW9uYWwgY29uZmlndXJhdGlvbiBmb3IgdGhlIE5J Qz8KCgoKVGhhbmtzLgoKCi0tCgpCZXN0IFJlZ2FyZHMsCnppbWVpdwoK >From han.li1@zte.com.cn Tue Aug 22 07:04:33 2017 Return-Path: Received: from zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 12C2D7D24 for ; Tue, 22 Aug 2017 07:04:32 +0200 (CEST) X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170822130412 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 22 Aug 2017 05:04:12 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v7M54IHf049222; Tue, 22 Aug 2017 13:04:18 +0800 (GMT-8) (envelope-from han.li1@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.171]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017082213042063-471418 ; Tue, 22 Aug 2017 13:04:20 +0800 From: Li Han To: jingjing.wu@intel.com Cc: dev@dpdk.org, Li Han Date: Tue, 22 Aug 2017 13:03:42 +0800 Message-Id: <1503378222-23306-1-git-send-email-han.li1@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-08-22 13:04:20, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-08-22 13:04:14, Serialize complete at 2017-08-22 13:04:14 X-MAIL: mse01.zte.com.cn v7M54IHf049222 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 05:04:33 -0000 in parse_ringnuma_config/parse_portnuma_config functions,port_id should less than RTE_MAX_ETHPORTS,but port_id_is_invalid check assumes that port_id may be 255. Signed-off-by: Li Han --- app/test-pmd/parameters.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 2f7f70f..0c97ba4 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -424,7 +424,8 @@ return -1; } port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); RTE_ETH_FOREACH_DEV(pid) printf(", %d", pid); @@ -483,7 +484,8 @@ return -1; } port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); RTE_ETH_FOREACH_DEV(pid) printf(", %d", pid); -- 1.8.3.1