From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6603EA00BE; Tue, 15 Mar 2022 12:23:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03E3840395; Tue, 15 Mar 2022 12:23:04 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id D48924014F for ; Tue, 15 Mar 2022 12:23:02 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7AE405C0080; Tue, 15 Mar 2022 07:23:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 15 Mar 2022 07:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=Xf3S/dLzbg4T3j PempWCMG58GIs0r34VtYqXCMWQyoo=; b=s7icEsrXKfg/7ljUcGw9gof8RJ8EBe mk9e+sAokybK6QxIEXH7EoGsZhjC5YqIgCEiqWetgCL+36mUvB0CxIhvphWLePUU mUaqRoUh41HHlu2kZw3p6co24RICZ5DulmHK4LngSPNCTjkAhndg2lKFO4ipS88a y1RnSuNeKogEEn66QOiorZBzaW4TeKdbcbPYXDqN4uxQdsUjfNlOX88nSJWS8T21 PrseJlpTvAE6O6VzUIW3Bhx80+Duw3bPAI9pzmRkGOgS4sXy2Jvsc9A4/XjTHM2z 6b5ArX6hGs0tWU6jNs7YYLO6b19h9xPOU3cmhO4TEYdem5Xaf/VNgx/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Xf3S/dLzbg4T3jPempWCMG58GIs0r34VtYqXCMWQy oo=; b=EWKZwIKdaCM/8hXYlrWyz1Ax5ikqGt25oC7KJ1YohHW6Pf4kwQCYuGcgO m2Hmk7ONhE6QX1N20paLoeSG/gPDp9TUF7EvzHE+/sZrDLY9+ylelQLWdZB+x98L w6oP/TEcYLN6dNud9179KO6dxg6SDiBauhWoGJT+rtwSLGCxG30jYVB8ZxpzkKAH BcA8zTwgz9KIOM0QH+qQf9c58DpT1RSSMaVcpec4ILLUKCBNYTT1mpAE+HUJ9JXE DhmYEWxoY9j8+nd4xwBJKo3dd9G7+9iTnY6B9toaUaKo282cWXYLAL6Q8jxQXQqM Aw32jRCOOh/Vrzkj9jt30m/pFvX9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeftddgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Mar 2022 07:23:01 -0400 (EDT) From: Thomas Monjalon To: Megha Ajmera Cc: dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, sham.singh.thakur@intel.com, david.marchand@redhat.com Subject: Re: [PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally" Date: Tue, 15 Mar 2022 12:22:59 +0100 Message-ID: <3492155.hdfAi7Kttb@thomas> In-Reply-To: <20220314122725.106088-1-megha.ajmera@intel.com> References: <4dfde108-70ff-d916-4b42-5048d1a82042@redhat.com> <20220314122725.106088-1-megha.ajmera@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/03/2022 13:27, Megha Ajmera: > This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. > > When enabling TC OV unconditionally, it is observed the performance > drops by ~20% hence reverting this commit. > > Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription > unconditionally") > > Signed-off-by: Megha Ajmera Repeating what was suggested yesterday in a private email. Sorry Megha, I don't know why you were not Cc'ed by your Intel colleagues. David and I suggested to drop the code which was enabled by the compilation flag RTE_SCHED_SUBPORT_TC_OV, which was kind of dead code before enabling it unconditionally. This way you maintain the performance of the default compilation, and you can re-introduce the feature, if proven useful, in the next release with a runtime option.