DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment
Date: Thu, 30 Mar 2017 22:20:20 +0200	[thread overview]
Message-ID: <3492683.SxtYo7vtD0@xps13> (raw)
In-Reply-To: <6b4adfde-4e43-07d9-6fcb-43454f1d2d20@intel.com>

2017-02-17 12:29, Ferruh Yigit:
> On 1/18/2017 12:27 PM, Alejandro Lucero wrote:
> > For using a DPDK app when iommu is enabled, it requires to
> > add iommu=pt to the kernel command line. But using igb_uio driver
> > makes DMAR errors because the device has not an IOMMU domain.
> > 
> > Since kernel 3.15, iommu=pt requires to use the internal kernel
> > DMA API for attaching the device to the IOMMU 1:1 mapping, aka
> > si_domain. Previous versions did attach the device to that
> > domain when intel iommu notifier was called.
> > 
> > This is not a problem if the driver does later some call to the
> > DMA API because the mapping can be done then. But DPDK apps do
> > not use that DMA API at all.
> > 
> > Doing this dma map and unmap is harmless even when iommu is not
> > enabled at all.
> > 
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> (I suggest getting this early in 17.05 release, so it can be tested more)

Sorry, I've missed it in early days of 17.05. Let's add it now.
Ferruh, Alejandro, do not hesitate to ping next time.

Applied, thanks

      reply	other threads:[~2017-03-30 20:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 12:27 Alejandro Lucero
2017-02-07 15:59 ` Ferruh Yigit
2017-02-08 11:54   ` Alejandro Lucero
2017-02-10 19:03     ` Ferruh Yigit
2017-02-10 19:06       ` Ferruh Yigit
2017-02-13 13:38         ` Alejandro Lucero
2017-02-13 15:54           ` Ferruh Yigit
2017-02-13 13:31       ` Alejandro Lucero
2017-02-17 12:29 ` Ferruh Yigit
2017-03-30 20:20   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3492683.SxtYo7vtD0@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).