From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37D94A04FD; Wed, 22 Jun 2022 11:32:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C84BC4069F; Wed, 22 Jun 2022 11:32:31 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id DDFD74069C for ; Wed, 22 Jun 2022 11:32:30 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 76B7B32008FD; Wed, 22 Jun 2022 05:32:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 22 Jun 2022 05:32:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655890348; x= 1655976748; bh=9nDiVOZat0e0iC/iqsqMgmU2f/OGD1XdcUskz+SHxzE=; b=c V8BbV93NqQcfFaU7yqL4+YeDOOVBQQwHn++jhRr6zymK1pH1G/+4tlMN5f1In2M9 nxD7utrei9/7dkMpQqwreGvpFw1oen6KaK9OUq0J2imgMT7TDjpG53OYXrHoRZzF FeRgijpmVeslc8sVfKxS4fbbCcu/DqULyY+Z/+fBXHfA/tUeK/tguLev8xQ9S443 EPbk3VcKHzeqK2vujWSnV1M98g/vkgQKmiuvJAaYM/dPiXmM4hSEiQtB6JpJOMXT JMFdVWsae31K7CN3tIyiC7PEp66xFr4a4kSlW+3AUM0+WC1GvxulRpiBXWOW5UD5 cw9SDIs1w6O886bqVhS3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655890348; x= 1655976748; bh=9nDiVOZat0e0iC/iqsqMgmU2f/OGD1XdcUskz+SHxzE=; b=b UwcUuoXLosNAsewWsaLH/lJY3y6D0LdZDV0BX/c6aQOBC/BY3bPwCErE771Ullzu v+aW0doNtgGgH8BUYgXOZRd9NcOZQ7gMOyFexxyoOpBgZBFAMWcsxloeFe+rJBXa 1r8h2iBg6JWTWBHWpkAjAErWEERYJXKqY69BTO7TrmYDdJJA0aYX/gdtwn01doLF XRj6AfjdZwQBiOClEoJcWAu7Nryr+tOXkJy8vKkSVt1Hr+L9BqxAHOREBMuCuviK 8SJekBJChEalvxGvy7rgh4hc+WX64/QpJKGY4vG8KJiYM5jE4wKltSmgrDxnu3Cs mfHDfspslmBNxBKKMwbZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefhedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Jun 2022 05:32:27 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] eal/x86: don't export internal alignment macro Date: Wed, 22 Jun 2022 11:32:26 +0200 Message-ID: <3494576.HovnAMPojK@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8714C@smartserver.smartshare.dk> References: <20220621141325.1955755-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D8714C@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/06/2022 16:28, Morten Br=F8rup: > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Tuesday, 21 June 2022 16.13 > >=20 > > ALIGNMENT_MASK is only used internally. > > Besides it lacks a DPDK-related prefix. > > Hide it from external eyes. > >=20 > > Reported-by: Morten Br=F8rup > > Signed-off-by: David Marchand > > --- > > --- a/lib/eal/x86/include/rte_memcpy.h > > +++ b/lib/eal/x86/include/rte_memcpy.h > > +#undef ALIGNMENT_MASK >=20 > You could consider also giving another name with a lower risk of collisio= n. > However, I think the risk is very low, since it can only collide with oth= er headers being included before this header file, so this suffices. >=20 > Reviewed-by: Morten Br=F8rup =46ixes: f5472703c0bd ("eal: optimize aligned memcpy on x86") Cc: stable@dpdk.org Applied, thanks.