From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id C81662A9 for ; Tue, 4 Nov 2014 09:44:43 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id n3so8712380wiv.0 for ; Tue, 04 Nov 2014 00:54:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=oggvg3Ce+JK82ymzO4/dVkaLNRiPsuJoq34svBiuaSo=; b=eBfi00GCCmU2/gVcMbx/EbNs8RFBSwBCjjOJtS/oCZlpcfCTqrMoVCtUypf4NCufXP HcBez4ln5Mi3l5S2beYMISS2q8radYIH4JcpGogfH/u0+4IbWWXQjxy5CaHoZn6+xjuA y374tWgXlMRPozfjC2j9QZ5Jsc5ZsdBiVId2yt1bqSylnFZkdLA7/dA7GZGYC34ZhF8x H4/niw2TIWb7gDqUbjZ336pV5GF9NE0eW6sBLTLiG+9vAVoI0AtQ5ZvB8Qh2Cb5fLyXC wNBrPXdXeJJu89dUj6XfEozIf9Mrw3yHRDnQ4k6/2cFVfZAvAT9lHDRTdWEP12PNUbYP cAZQ== X-Gm-Message-State: ALoCoQkgQTbiwcSvif11JWwHlgNHSoW02fY+/EIzzNMYh37gQMO26oqtSX4ei7tNolvi9TBF6aO5 X-Received: by 10.194.171.201 with SMTP id aw9mr14015037wjc.67.1415091241513; Tue, 04 Nov 2014 00:54:01 -0800 (PST) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id p3sm24931894wjf.49.2014.11.04.00.54.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2014 00:54:00 -0800 (PST) From: Thomas Monjalon To: "Chen, Jing D" Date: Tue, 04 Nov 2014 09:53:43 +0100 Message-ID: <3494957.2Q8m5MX3oE@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016061A7@shsmsx102.ccr.corp.intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <48821528.yaSnYYWibr@xps13> <4341B239C0EFF9468EE453F9E9F4604D016061A7@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/6] ether: enhancement for VMDQ support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 08:44:43 -0000 2014-11-04 05:50, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-16 18:07, Chen Jing D: > > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > > applicable. */ > > > + uint16_t vmdq_queue_base; > > > + uint16_t vmdq_queue_num; > > > > Please explain what mean the values in vmdq_queue_base and > > vmdq_queue_num. > > I thinks the name is self- explanatory, I also add some comments for them. > As previous max_rx/tx_queues indicates how many queues available, these > 2 variables defines the queue ranges for VM usage. I understand clearly now. > What kind of explanations you needs me to add? You cannot put a doxygen comment which apply to 2 fields. Try do describe precisely the meaning of each field. Example: /**< first queue ID in the range for VMDQ pool */ and /**< size of the queue range for VMDQ pool */ -- Thomas