DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mk: Add DT_SONAME to shared libraries
@ 2015-02-04  8:22 Panu Matilainen
  2015-02-04 11:43 ` Neil Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Panu Matilainen @ 2015-02-04  8:22 UTC (permalink / raw)
  To: dev

This is all-important now that the libraries are versioned:  DT_SONAME
presence instructs the runtime dynamic linker to load the shared object
by the versioned name in DT_SONAME instead of the the unversioned symlink
name used during build.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 mk/rte.lib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index 865a307..0d7482d 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -79,7 +79,7 @@ O_TO_A_DO = @set -e; \
 	$(O_TO_A) && \
 	echo $(O_TO_A_CMD) > $(call exe2cmd,$(@))
 
-O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)
+O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -Wl,-soname,$(LIB) -o $(LIB)
 O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
 O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)","  LD $(@)")
 O_TO_S_DO = @set -e; \
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: Add DT_SONAME to shared libraries
  2015-02-04  8:22 [dpdk-dev] [PATCH] mk: Add DT_SONAME to shared libraries Panu Matilainen
@ 2015-02-04 11:43 ` Neil Horman
  2015-02-04 22:33   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2015-02-04 11:43 UTC (permalink / raw)
  To: Panu Matilainen; +Cc: dev

On Wed, Feb 04, 2015 at 10:22:50AM +0200, Panu Matilainen wrote:
> This is all-important now that the libraries are versioned:  DT_SONAME
> presence instructs the runtime dynamic linker to load the shared object
> by the versioned name in DT_SONAME instead of the the unversioned symlink
> name used during build.
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>  mk/rte.lib.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index 865a307..0d7482d 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -79,7 +79,7 @@ O_TO_A_DO = @set -e; \
>  	$(O_TO_A) && \
>  	echo $(O_TO_A_CMD) > $(call exe2cmd,$(@))
>  
> -O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)
> +O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -Wl,-soname,$(LIB) -o $(LIB)
>  O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
>  O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)","  LD $(@)")
>  O_TO_S_DO = @set -e; \
> -- 
> 2.1.0
> 
> 

Acked-by: Neil Horman <nhorman@tuxdriver.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: Add DT_SONAME to shared libraries
  2015-02-04 11:43 ` Neil Horman
@ 2015-02-04 22:33   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:33 UTC (permalink / raw)
  To: Panu Matilainen; +Cc: dev

2015-02-04 06:43, Neil Horman:
> On Wed, Feb 04, 2015 at 10:22:50AM +0200, Panu Matilainen wrote:
> > This is all-important now that the libraries are versioned:  DT_SONAME
> > presence instructs the runtime dynamic linker to load the shared object
> > by the versioned name in DT_SONAME instead of the the unversioned symlink
> > name used during build.
> > 
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

> > -O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)
> > +O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -Wl,-soname,$(LIB) -o $(LIB)

> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-04 22:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04  8:22 [dpdk-dev] [PATCH] mk: Add DT_SONAME to shared libraries Panu Matilainen
2015-02-04 11:43 ` Neil Horman
2015-02-04 22:33   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).