From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6F40A0560; Tue, 18 Oct 2022 15:44:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8E3040395; Tue, 18 Oct 2022 15:44:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 84BC04021D for ; Tue, 18 Oct 2022 15:44:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666100679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBCZ03/zNbLj1cTJJhOFa+ngNWzpbWOTD2qtxLsV75s=; b=LTWdARixRvp/5HQ5WRgc9kuY2evzk9fQMTWHymevc+bOUCmjuh+mGG0GUcyu6jK2fy6XHh pkJbvsvuU5R3OEUVeEFR9T0CXhMYctlZ0nlXmurxO8X2yLipNuxFRNCm4+vyzAHJaT7aEU /pbW3zcIaKoE3IFWGGZHBphk02S5YDk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-_66VuYO9PUSJ_RgeMqnoRQ-1; Tue, 18 Oct 2022 09:44:35 -0400 X-MC-Unique: _66VuYO9PUSJ_RgeMqnoRQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 573F6833A0E; Tue, 18 Oct 2022 13:44:35 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14614404CD80; Tue, 18 Oct 2022 13:44:33 +0000 (UTC) Message-ID: <349df8f2-45e8-3a46-9327-2212a615a4c7@redhat.com> Date: Tue, 18 Oct 2022 15:44:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v8 07/12] vdpa/ifc: change internal function name To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-8-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1666094871-25721-8-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/22 14:07, Andy Pei wrote: > Change internal function name "find_internal_resource_by_dev" > to "find_internal_resource_by_pci_dev". > > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 9c49f9c..73d04ed 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -121,7 +121,7 @@ struct rte_vdpa_dev_info { > } > > static struct internal_list * > -find_internal_resource_by_dev(struct rte_pci_device *pdev) > +find_internal_resource_by_pci_dev(struct rte_pci_device *pdev) > { > int found = 0; > struct internal_list *list; > @@ -1746,7 +1746,7 @@ struct rte_vdpa_dev_info dev_info[] = { > if (rte_eal_process_type() != RTE_PROC_PRIMARY) > return 0; > > - list = find_internal_resource_by_dev(pci_dev); > + list = find_internal_resource_by_pci_dev(pci_dev); > if (list == NULL) { > DRV_LOG(ERR, "Invalid device: %s", pci_dev->name); > return -1; Reviewed-by: Maxime Coquelin Thanks, Maxime