From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH] doc: announce kvargs API change
Date: Fri, 23 Nov 2018 14:17:25 +0100 [thread overview]
Message-ID: <349f99c8-cfc4-9e98-38dc-fbe06ba26993@redhat.com> (raw)
In-Reply-To: <20181121154545.14261-1-thomas@monjalon.net>
On 11/21/18 4:45 PM, Thomas Monjalon wrote:
> In some usages, kvlist is processed one time in rte_kvargs_process(),
> and it is processed a second time if need to check whether it was matched.
> In order to simplify implementation of kvargs checks, a new callback
> may be used for "no match" cases.
>
> The change of the function prototype would be as below:
>
> int
> rte_kvargs_process(const struct rte_kvargs *kvlist,
> const char *key_match,
> - arg_handler_t handler,
> + arg_handler_t match_handler,
> + arg_handler_t no_match_handler,
> void *opaque_arg)
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 34b28234c..7af65cd4b 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -11,6 +11,10 @@ API and ABI deprecation notices are to be posted here.
> Deprecation Notices
> -------------------
>
> +* kvargs: The function ``rte_kvargs_process`` will get a new parameter
> + for a function pointer called in case of no match of the key.
> + It will ease implementation of default values or check for mandatory keys.
> +
> * eal: both declaring and identifying devices will be streamlined in v18.11.
> New functions will appear to query a specific port from buses, classes of
> device and device drivers. Device declaration will be made coherent with the
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
prev parent reply other threads:[~2018-11-23 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:45 Thomas Monjalon
2018-11-22 10:32 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-11-22 13:22 ` Olivier Matz
2018-11-22 14:02 ` Thomas Monjalon
2018-11-22 17:08 ` Ferruh Yigit
2018-11-23 16:31 ` Jerin Jacob
2018-11-24 17:12 ` Thomas Monjalon
2018-11-23 13:17 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=349f99c8-cfc4-9e98-38dc-fbe06ba26993@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).