From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150048.outbound.protection.outlook.com [40.107.15.48]) by dpdk.org (Postfix) with ESMTP id DF39F3576 for ; Mon, 1 Apr 2019 22:16:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzwzrT32zubcw7OVJyAUPzcKvF+wvUfBNGgwqksc1Yw=; b=nneGeFkUyCtuo+8HfrxS4xWWadkkIidGD0qgzdlzwrL9dOUCWGPMYbBmamrcKsbNuK21LLQY+fKnJExMEpf95lIe88rtWvYhKuA4sJ8mW4WywVVn/pjj+Vxuvjtm2tv+1BcIU3DDfFeqRHSirpILaZuORbq7tPZSCARreN5bc1s= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3043.eurprd08.prod.outlook.com (52.134.94.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Mon, 1 Apr 2019 20:16:01 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe%5]) with mapi id 15.20.1750.017; Mon, 1 Apr 2019 20:16:01 +0000 From: Dharmik Thakkar To: "Wang, Yipeng1" CC: "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2 1/2] hash: add lock free support for extendable bucket Thread-Index: AQHU4070fhVUnVZv90WA5JMA3gBg36YnqHIAgAAgYgA= Date: Mon, 1 Apr 2019 20:16:01 +0000 Message-ID: <34EE3AF0-42A6-4A32-ADA2-14BE021430C5@arm.com> References: <20190320223513.31249-1-dharmik.thakkar@arm.com> <20190325210838.2853-1-dharmik.thakkar@arm.com> <20190325210838.2853-2-dharmik.thakkar@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57b084f2-76fe-4ae7-7acd-08d6b6dedc37 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3043; x-ms-traffictypediagnostic: AM0PR08MB3043: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0994F5E0C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(39860400002)(396003)(366004)(376002)(346002)(189003)(199004)(13464003)(186003)(478600001)(6436002)(6116002)(83716004)(26005)(97736004)(82746002)(6506007)(14444005)(99286004)(6916009)(5660300002)(256004)(54906003)(93886005)(68736007)(8936002)(66066001)(81156014)(71200400001)(81166006)(14454004)(316002)(106356001)(7736002)(4326008)(8676002)(2906002)(305945005)(3846002)(71190400001)(105586002)(86362001)(76176011)(446003)(6246003)(229853002)(36756003)(486006)(25786009)(33656002)(72206003)(11346002)(2616005)(102836004)(6486002)(53936002)(476003)(53546011)(6512007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3043; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: oCXbxqiqOCmOgBhwW/sE5BYnt/418PbLcqM6bS3J0BS6mYrZ+rNfxZZX8kWyWiWuWEJE18l8nQO2IkmrQC3J5XkjN0TrueX91FzzX5MKrMA5xDqXt+sxNbxAAB+lVqmWFgw2LB3EuwLeTwyyoqEDz+mmi3x/OHlT/p6Upj8NBD+Ff4RgdMfalQ3oc75b/m7JUW9xZsm/W98rTxYz+RWVf94R6sYhEsSDr6Sv3o2NVWDn00upo3dsHLfMxuXdW1hd+ShGyBkujQirx5bi40pqpAjFID5aFoSog4x/fu7c9/GTCdEU9SU4S2FpFrHx8hja07g5i3YTAj7oY9ocjIrNYiacK1cHNPsT6qqrIOuzeFM0AabwBhqLk/lqjX0PtYOnHquUaxalrquXmwG0/76LugHjFbiC/Kd20AgYBWaIdhY= Content-Type: text/plain; charset="us-ascii" Content-ID: <2A7342F3E1921443B2AE49C9F7DEF91B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57b084f2-76fe-4ae7-7acd-08d6b6dedc37 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 20:16:01.2211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3043 Subject: Re: [dpdk-dev] [PATCH v2 1/2] hash: add lock free support for extendable bucket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 20:16:03 -0000 +Honnappa Hi Yipeng, Thank you for the review! > On Apr 1, 2019, at 1:20 PM, Wang, Yipeng1 wrote: >=20 >> -----Original Message----- >> From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] >> Sent: Monday, March 25, 2019 2:09 PM >> To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >> ; De Lara Guarch, Pablo ; Mcnamara, John >> ; Kovacevic, Marko >> Cc: dev@dpdk.org; Dharmik Thakkar >> Subject: [PATCH v2 1/2] hash: add lock free support for extendable bucke= t >>=20 >> This patch enables lock-free read-write concurrency support for >> extendable bucket feature. >>=20 >> Suggested-by: Honnappa Nagarahalli >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Ruifeng Wang >> Reviewed-by: Gavin Hu >> Reviewed-by: Honnappa Nagarahalli >> @@ -1072,7 +1082,15 @@ __rte_hash_add_key_with_hash(const struct rte_has= h *h, const void *key, >> bkt_id =3D (uint32_t)((uintptr_t)ext_bkt_id) - 1; >> /* Use the first location of the new bucket */ >> (h->buckets_ext[bkt_id]).sig_current[0] =3D short_sig; >> - (h->buckets_ext[bkt_id]).key_idx[0] =3D new_idx; >> + /* Key can be of arbitrary length, so it is >> + * not possible to store it atomically. >> + * Hence the new key element's memory stores >> + * (key as well as data) should be complete >> + * before it is referenced. >> + */ > [Wang, Yipeng] Minor issue: does this comment need to be fixed too? If so= you could include my ack for next version. Yes, I will fix it in the next version.=20 >=20 > Acked-by: Yipeng Wang >=20 >=20 > Thanks > Yipeng! >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9951FA0679 for ; Mon, 1 Apr 2019 22:16:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DE77378B; Mon, 1 Apr 2019 22:16:04 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150048.outbound.protection.outlook.com [40.107.15.48]) by dpdk.org (Postfix) with ESMTP id DF39F3576 for ; Mon, 1 Apr 2019 22:16:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzwzrT32zubcw7OVJyAUPzcKvF+wvUfBNGgwqksc1Yw=; b=nneGeFkUyCtuo+8HfrxS4xWWadkkIidGD0qgzdlzwrL9dOUCWGPMYbBmamrcKsbNuK21LLQY+fKnJExMEpf95lIe88rtWvYhKuA4sJ8mW4WywVVn/pjj+Vxuvjtm2tv+1BcIU3DDfFeqRHSirpILaZuORbq7tPZSCARreN5bc1s= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3043.eurprd08.prod.outlook.com (52.134.94.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Mon, 1 Apr 2019 20:16:01 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe%5]) with mapi id 15.20.1750.017; Mon, 1 Apr 2019 20:16:01 +0000 From: Dharmik Thakkar To: "Wang, Yipeng1" CC: "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2 1/2] hash: add lock free support for extendable bucket Thread-Index: AQHU4070fhVUnVZv90WA5JMA3gBg36YnqHIAgAAgYgA= Date: Mon, 1 Apr 2019 20:16:01 +0000 Message-ID: <34EE3AF0-42A6-4A32-ADA2-14BE021430C5@arm.com> References: <20190320223513.31249-1-dharmik.thakkar@arm.com> <20190325210838.2853-1-dharmik.thakkar@arm.com> <20190325210838.2853-2-dharmik.thakkar@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57b084f2-76fe-4ae7-7acd-08d6b6dedc37 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3043; x-ms-traffictypediagnostic: AM0PR08MB3043: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0994F5E0C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(39860400002)(396003)(366004)(376002)(346002)(189003)(199004)(13464003)(186003)(478600001)(6436002)(6116002)(83716004)(26005)(97736004)(82746002)(6506007)(14444005)(99286004)(6916009)(5660300002)(256004)(54906003)(93886005)(68736007)(8936002)(66066001)(81156014)(71200400001)(81166006)(14454004)(316002)(106356001)(7736002)(4326008)(8676002)(2906002)(305945005)(3846002)(71190400001)(105586002)(86362001)(76176011)(446003)(6246003)(229853002)(36756003)(486006)(25786009)(33656002)(72206003)(11346002)(2616005)(102836004)(6486002)(53936002)(476003)(53546011)(6512007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3043; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: oCXbxqiqOCmOgBhwW/sE5BYnt/418PbLcqM6bS3J0BS6mYrZ+rNfxZZX8kWyWiWuWEJE18l8nQO2IkmrQC3J5XkjN0TrueX91FzzX5MKrMA5xDqXt+sxNbxAAB+lVqmWFgw2LB3EuwLeTwyyoqEDz+mmi3x/OHlT/p6Upj8NBD+Ff4RgdMfalQ3oc75b/m7JUW9xZsm/W98rTxYz+RWVf94R6sYhEsSDr6Sv3o2NVWDn00upo3dsHLfMxuXdW1hd+ShGyBkujQirx5bi40pqpAjFID5aFoSog4x/fu7c9/GTCdEU9SU4S2FpFrHx8hja07g5i3YTAj7oY9ocjIrNYiacK1cHNPsT6qqrIOuzeFM0AabwBhqLk/lqjX0PtYOnHquUaxalrquXmwG0/76LugHjFbiC/Kd20AgYBWaIdhY= Content-Type: text/plain; charset="UTF-8" Content-ID: <2A7342F3E1921443B2AE49C9F7DEF91B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57b084f2-76fe-4ae7-7acd-08d6b6dedc37 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 20:16:01.2211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3043 Subject: Re: [dpdk-dev] [PATCH v2 1/2] hash: add lock free support for extendable bucket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401201601.ifwpCvctSFGQON8SBplNgv9LPApGli8PH4widafNJso@z> +Honnappa Hi Yipeng, Thank you for the review! > On Apr 1, 2019, at 1:20 PM, Wang, Yipeng1 wrote: >=20 >> -----Original Message----- >> From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] >> Sent: Monday, March 25, 2019 2:09 PM >> To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >> ; De Lara Guarch, Pablo ; Mcnamara, John >> ; Kovacevic, Marko >> Cc: dev@dpdk.org; Dharmik Thakkar >> Subject: [PATCH v2 1/2] hash: add lock free support for extendable bucke= t >>=20 >> This patch enables lock-free read-write concurrency support for >> extendable bucket feature. >>=20 >> Suggested-by: Honnappa Nagarahalli >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Ruifeng Wang >> Reviewed-by: Gavin Hu >> Reviewed-by: Honnappa Nagarahalli >> @@ -1072,7 +1082,15 @@ __rte_hash_add_key_with_hash(const struct rte_has= h *h, const void *key, >> bkt_id =3D (uint32_t)((uintptr_t)ext_bkt_id) - 1; >> /* Use the first location of the new bucket */ >> (h->buckets_ext[bkt_id]).sig_current[0] =3D short_sig; >> - (h->buckets_ext[bkt_id]).key_idx[0] =3D new_idx; >> + /* Key can be of arbitrary length, so it is >> + * not possible to store it atomically. >> + * Hence the new key element's memory stores >> + * (key as well as data) should be complete >> + * before it is referenced. >> + */ > [Wang, Yipeng] Minor issue: does this comment need to be fixed too? If so= you could include my ack for next version. Yes, I will fix it in the next version.=20 >=20 > Acked-by: Yipeng Wang >=20 >=20 > Thanks > Yipeng! >=20