From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id 298774CB3 for ; Tue, 13 Mar 2018 07:59:28 +0100 (CET) Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id A0A436E7BEB87 for ; Tue, 13 Mar 2018 14:59:23 +0800 (CST) Received: from DGGEMM513-MBS.china.huawei.com ([169.254.4.39]) by DGGEMM403-HUB.china.huawei.com ([10.3.20.211]) with mapi id 14.03.0361.001; Tue, 13 Mar 2018 14:59:19 +0800 From: wangyunjian To: "dev@dpdk.org" CC: caihe Thread-Topic: [dpdk-dev] net/i40e: fix intr callback unregister by adding retry Thread-Index: AQHTuDwnFhddlIukwUWwyr/L22llvaPNv8BA Date: Tue, 13 Mar 2018 06:59:18 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60C747C37@dggemm513-mbs.china.huawei.com> References: <1520664643-13808-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1520664643-13808-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.24.66] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] net/i40e: fix intr callback unregister by adding retry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 06:59:28 -0000 > -----Original Message----- > From: wangyunjian > Sent: Saturday, March 10, 2018 2:51 PM > To: dev@dpdk.org > Cc: caihe ; wangyunjian > Subject: [dpdk-dev] net/i40e: fix intr callback unregister by adding retr= y >=20 > From: Yunjian Wang >=20 > The nic's interrupt source has some active callbacks, when the port hotpl= ug. > Add a retry to give more port's a chance to uninit before returning an er= ror. >=20 > Fixes: d42aaf30008b ("i40e: support port hotplug") >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/i40e/i40e_ethdev.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 508b417..a73d4df 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1533,6 +1533,7 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > struct rte_flow *p_flow; > int ret; > uint8_t aq_fail =3D 0; > + int retries =3D 0; >=20 > PMD_INIT_FUNC_TRACE(); >=20 > @@ -1575,8 +1576,19 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > rte_intr_disable(intr_handle); >=20 > /* register callback func to eal lib */ > - rte_intr_callback_unregister(intr_handle, > - i40e_dev_interrupt_handler, dev); > + do { > + ret =3D rte_intr_callback_unregister(intr_handle, > + i40e_dev_interrupt_handler, dev); > + if (!ret) { This check is wrong. I will send the v2 later. > + break; > + } else if (ret !=3D -EAGAIN) { > + PMD_INIT_LOG(ERR, > + "intr callback unregister failed: %d", > + ret); > + return ret; > + } > + i40e_msec_delay(100); > + } while (retries++ < 5); >=20 > i40e_rm_ethtype_filter_list(pf); > i40e_rm_tunnel_filter_list(pf); > -- > 1.8.3.1 >=20