From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id 9DB7B4CA1 for ; Tue, 20 Mar 2018 03:57:18 +0100 (CET) Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 0AA0CA98D50EF for ; Tue, 20 Mar 2018 10:57:13 +0800 (CST) Received: from DGGEMM513-MBS.china.huawei.com ([169.254.4.39]) by DGGEMM406-HUB.china.huawei.com ([10.3.20.214]) with mapi id 14.03.0361.001; Tue, 20 Mar 2018 10:57:03 +0800 From: wangyunjian To: "Zhang, Qi Z" , "Rybalchenko, Kirill" , "dev@dpdk.org" CC: caihe Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry Thread-Index: AQHTu5oxa/JsiKQESEGL9iOPc16ACaPYX6SQ Date: Tue, 20 Mar 2018 02:57:03 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60C751059@dggemm513-mbs.china.huawei.com> References: <1521028922-12664-1-git-send-email-wangyunjian@huawei.com> <696B43C21188DF4F9C9091AAE4789B824E2D6370@IRSMSX108.ger.corp.intel.com> <039ED4275CED7440929022BC67E706115316DCBE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115316DCBE@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.24.66] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 02:57:19 -0000 Is it better to fix this way? Or other ideas? - /* register callback func to eal lib */ - rte_intr_callback_unregister(intr_handle, - i40e_dev_interrupt_handler, dev); - + /* unregister callback func to eal lib */ + while ((ret =3D rte_intr_callback_unregister(intr_handle, + i40e_dev_interrupt_handler, dev)) =3D=3D -EAGAIN) + ; + if (ret < 0) + PMD_INIT_LOG(ERR, + "cannot unregister interrupt handler %d", + ret); > -----Original Message----- > From: Zhang, Qi Z [mailto:qi.z.zhang@intel.com] > Sent: Wednesday, March 14, 2018 9:42 PM > To: Rybalchenko, Kirill ; wangyunjian > ; dev@dpdk.org > Cc: caihe > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister= by > adding retry >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rybalchenko, > > Kirill > > Sent: Wednesday, March 14, 2018 8:08 PM > > To: wangyunjian ; dev@dpdk.org > > Cc: caihe@huawei.com > > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback > > unregister by adding retry > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of wangyunjian > > > Sent: Wednesday 14 March 2018 12:02 > > > To: dev@dpdk.org > > > Cc: caihe@huawei.com; Yunjian Wang > > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback > > > unregister by adding retry > > > > > > From: Yunjian Wang > > > > > > The nic's interrupt source has some active callbacks, when the port > > hotplug. > > > Add a retry to give more port's a chance to uninit before returning a= n > error. > > > > > > Fixes: d42aaf30008b ("i40e: support port hotplug") > > > > > > Signed-off-by: Yunjian Wang > > > --- > > > v2: > > > * Fix return value check > > > --- > > > v3: > > > * Fix comment suggested by Kirill Rybalchenko > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 18 +++++++++++++++--- > > > 1 file changed, 15 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > b/drivers/net/i40e/i40e_ethdev.c index 508b417..6bb31f6 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -1533,6 +1533,7 @@ void i40e_flex_payload_reg_set_default(struct > > > i40e_hw *hw) > > > struct rte_flow *p_flow; > > > int ret; > > > uint8_t aq_fail =3D 0; > > > + int retries =3D 0; > > > > > > PMD_INIT_FUNC_TRACE(); > > > > > > @@ -1574,9 +1575,20 @@ void i40e_flex_payload_reg_set_default(struct > > > i40e_hw *hw) > > > /* disable uio intr before callback unregister */ > > > rte_intr_disable(intr_handle); > > > > > > - /* register callback func to eal lib */ > > > - rte_intr_callback_unregister(intr_handle, > > > - i40e_dev_interrupt_handler, dev); > > > + /* unregister callback func to eal lib */ > > > + do { > > > + ret =3D rte_intr_callback_unregister(intr_handle, > > > + i40e_dev_interrupt_handler, dev); > > > + if (ret >=3D 0) { > > > + break; > > > + } else if (ret !=3D -EAGAIN) { > > > + PMD_INIT_LOG(ERR, > > > + "intr callback unregister failed: %d", > > > + ret); > > > + return ret; > > > + } > > > + i40e_msec_delay(100); > > > + } while (retries++ < 5); > > > > > > i40e_rm_ethtype_filter_list(pf); > > > i40e_rm_tunnel_filter_list(pf); > > > -- > > > 1.8.3.1 > > > > > > > Reviewed-by: Kirill Rybalchenko > > > Acked-by: Qi Zhang