From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B9BCA04B1; Fri, 28 Aug 2020 14:52:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B50441C1AB; Fri, 28 Aug 2020 14:52:06 +0200 (CEST) Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by dpdk.org (Postfix) with ESMTP id 6BE521C1AA; Fri, 28 Aug 2020 14:52:05 +0200 (CEST) Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 933E16D9ED535C67AC8D; Fri, 28 Aug 2020 20:52:02 +0800 (CST) Received: from DGGEMM513-MBX.china.huawei.com ([169.254.1.81]) by DGGEMM404-HUB.china.huawei.com ([10.3.20.212]) with mapi id 14.03.0487.000; Fri, 28 Aug 2020 20:51:52 +0800 From: wangyunjian To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "keith.wiles@intel.com" , "ophirmu@mellanox.com" , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when closing Thread-Index: AQHWZZzOozuoX/cl2U+8EaesNm5Ws6kpDJsAgAIHZID//4M7AIAjDbBA Date: Fri, 28 Aug 2020 12:51:51 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60DA0D229@dggemm513-mbx.china.huawei.com> References: <40a0e68ed41b05fba8cbe5f34e369a59a1c0c09c.1596022448.git.wangyunjian@huawei.com> <4268011.XMymgrSB0u@thomas> <34EFBCA9F01B0748BEB6B629CE643AE60D11127C@DGGEMM533-MBX.china.huawei.com> <3793874.FWKru8qnbX@thomas> In-Reply-To: <3793874.FWKru8qnbX@thomas> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.185.168] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: free mempool when closing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, August 6, 2020 9:20 PM > To: wangyunjian > Cc: dev@dpdk.org; stable@dpdk.org; keith.wiles@intel.com; > ophirmu@mellanox.com; Lilijun (Jerry) ; xudingk= e > ; stable@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when > closing >=20 > 06/08/2020 14:47, wangyunjian: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 29/07/2020 13:35, wangyunjian: > > > > From: Yunjian Wang > > > > > > > > When setup tx queues, we will create a mempool for the 'gso_ctx'. > > > > The mempool is not freed when closing tap device. If free the tap > > > > device and create it with different name, it will create a new > > > > mempool. This maybe cause an OOM. > > > > > > While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE > > > behaviour in tap. Thanks > > > > > > > I read the codes about tap device. Currently, the tap pmd doesn't use > > RTE_ETH_DEV_CLOSE_REMOVE flag. >=20 > I know. That's why I suggest to switch to RTE_ETH_DEV_CLOSE_REMOVE. > Please see this deprecation notice: > http://git.dpdk.org/dpdk/commit/?id=3D7efbaa7b4e423 OK, I have sent a patch to add this feature for tap device. https://patchwork.dpdk.org/patch/76137/ Thanks, Yunjian >=20