From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 24C51A04E7;
	Mon,  2 Nov 2020 03:15:19 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D3923592B;
	Mon,  2 Nov 2020 03:15:17 +0100 (CET)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by dpdk.org (Postfix) with ESMTP id 657A25916;
 Mon,  2 Nov 2020 03:15:15 +0100 (CET)
Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.56])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4CPc2360V7z13PDG;
 Mon,  2 Nov 2020 10:15:07 +0800 (CST)
Received: from DGGEMM513-MBX.china.huawei.com ([169.254.1.123]) by
 DGGEMM406-HUB.china.huawei.com ([10.3.20.214]) with mapi id 14.03.0487.000;
 Mon, 2 Nov 2020 10:15:03 +0800
From: wangyunjian <wangyunjian@huawei.com>
To: Harman Kalra <hkalra@marvell.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, "ferruh.yigit@intel.com"
 <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Lilijun
 (Jerry)" <jerry.lilijun@huawei.com>, xudingke <xudingke@huawei.com>,
 "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set
 error for rte_epoll_event
Thread-Index: AQHWWlJiiz2rd9JhOEuRRtYaP5NCAalKd5rwgCW2oBCABC4lgIAAn2iwgD/LEQA=
Date: Mon, 2 Nov 2020 02:15:01 +0000
Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60DAEBC3A@dggemm513-mbx.china.huawei.com>
References: <2dc88362a7dc347547eb24e5d0570db11a59598e.1594780487.git.wangyunjian@huawei.com>
 <34EFBCA9F01B0748BEB6B629CE643AE60DA5CEA2@dggemm513-mbx.china.huawei.com>
 <20200922103141.GA54896@outlook.office365.com> 
Accept-Language: en-US
Content-Language: zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.174.187.156]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error
 for rte_epoll_event
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: wangyunjian
> Sent: Tuesday, September 22, 2020 8:06 PM
> To: 'Harman Kalra' <hkalra@marvell.com>
> Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com;
> Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry)
> <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>;
> stable@dpdk.org
> Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set er=
ror for
> rte_epoll_event
>=20
> > -----Original Message-----
> > From: Harman Kalra [mailto:hkalra@marvell.com]
> > Sent: Tuesday, September 22, 2020 6:32 PM
> > To: wangyunjian <wangyunjian@huawei.com>
> > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com;
> > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry)
> > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>;
> > stable@dpdk.org
> > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set
> > error for rte_epoll_event
> >
> > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote:
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > --
> > > Friendly ping.
> >
> > Hi Wang,
> >
> >    I am sorry for the delay in review, I will surely complete the revie=
w
> >    by end of this week.
> >    Can you please elaborate on the specific case/scenario which caused
> >    failure i.e. which lead you to this change.
>=20
> EPOLLERR event will be triggered when an exception occurs. This event wil=
l be
> set in 'evs.events', we should use 'evs.events' instead of 'rev->epdata.e=
vent' to
> assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost.
>=20
> Thanks,
> Yunjian

Hi Harman,

Is there any ideas on this issue?

>=20
> >
> > Thanks
> > Harman
> >
> > >
> > > > -----Original Message-----
> > > > From: wangyunjian
> > > > Sent: Wednesday, August 26, 2020 6:56 PM
> > > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com
> > > > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monj=
alon'
> > > > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>;
> > > > xudingke <xudingke@huawei.com>; stable@dpdk.org
> > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error
> > > > for rte_epoll_event
> > > >
> > > > Ping for review, please.
> > > >
> > > > > -----Original Message-----
> > > > > From: wangyunjian
> > > > > Sent: Wednesday, July 15, 2020 10:40 AM
> > > > > To: dev@dpdk.org; hkalra@marvell.com
> > > > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke
> > > > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>;
> > > > > stable@dpdk.org
> > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error
> > > > > for rte_epoll_event
> > > > >
> > > > > From: Yunjian Wang <wangyunjian@huawei.com>
> > > > >
> > > > > The "rev->epdata.event" assigned to "events.epdata.event"
> > > > > directly, which was wrong in case of epoll events. It should be
> > > > > set to the
> > "evs.events".
> > > > >
> > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers")
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > > > > ---
> > > > >  lib/librte_eal/linux/eal_interrupts.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c
> > > > > b/lib/librte_eal/linux/eal_interrupts.c
> > > > > index 13db5c4e8..8a3c95cec 100644
> > > > > --- a/lib/librte_eal/linux/eal_interrupts.c
> > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c
> > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event
> > > > > *evs, unsigned int n,
> > > > >  		events[count].status        =3D RTE_EPOLL_VALID;
> > > > >  		events[count].fd            =3D rev->fd;
> > > > >  		events[count].epfd          =3D rev->epfd;
> > > > > -		events[count].epdata.event  =3D rev->epdata.event;
> > > > > +		events[count].epdata.event  =3D evs[i].events;
> > > > >  		events[count].epdata.data   =3D rev->epdata.data;
> > > > >  		if (rev->epdata.cb_fun)
> > > > >  			rev->epdata.cb_fun(rev->fd,
> > > > > --
> > > > > 2.23.0
> > > > >
> > >