From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 1B5295699 for ; Wed, 27 Feb 2019 13:15:53 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id e74so5562304wmg.3 for ; Wed, 27 Feb 2019 04:15:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=9D0R81q+9bAo4COMviFUX15kNxv+DorXVAmyELxd1Q8=; b=qZDKfChdU7KVAzjCUc46Zlgx5Ln/AeXSfEa/Tul3t4ZDa9KF7y1hZizwjg7HWax7qE 7oMYDPSpvOjyyhwzjM23RqsmL2yr4MCjqA0zGMgaevC1jO5aTRZg+ZdBhnakdIWf7Mz9 VQiM3ZffbrmectCzaBFlPQNF1Lf5fu1u411oWdyUCevgTS2t5HKXpW8nHAyWSn7dsXlu nmbbSILa8blLPzrTx4CxWVUARVESVsW0WgsqPHgdQByq7vJifqxG+MjwK2PregNniIkh l+p5i5YQmKn43MUv2NC5l/JKEtRjL8kFGW9vVFm0tFYHP1dgjtTd6ssFi5wG/Slsyx32 ScAw== X-Gm-Message-State: APjAAAV+CNptyjiQk224pH1IrHWNLICOk5h9HOJvL+EyYtj1/4oEWszD pcHuseHJ4idZbqqD2UvIy29kvKlMWbk= X-Google-Smtp-Source: AHgI3IYmeN3HDxAecb5+U3vJsTaUvQVIQhzYJ3GjeYhizDwkyKZty/6JxbtomIPLiUjgNafGbcAYPA== X-Received: by 2002:a7b:c112:: with SMTP id w18mr2160686wmi.28.1551269752298; Wed, 27 Feb 2019 04:15:52 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id p16sm33763564wro.25.2019.02.27.04.15.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 04:15:50 -0800 (PST) Message-ID: <34a4bbb558f997f406f342edb2e6a4134f75b403.camel@debian.org> From: Luca Boccassi To: dev@dpdk.org Date: Wed, 27 Feb 2019 12:15:50 +0000 In-Reply-To: <20190107141130.24360-1-bluca@debian.org> References: <20181224125627.25690-1-bluca@debian.org> <20190107141130.24360-1-bluca@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 12:15:53 -0000 On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote: > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. >=20 > Force the default flags if the user explicitly sets machine=3Ddefault > at configuration time. >=20 > Fixes: b1d48c41189a ("build: support ARM with meson") > Cc: stable@dpdk.org >=20 > Signed-off-by: Luca Boccassi > Acked-by: Bruce Richardson > --- > v2: fix typo in commit message, remove variable used only once > v3: put back temporary variable, as "machine" gets overwritten > by the function and loses the original value before we need > it. >=20 > config/arm/meson.build | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build > index dae55d6b2..614139534 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -6,6 +6,7 @@ > march_opt =3D '-march=3D@0@'.format(machine) > =20 > arm_force_native_march =3D false > +arm_force_default_march =3D (machine =3D=3D 'default') > =20 > machine_args_generic =3D [ > ['default', ['-march=3Darmv8-a+crc+crypto']], > @@ -105,7 +106,11 @@ else > cmd_generic =3D ['generic', '', '', 'default', ''] > cmd_output =3D cmd_generic # Set generic by default > machine_args =3D [] # Clear previous machine args > - if not meson.is_cross_build() > + if arm_force_default_march and not meson.is_cross_build() > + machine =3D impl_generic > + cmd_output =3D cmd_generic > + impl_pn =3D 'default' > + elif not meson.is_cross_build() > # The script returns ['Implementer', 'Variant', > 'Architecture', > # 'Primary Part number', 'Revision'] > detect_vendor =3D find_program(join_paths( Ping - anything else I can do for this patch? It's necessary for distro native builds, at least in Debian/Ubuntu. Thanks! --=20 Kind regards, Luca Boccassi