From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 870FCA0350; Mon, 22 Jun 2020 10:06:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 252D41D54E; Mon, 22 Jun 2020 10:06:16 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 536731C1C7 for ; Mon, 22 Jun 2020 10:06:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592813173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6bBCsd4RdwklEDtj1HDPcfE9jxeg0DoNAnpxGaOZ1oI=; b=GTwnIRUMFxICmSwHxUUDMRxNDuxwSI5pFHBkFAMTcjRlHDI6PqefU/u8WRZq5/RSCTH5y6 ss/GgtK3E0MKMAa4afxcvsYM+3cOeJJAA0rpHbZPAurh/bccJTD2Ew6r4ySpVKD8HTYxQj jRMZSpv90V4BXWQkpkMzFOdTGZjJe5Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-ede0sevQNSylkinb8AMLjA-1; Mon, 22 Jun 2020 04:06:11 -0400 X-MC-Unique: ede0sevQNSylkinb8AMLjA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCC9E18A8220; Mon, 22 Jun 2020 08:06:10 +0000 (UTC) Received: from [10.36.110.7] (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86DD619D81; Mon, 22 Jun 2020 08:06:09 +0000 (UTC) To: Matan Azrad , Xiao Wang Cc: "dev@dpdk.org" References: <1592497686-433697-1-git-send-email-matan@mellanox.com> <1592497686-433697-2-git-send-email-matan@mellanox.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <34a86ca4-af6e-92c0-2ece-cec130cb7f5f@redhat.com> Date: Mon, 22 Jun 2020 10:06:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/21/20 8:26 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> On 6/19/20 3:28 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: >>>> On 6/18/20 6:28 PM, Matan Azrad wrote: >>>>> As an arrangement to per queue operations in the vDPA device it is >>>>> needed to change the next experimental API: >>>>> >>>>> The API ``rte_vhost_host_notifier_ctrl`` was changed to be per queue >>>>> instead of per device. >>>>> >>>>> A `qid` parameter was added to the API arguments list. >>>>> >>>>> Setting the parameter to the value VHOST_QUEUE_ALL will configure >>>>> the host notifier to all the device queues as done before this patch. >>>>> >>>>> Signed-off-by: Matan Azrad >>>>> --- >>>>> doc/guides/rel_notes/release_20_08.rst | 2 ++ >>>>> drivers/vdpa/ifc/ifcvf_vdpa.c | 6 +++--- >>>>> drivers/vdpa/mlx5/mlx5_vdpa.c | 5 +++-- >>>>> lib/librte_vhost/rte_vdpa.h | 8 ++++++-- >>>>> lib/librte_vhost/rte_vhost.h | 2 ++ >>>>> lib/librte_vhost/vhost.h | 3 --- >>>>> lib/librte_vhost/vhost_user.c | 18 ++++++++++++++---- >>>>> 7 files changed, 30 insertions(+), 14 deletions(-) >>>>> >>>>> diff --git a/doc/guides/rel_notes/release_20_08.rst >>>>> b/doc/guides/rel_notes/release_20_08.rst >>>>> index ba16d3b..9732959 100644 >>>>> --- a/doc/guides/rel_notes/release_20_08.rst >>>>> +++ b/doc/guides/rel_notes/release_20_08.rst >>>>> @@ -111,6 +111,8 @@ API Changes >>>>> Also, make sure to start the actual text at the margin. >>>>> >>>> >> ========================================================= >>>>> >>>>> +* vhost: The API of ``rte_vhost_host_notifier_ctrl`` was changed to >>>>> +be per >>>>> + queue and not per device, a qid parameter was added to the >>>>> +arguments >>>> list. >>>>> >>>>> ABI Changes >>>>> ----------- >>>>> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c >>>>> b/drivers/vdpa/ifc/ifcvf_vdpa.c index ec97178..336837a 100644 >>>>> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c >>>>> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c >>>>> @@ -839,7 +839,7 @@ struct internal_list { >>>>> vdpa_ifcvf_stop(internal); >>>>> vdpa_disable_vfio_intr(internal); >>>>> >>>>> - ret = rte_vhost_host_notifier_ctrl(vid, false); >>>>> + ret = rte_vhost_host_notifier_ctrl(vid, VHOST_QUEUE_ALL, false); >>>>> if (ret && ret != -ENOTSUP) >>>>> goto error; >>>>> >>>>> @@ -858,7 +858,7 @@ struct internal_list { >>>>> if (ret) >>>>> goto stop_vf; >>>>> >>>>> - rte_vhost_host_notifier_ctrl(vid, true); >>>>> + rte_vhost_host_notifier_ctrl(vid, VHOST_QUEUE_ALL, true); >>>>> >>>>> internal->sw_fallback_running = true; >>>>> >>>>> @@ -893,7 +893,7 @@ struct internal_list { >>>>> rte_atomic32_set(&internal->dev_attached, 1); >>>>> update_datapath(internal); >>>>> >>>>> - if (rte_vhost_host_notifier_ctrl(vid, true) != 0) >>>>> + if (rte_vhost_host_notifier_ctrl(vid, VHOST_QUEUE_ALL, true) != 0) >>>>> DRV_LOG(NOTICE, "vDPA (%d): software relay is used.", did); >>>>> >>>>> return 0; >>>>> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c >>>>> b/drivers/vdpa/mlx5/mlx5_vdpa.c index 9e758b6..8ea1300 100644 >>>>> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c >>>>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c >>>>> @@ -147,7 +147,8 @@ >>>>> int ret; >>>>> >>>>> if (priv->direct_notifier) { >>>>> - ret = rte_vhost_host_notifier_ctrl(priv->vid, false); >>>>> + ret = rte_vhost_host_notifier_ctrl(priv->vid, >>>> VHOST_QUEUE_ALL, >>>>> + false); >>>>> if (ret != 0) { >>>>> DRV_LOG(INFO, "Direct HW notifier FD cannot be " >>>>> "destroyed for device %d: %d.", priv->vid, >>>> ret); @@ -155,7 +156,7 >>>>> @@ >>>>> } >>>>> priv->direct_notifier = 0; >>>>> } >>>>> - ret = rte_vhost_host_notifier_ctrl(priv->vid, true); >>>>> + ret = rte_vhost_host_notifier_ctrl(priv->vid, VHOST_QUEUE_ALL, >>>>> +true); >>>>> if (ret != 0) >>>>> DRV_LOG(INFO, "Direct HW notifier FD cannot be configured >>>> for" >>>>> " device %d: %d.", priv->vid, ret); diff --git >>>>> a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h index >>>>> ecb3d91..2db536c 100644 >>>>> --- a/lib/librte_vhost/rte_vdpa.h >>>>> +++ b/lib/librte_vhost/rte_vdpa.h >>>>> @@ -202,22 +202,26 @@ struct rte_vdpa_device * int >>>>> rte_vdpa_get_device_num(void); >>>>> >>>>> +#define VHOST_QUEUE_ALL VHOST_MAX_VRING >>>>> + >>>>> /** >>>>> * @warning >>>>> * @b EXPERIMENTAL: this API may change without prior notice >>>>> * >>>>> - * Enable/Disable host notifier mapping for a vdpa port. >>>>> + * Enable/Disable host notifier mapping for a vdpa queue. >>>>> * >>>>> * @param vid >>>>> * vhost device id >>>>> * @param enable >>>>> * true for host notifier map, false for host notifier unmap >>>>> + * @param qid >>>>> + * vhost queue id, VHOST_QUEUE_ALL to configure all the device >>>>> + queues >>>> I would prefer two APIs that passing a special ID that means all queues: >>>> >>>> rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable); >>>> rte_vhost_host_notifier_ctrl_all(int vid, bool enable); >>>> >>>> I think it is clearer for the user of the API. >>>> Or if you think an extra API is overkill, just let the driver loop on >>>> all the queues. >>> >>> We have a lot of options here with pros and cons. >>> I took the rte_eth_dev_callback_register style. >> >> Ok, I didn't looked at this code. >> >>> It is less intrusive with minimum code change. >>> >>> I'm not sure what is the clearest option but the current suggestion is >>> well defined and allows to configure all the queues too. >>> >>> Let me know what you prefer.... >> >> I personally don't like the style, but I can live with it if you prefer doing it like >> that. >> >> If you do it that way, you will have to rename VHOST_QUEUE_ALL to >> RTE_VHOST_QUEUE_ALL, VHOST_MAX_VRING to RTE_VHOST_MAX_VRING >> and VHOST_MAX_QUEUE_PAIRS to RTE_VHOST_MAX_QUEUE_PAIRS as it >> will become part of the ABI. >> >> Not that it also means that we won't be able to increase the maximum >> number of rings without breaking the ABI. > > What's about defining RTE_VHOST_QUEUE_ALL as UINT16_MAX? I am not fan, but it is better than basing it on VHOST_MAX_QUEUE_PAIRS. >>>>> * @return >>>>> * 0 on success, -1 on failure >>>>> */ >>>>> __rte_experimental >>>>> int >>>>> -rte_vhost_host_notifier_ctrl(int vid, bool enable); >>>>> +rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable); >>>>> >>>>> /** >>> >