From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38CA9A055F; Thu, 20 Oct 2022 13:55:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DB5342D63; Thu, 20 Oct 2022 13:55:51 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) by mails.dpdk.org (Postfix) with ESMTP id 534AD42D53 for ; Thu, 20 Oct 2022 13:55:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8yISHwMpyp8vaFFr5fDvayjfeh9t1klpyGxOt/zJ2Q3WyRe5ZZ1fj49BOVon+GIdnwIKnEGuv3oZ8jwQiHMgU1oQVmoP9ATkk/FMjP+s8v2uCg/z9/DaZB+pkkR+VUw+1Gvv9Au3j96Dly7t4hkrYmfIHiOVbx8RfaaufQw6aTvXOnNtWkJYOAu5UIs6VtaEVAnhEsAIP6wIo7J7I1xnxYE5cprcrOHHBe5W/KPhX4kbknDWlqE7iDUNA3FjUI9yitHk/6OfLX5IqMBVHeGwnCaazmYBBMzbFz1KMdFF0s40Sz5+4FUcgWK+dmg2mVxg4rEqVzKxJ2oDEh6gTivSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KBTG1u5Cxgm0ETujvCl7rLe5inps0hcXgUWWoW3hFSE=; b=KDBXl5LZKNs0tDHp+xma0VuUpp4zqGFxa/Xh1KRNpxZXJp31V5SwQ6eDvZKCZkLUAurZMVvUmMI4bjrvlzfhsJVvAQGGBpJK5JwyKnXOh4slHQC3kByVC7XanKzqml7ydaa9hrWBgPSsU6cACqmFkAMmfWU09NNHVpf3F8DE7G8Xkeye0+PybVL27Wnzi+vXexsfNZ+4HAQCo/2fVXLFRA8MBVbFVDZgd/+iJOlGTg57HBoWTeO6FLaPy71saPPMJK3FJ8cBVDcc6CIkMsGPY9vDlv3GqRu4QEi4Q9sUVnMM9qm4Kc5dYii/sEH4EdwvK/EVX558QkGS4EuKAKymgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KBTG1u5Cxgm0ETujvCl7rLe5inps0hcXgUWWoW3hFSE=; b=Eteii0X6pyMDUgUm8g3qXDDcpFyVSl8t0IEXkQ5BeLqH+Hr33oWLfQo8+U2Qez0gbLL0bchddBTjJotQ2nNIsWdJesPkiIAmw1jDDEJ6Rr5GwPk4yIVOAEngjcqI+60laGku9pMh41C1V62BM08rrJ+DtQzacltS4R13bT1Ntmw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MN0PR12MB6176.namprd12.prod.outlook.com (2603:10b6:208:3c3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct 2022 11:55:45 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 11:55:45 +0000 Message-ID: <34b2d45b-5f49-8c4a-67d2-d75726af41e8@amd.com> Date: Thu, 20 Oct 2022 12:55:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 13/25] net/nfp: support SRC MAC flow action Content-Language: en-US To: Chaoyong He , Andrew Rybchenko , Ori Kam Cc: oss-drivers , Niklas Soderlund , "dev@dpdk.org" References: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> <1666232391-29152-14-git-send-email-chaoyong.he@corigine.com> <19e889dc-701b-c3fc-3194-a792eccd4f7c@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0487.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::6) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|MN0PR12MB6176:EE_ X-MS-Office365-Filtering-Correlation-Id: f9d7b942-22e5-4a9c-db94-08dab292052c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1FMbv10hIjNi58EkOIG9xoHxjCSIzZTllvhK4mmRPilG15RbsMxgcbTvudCJDye17ZODEogzGTjX3bTYZ4KBdBrm3JSZXpfVmWDfmJB6hmlPfYfin67BGIih5bmp8ju1mXl2e6HT0qeFkUhqYjdjzpg3oskFkAuWV6NRMW+qt0RD0bSN0vCRBHSHn5UoUhSwnbn59uX9m4eFu0vQKMcknnRpFWcpasDMDWRCincu2Mg1bNY1k/G32dpU6hqd6nncNaWDMdBylBU3a5HgAebCzmrv7ZzJCv1zlz+ooGkFFT/u3SLjA3H2/TagplWDcW1PuuJD/mjxJhX+MVD42QJJ0Co/XvPjyTf1dS0Z0QLzpy/xAVtbLZg0MykhlJqxHh0cjrRMZ7S8K4pJhGQEuRqGiTVm4/amqejZeeUy33Tb9UJVRA7RO6mvdV+UmGl6qg0F3/jr1ZCZtkydf0shZBihFZ/FGMsQLLHekxVV5C7cvtgVXkrYKUWx4AjekvOJ5t8WWrum+eZjO7RqJPaUzHA1NeruAikXY1hN2EU/IlVn+FOSlucEXM5e7DUMBNqgW9+UMI7juuS/NcUkIxeLn5UEv2LzOUpbAr7RdUaFZqrSPWGqOdpqgTTK6CBC4qlQ/pKTT4UD3iqsscwS/xFYra30BNbDd5e2R+zjGN14u7kmwO2teSC1WY5jabVgVDarcs5QC8wOTjSui5KjKCE9LnT+CzhnDEmJ9R5lP+/XQt/2M/LHnkjCnzmZmQ7zebaA/CxijkAZbAsi15u3ru+QkUIYOJzbpyQDGkSvvlHp2H27tRs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(451199015)(186003)(6666004)(6512007)(2616005)(53546011)(2906002)(6506007)(5660300002)(26005)(44832011)(54906003)(110136005)(41300700001)(316002)(478600001)(8936002)(8676002)(66556008)(4326008)(66946007)(66476007)(6486002)(36756003)(31696002)(86362001)(38100700002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEVQd2NMWWZrcU9UaTNQS1BNTU9rM0pvaXBxVW9yRlFUZll2bTVLaVJaSjFM?= =?utf-8?B?UDYxd0RobUd1RTNEdW5FTTFueDNQY2xxcEZDc2EzeTI1YmFsQ3lINC81bTJj?= =?utf-8?B?cnBVdGhEbU9VMS9vdlNIdjEwd3ZLVmdoNTlIa3hyTWF1MFZLMDAvU3NFZnpS?= =?utf-8?B?UGtURTI4U3laWnhKbVlhdWoyZXRBL0NqNWEwOVE2cFp3VlV0VEVRbFNSZXdo?= =?utf-8?B?RytqL2MvbkNTa3dvSkZqTHM4blNYNVpQdFlZMlZveHhzVVZrTklOZmwyQjVu?= =?utf-8?B?RkkzQUNsK01DZkV3cWpML3lKNGIyOTREbHF0ZEUwQllwRXFyVlNZSjAvYjJS?= =?utf-8?B?YzhDSHBwMFlYOUIrcCtCT3dTMHc2N2p0VW5HVThhMDhQZ1BOWWZNTHB2dElW?= =?utf-8?B?VkZPbW41MVYzU01YblNBcG9wNjI1eERhS0RpMTJZL3lRN2NKQ3JPb2JvZUNo?= =?utf-8?B?UTNkMkZtanBsc0NZcHdJTHg5QTFjZXpJZVovSmorbEZydHdRLzQ4R1hkR1Jz?= =?utf-8?B?TlBFcTFoR1pkN0U0WENJZjZOb2VrSDlwSHoxVzVySi80R0VNTWh5T052ZDY2?= =?utf-8?B?bE5RUjhpSHdzSUhvaFczbElSZ2Y2MjRBK1RLM29oMU9EaW1rRUpVMEYzMEVS?= =?utf-8?B?ZW5NR3lpUFFxaXR0MVdKTDVMRkVKbGp5eGx3MU9zRHRPRU5MYVI3UXNEYm5U?= =?utf-8?B?MmJJYnZaQ21uMFp4UUlrcXVYQXZadllWa1hBS0pOUDAzNlVuWVN3SXNBTVQ5?= =?utf-8?B?dlVaalVwMmtCZFdudHRUUDFiNk9NV1NBMThWdXZwSForWlhYZVFlcW5WTlEv?= =?utf-8?B?NXA4cWgwaDFhYXFZcnFWMURJVVhvSjdMWGh4SFNaU2ZRM01iSTQ2WXFuVFc3?= =?utf-8?B?MDFEZUw2NVZvOURxaFZzUWQ1Z25obTU1M0FtRUZMM241clNXNUJSYkFaYVdq?= =?utf-8?B?Q25IakdVdFpGVkNnVXIxMEtyRFZyRGdLRXN0Z1U1MjI5QU1kOXJaMXpaQUhp?= =?utf-8?B?dUg1VUlMYU9KOW9yajdPU3F0TmcxbTdJOElCYmlsYVV3cm1ISjdFMEN5QXp0?= =?utf-8?B?V055UGd6SG54M1M4VG9YOVRJeWt2WnpjN0JRWnpsRmU4VkRNdFp5OUtqdVVv?= =?utf-8?B?UkNSYWV6UXNMNlZWUlFITVJPU09Nbk50Smt4M0YxSkVzS1RzdlZ0cGpnalBP?= =?utf-8?B?dzdYa01vZll6Q3F4alBZTlZHVTZHdlBCb3NFcU9BZ1ljNUZ1cWJicWQrRXRQ?= =?utf-8?B?ZHN6WVI4TE92dW5VcGIyZ3p2YThNZk5VdVo3Z1VIU2hwREJ0aitBUFNMek9K?= =?utf-8?B?SkQ2RFI1b0lYZ2U3bXpySjBnbE02elFESjNKYmwvUld0QXRPWnk2UFRES3ov?= =?utf-8?B?aHhuRTVJSERHZytBb3lWYWVmSXFPSjNyV3J5R1Y0blhGRnZBWDg2N0ZxVzdH?= =?utf-8?B?Y0puZDZwMUR0N3JET2NiaXR0c0sxRWhld1VTR3lZVHBEY09rOWpSQjJWeFQ5?= =?utf-8?B?K3JlUmplMVNjRXpUWWcxdVF5b2hhZmZGL3ZrU21iSWVUVkNnMEp4YTlWL1NH?= =?utf-8?B?OExST0xqenNKUzVuZzdodTNjQVFYbTA3NVVHeVM1cVZiVXlSWFVUV0FmcU5L?= =?utf-8?B?K1VrTTQrUVR6QlJiQjRpU2RqeGlpMjRsNGFTYzdqWWZLWTlGNU5OVk9zRCt5?= =?utf-8?B?eWViTkhIZXExT2pBSTlyeFM1ZlFNUGpwZkxwMTRKTWo1WUM2QjNUNzgvZEN3?= =?utf-8?B?eE91bTVVVlRXbHBTbEFLQ0xLUHpPMGhmSXdyMFJDTnBlZjhLZnY4MmQ4QnB3?= =?utf-8?B?dldoRE5FYXUvdjJvS1FXT29DcmRSWXJsamtCOENNQWdwbmlnWTBtMGFlN2tZ?= =?utf-8?B?RHIxdzlGWGRXeG5UcW43dTFBYkdFRHg5MEwyMVFlRi9wR09WaEhSYmhmMStN?= =?utf-8?B?YlVtekNvZk13NXBBOFR2ZzhoRk9iaER5dzh4TVIrVExDYXlwdEZxcm5jWkht?= =?utf-8?B?eDFjb1JwSTB4UHJVM2kwcGhYd2lMdHlNZTM3ZlZ5elg2dmJKb2JFUjFzL3BB?= =?utf-8?B?NHRHWmNNdSs1K2gxK01tV3NhQlJZMFFVZmV2Q0w5S2h5OXAwMnpWcXkvSVJF?= =?utf-8?Q?xKZsX81k7l/0Mh2DN5pBZClJ6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9d7b942-22e5-4a9c-db94-08dab292052c X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:55:45.0328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w+NiTFKnJaDHc1E3fRgAcDhRVTjtjPmZfr+0kM17j8mVdREHyJXPtvsuoGTbZv5l X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6176 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/20/2022 12:48 PM, Chaoyong He wrote: >> On 10/20/2022 3:19 AM, Chaoyong He wrote: >>> Add the corresponding data structure and logics, to support the >>> offload of set source MAC action. >>> >>> Signed-off-by: Chaoyong He >>> Reviewed-by: Niklas Söderlund >> >> <...> >> >>> + case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC: >>> + PMD_DRV_LOG(DEBUG, "Process >> RTE_FLOW_ACTION_TYPE_SET_MAC_SRC"); >>> + nfp_flow_action_set_mac(position, action, true, >> mac_set_flag); >>> + if (!mac_set_flag) { >>> + position += sizeof(struct nfp_fl_act_set_eth); >>> + mac_set_flag = true; >>> + } >> >> Hi Andrew, Ori, >> >> I can see 'RTE_FLOW_ACTION_TYPE_SET_MAC_SRC' and many other >> marked as legacy and reference to >> 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD'. >> >> What is the expectation from PMD developers for this? >> >> User still can provide these legacy actions, right? So should PMD implement >> both legacy and new ones? > > From my side, we trying to implement the basic offload in this DPDK release, and complete > the missing pieces in the next few DPDK releases. > > The support of 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' is in the very next project after > this series. Sounds reasonable to me, but also I am not aware of the long term plan there, so I need input from Andrew and Ori.