Re: 19.11.11 patches review and test

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
>>> Hi Christian,
>>>
>>> We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
>>>
>>
>> Hi Kalesh,
>>
>> I have sent a backport patch for 20.11, can you please check if it fixes
>> the build for the v19.11 too?
>>
>> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> 
> This patch is already applied in 19.11.11 as [1], thereby at least
> without backport adaptations it surely does not fix the problem.
> 

It is indeed.

@Kalesh, can you please share more details related to the build error?


> Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> the difference is that 19.11 currently has it inside the check for
> kernel_dir.
> But both get initialized from ` get_option('kernel_dir')` so either
> both or none would trigger and therefore it should be ok as-is.
> 
> I'm happy to consider a fix if someone looks deeper into it and let me
> know what adaptations to try.
> I can also test build SLES15SP3 (before this discussion I knew it was
> "still broken").
> 

The above fix should fix the build for SLES15SP3, are you aware of any
build error after that patch?


> [1]: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> 
>>> Regards,
>>> Kalesh
>>>
>>> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
>>>
>>>      Hi all,
>>>
>>>      Here is a list of patches targeted for stable release 19.11.11.
>>>
>>>      The planned date for the final release is 7th January 2021.
>>>
>>>      Please help with testing and validation of your use cases and report
>>>      any issues/results with reply-all to this mail. For the final release
>>>      the fixes and reported validations will be added to the release notes.
>>>
>>>      A release candidate tarball can be found at:
>>>
>>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
>>>
>>>      These patches are located at branch 19.11 of dpdk-stable repo:
>>>      https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>
>>>
>>>      Thanks.
>>>
>>>      Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
>>>
>>>      ---
>>>      Ajit Khaparde (3):
>>>             net/bnxt: fix Tx queue startup state
>>>             net/bnxt: fix memzone free for Tx and Rx rings
>>>             net/bnxt: fix tunnel port accounting
>>>
>>>      Alexander Bechikov (1):
>>>             mbuf: fix dump of dynamic fields and flags
>>>
>>>      Alexander Kozyrev (2):
>>>             net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
>>>             net/mlx5: fix GRE flow item matching
>>>
>>>      Alvin Zhang (1):
>>>             net/i40e: fix Rx packet statistics
>>>
>>>      Aman Singh (1):
>>>             kni: fix build for SLES15-SP3
>>>
>>>      Anatoly Burakov (2):
>>>             vfio: fix FreeBSD clear group stub
>>>             vfio: fix FreeBSD documentation
>>>
>>>      Anoob Joseph (2):
>>>             test/crypto: skip plain text compare for null cipher
>>>             common/cpt: fix KASUMI input length
>>>
>>>      Arek Kusztal (2):
>>>             crypto/qat: fix status in RSA decryption
>>>             crypto/qat: fix uncleared cookies after operation
>>>
>>>      Ben Pfaff (1):
>>>             doc: fix numbers power of 2 in LPM6 guide
>>>
>>>      Bing Zhao (2):
>>>             net/mlx5: fix flow tables double release
>>>             net/mlx5: fix RETA update without stopping device
>>>
>>>      Bruce Richardson (3):
>>>             eal/freebsd: lock memory device to prevent conflicts
>>>             test/mem: fix memory autotests on FreeBSD
>>>             eal/freebsd: ignore in-memory option
>>>
>>>      Chengchang Tang (2):
>>>             net/bonding: fix dedicated queue mode in vector burst
>>>             net/bonding: fix RSS key length
>>>
>>>      Chengfeng Ye (1):
>>>             net/axgbe: fix unreleased lock in I2C transfer
>>>
>>>      Chengwen Feng (1):
>>>             kni: check error code of allmulticast mode switch
>>>
>>>      Cian Ferriter (1):
>>>             ring: fix Doxygen comment of internal function
>>>
>>>      Ciara Loftus (1):
>>>             net/af_xdp: disable secondary process support
>>>
>>>      Ciara Power (3):
>>>             crypto/openssl: fix CCM processing 0 length source
>>>             examples/fips_validation: remove unused allocation
>>>             test/crypto: fix unnecessary stats retrieval
>>>
>>>      Conor Walsh (8):
>>>             net/hinic/base: remove some unused variables
>>>             bus/fslmc: remove unused device count
>>>             event/sw: remove unused inflight events count
>>>             net/liquidio: remove unused counter
>>>             net/qede/base: remove unused message size
>>>             net/vmxnet3: fix build with clang 13
>>>             test/distributor: remove unused counter
>>>             examples/performance-thread: remove unused hits count
>>>
>>>      Dapeng Yu (1):
>>>             net/ice: save rule on switch filter creation
>>>
>>>      Dariusz Sosnowski (2):
>>>             net/mlx5: fix MPLS tunnel outer layer overwrite
>>>             doc: fix typo in coding style
>>>
>>>      David Christensen (3):
>>>             eal/ppc: ignore GCC 10 stringop-overflow warnings
>>>             config/ppc: ignore GCC 11 psabi warnings
>>>             test/atomic: fix 128-bit atomic test with many cores
>>>
>>>      David Hunt (1):
>>>             test/power: fix CPU frequency when turbo enabled
>>>
>>>      David Marchand (10):
>>>             net/virtio: avoid unneeded link interrupt configuration
>>>             net/virtio-user: fix Rx interrupts with multi-queue
>>>             bus/vmbus: fix leak on device scan
>>>             test/latency: fix loop boundary
>>>             eal/x86: fix some CPU extended features definitions
>>>             mbuf: enforce no option for dynamic fields and flags
>>>             doc: fix default mempool option in guides
>>>             eal/linux: fix uevent message parsing
>>>             test/red: fix typo in test description
>>>             examples/ntb: fix build dependency
>>>
>>>      Eli Britstein (4):
>>>             net: avoid cast-align warning in VLAN insert function
>>>             mbuf: avoid cast-align warning in data offset macro
>>>             eal/x86: avoid cast-align warning in memcpy functions
>>>             app/testpmd: fix packet burst spreading stats
>>>
>>>      Eugenio Pérez (1):
>>>             vhost: clean IOTLB cache on vring stop
>>>
>>>      Fan Zhang (1):
>>>             examples/fips_validation: fix device start
>>>
>>>      Feifei Wang (2):
>>>             drivers/net: fix typo in vector Rx comment
>>>             drivers/net: fix vector Rx comments
>>>
>>>      Ferruh Yigit (3):
>>>             net/softnic: fix useless address check
>>>             net/i40e: fix 32-bit build
>>>             ethdev: fix crash on owner delete
>>>
>>>      Gagandeep Singh (3):
>>>             common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
>>>             common/dpaax: fix physical address conversion
>>>             drivers/crypto: fix IPsec TTL decrement option
>>>
>>>      Gaoxiang Liu (1):
>>>             vhost: log socket path on adding connection
>>>
>>>      Georg Sauthoff (1):
>>>             net: fix aliasing in checksum computation
>>>
>>>      Gregory Etelson (6):
>>>             examples/multi_process: fix Rx packets distribution
>>>             net/mlx5: fix RSS expansion scheme for GRE header
>>>             app/testpmd: fix hexadecimal parser with odd length
>>>             net/mlx5: fix VXLAN-GPE next protocol translation
>>>             net/mlx5: fix GENEVE protocol type translation
>>>             net/mlx5: fix GRE protocol type translation
>>>
>>>      Haiyue Wang (1):
>>>             net/ice: fix memzone leak after device init failure
>>>
>>>      Hanumanth Reddy Pothula (1):
>>>             net/octeontx2: fix MTU when PTP is enabled
>>>
>>>      Harneet Singh (1):
>>>             examples/l3fwd-power: fix early shutdown
>>>
>>>      Harry van Haaren (1):
>>>             app/eventdev: fix terminal colour after control-c exit
>>>
>>>      Heinrich Kuhn (1):
>>>             net/nfp: fix minimum descriptor sizes
>>>
>>>      Honnappa Nagarahalli (1):
>>>             eal: reset lcore task callback and argument
>>>
>>>      Huisong Li (5):
>>>             net/hns3: fix input parameters of MAC functions
>>>             app/testpmd: retain all original dev conf when config DCB
>>>             ethdev: fix PCI device release in secondary process
>>>             net/hns3: simplify queue DMA address arithmetic
>>>             app/testpmd: remove unused header file
>>>
>>>      Hyong Youb Kim (2):
>>>             net/enic: fix filter mode detection
>>>             net/enic: avoid error message when no advanced filtering
>>>
>>>      Ivan Ilchenko (2):
>>>             net/virtio: fix mbuf count on Rx queue setup
>>>             ethdev: fix xstats by ID API documentation
>>>
>>>      Jerin Jacob (1):
>>>             examples/performance-thread: fix build with clang 12.0.1
>>>
>>>      Jiawei Wang (1):
>>>             net/mlx5: fix metadata and meter split shared tag
>>>
>>>      Jie Wang (2):
>>>             net/i40e: fix forward outer IPv6 VXLAN
>>>             app/testpmd: fix DCB in VT configuration
>>>
>>>      Jim Harris (2):
>>>             eal/linux: remove unused variable for socket memory
>>>             power: fix build with clang 13
>>>
>>>      Joyce Kong (2):
>>>             test/service: fix some comment
>>>             test/func_reentrancy: free memzones after test
>>>
>>>      Julien Meunier (2):
>>>             stack: fix reload head when pop fails
>>>             net/ixgbe: fix queue release
>>>
>>>      Junxiao Shi (1):
>>>             net/memif: fix chained mbuf determination
>>>
>>>      Kai Ji (1):
>>>             test/crypto: fix data lengths
>>>
>>>      Kalesh AP (5):
>>>             net/bnxt: fix ring group free
>>>             net/bnxt: fix double allocation of ring groups
>>>             net/bnxt: fix function driver register/unregister
>>>             net/bnxt: check FW capability for VLAN offloads
>>>             net/bnxt: fix VLAN indication in Rx mbuf
>>>
>>>      Kevin Traynor (2):
>>>             bitrate: fix registration to match API description
>>>             bitrate: fix calculation to match API description
>>>
>>>      Konstantin Ananyev (2):
>>>             test/bpf: fix undefined behavior with clang
>>>             test: fix ring PMD initialisation
>>>
>>>      Kumara Parameshwaran (1):
>>>             net/failsafe: fix secondary process probe
>>>
>>>      Lance Richardson (1):
>>>             net: fix checksum API documentation
>>>
>>>      Li Feng (1):
>>>             vhost: add sanity check on inflight last index
>>>
>>>      Long Li (1):
>>>             bus/vmbus: fix ring buffer mapping in secondary process
>>>
>>>      Maciej Szwed (1):
>>>             interrupt: fix request notifier interrupt processing
>>>
>>>      Maxime Coquelin (3):
>>>             app/testpmd: fix RSS key length
>>>             app/testpmd: fix RSS type display
>>>             net/mlx5: fix RSS RETA update
>>>
>>>      Michal Krawczyk (4):
>>>             net/ena: fix offload capabilities verification
>>>             net/ena: fix per-queue offload capabilities
>>>             net/ena: advertise scattered Rx capability
>>>             Revert "net/ena: trigger reset on Tx prepare failure"
>>>
>>>      Naga Harish K S V (2):
>>>             eventdev/eth_rx: fix WRR buffer overrun
>>>             eventdev/eth_tx: fix queue delete logic
>>>
>>>      Nithin Dabilpuram (2):
>>>             app/testpmd: fix check without outer checksum
>>>             app/testpmd: fix dump of Tx offload flags
>>>
>>>      Olivier Matz (1):
>>>             mem: fix dynamic hugepage mapping in container
>>>
>>>      Pablo de Lara (1):
>>>             efd: allow more CPU sockets in table creation
>>>
>>>      Przemyslaw Zegan (2):
>>>             app/crypto-perf: fix AAD template copy overrun
>>>             common/qat: fix queue pairs number
>>>
>>>      Qi Zhang (1):
>>>             net/ice/base: fix typo in comment
>>>
>>>      Qiming Chen (12):
>>>             net/ixgbe: fix Rx multicast statistics after reset
>>>             net/pcap: fix resource leakage on port probe
>>>             net/ixgbe: fix hash handle leak
>>>             net/ixgbe: fix queue resource leak
>>>             net/ixgbe: fix MAC resource leak
>>>             net/ixgbe: fix mbuf leak
>>>             net/i40e: fix mbuf leak
>>>             net/i40e: fix device startup resource release
>>>             net/iavf: fix mbuf leak
>>>             net/i40e/base: fix resource leakage
>>>             net/iavf: fix Rx queue buffer size alignment
>>>             common/iavf: fix ARQ resource leak
>>>
>>>      Rebecca Troy (1):
>>>             test/compress: fix buffer overflow
>>>
>>>      Robin Zhang (7):
>>>             net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
>>>             net/i40e/base: fix PF reset
>>>             net/i40e/base: fix update link data for X722
>>>             net/i40e/base: fix AOC media type
>>>             net/i40e/base: fix function name in comments
>>>             net/i40e/base: fix potentially uninitialized variables
>>>             net/i40e/base: fix using checksum before check
>>>
>>>      Ruifeng Wang (3):
>>>             examples/service_cores: fix lcore count check
>>>             net/i40e: fix risk in descriptor read in NEON Rx
>>>             net/i40e: fix risk in descriptor read in scalar Rx
>>>
>>>      Sean Morrissey (3):
>>>             remove repeated 'the' in the code
>>>             fix PMD wording
>>>             doc: capitalise PMD
>>>
>>>      Shijith Thotton (2):
>>>             test/event_crypto: fix event crypto metadata write
>>>             test/event: fix timer adapter creation test
>>>
>>>      Somnath Kotur (1):
>>>             net/bnxt: fix Rx next consumer index in mbuf alloc fail
>>>
>>>      Stephen Hemminger (4):
>>>             mbuf: fix typo in comment
>>>             bpf: allow self-xor operation
>>>             net/bnxt: fix firmware version query
>>>             fix spelling in comments and doxygen
>>>
>>>      Sunil Kumar Kori (1):
>>>             app/testpmd: fix access to DSCP table entries
>>>
>>>      Thomas Monjalon (2):
>>>             net/qede: fix minsize build
>>>             doc: remove repeated repeated words
>>>
>>>      Timothy Redaelli (1):
>>>             doc: strip build artefacts for examples file list
>>>
>>>      Tudor Cornea (3):
>>>             net/iavf: fix overflow in maximum packet length config
>>>             net/af_packet: fix ignoring full ring on Tx
>>>             net/ixgbe: fix port initialization if MTU config fails
>>>
>>>      Vanshika Shukla (1):
>>>             examples/ptpclient: fix delay request message
>>>
>>>      Viacheslav Ovsiienko (2):
>>>             app/testpmd: fix hex string parser in flow commands
>>>             doc: describe timestamp limitations for mlx5
>>>
>>>      Vladimir Medvedkin (3):
>>>             hash: fix Doxygen comment of Toeplitz file
>>>             lpm6: fix buffer overflow
>>>             rib: fix IPv6 depth mask
>>>
>>>      William Tu (1):
>>>             doc: fix emulated device names in e1000 guide
>>>
>>>      Xiaoyu Min (1):
>>>             net/mlx4: fix empty Ethernet spec with VLAN
>>>
>>>      Xuan Ding (1):
>>>             net/virtio: fix indirect descriptor reconnection
>>>
>>>      Xueming Li (2):
>>>             eal: fix device iterator when no bus is selected
>>>             net/mlx5: fix Altivec Rx
>>>
>>>      Yunjian Wang (1):
>>>             net/ice: fix memzone leak on queue re-configure
>>>
>>>      Yury Kylulin (1):
>>>             net/i40e: support 25G AOC/ACC cables
>>>
>>>      Zhihong Peng (1):
>>>             examples/performance-thread: fix build with ASan
>>>
>>>      Zhihong Wang (1):
>>>             app/testpmd: fix Tx retry in flowgen engine
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Kalesh A P
>>
> 
>