From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8AFF25585 for ; Thu, 24 Nov 2016 12:42:55 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 24 Nov 2016 03:42:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,543,1473145200"; d="scan'208";a="35080084" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga005.jf.intel.com with ESMTP; 24 Nov 2016 03:42:50 -0800 To: David Marchand , thomas.monjalon@6wind.com References: <1478785884-29273-1-git-send-email-david.marchand@6wind.com> <1479751574-5704-1-git-send-email-david.marchand@6wind.com> Cc: dev@dpdk.org, jblunck@infradead.org, linville@tuxdriver.com, declan.doherty@intel.com, zlu@ezchip.com, lsun@ezchip.com, alejandro.lucero@netronome.com, mtetsuyah@gmail.com, nicolas.pernas.maradei@emutex.com, harish.patil@qlogic.com, rasesh.mody@qlogic.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, huawei.xie@intel.com, yuanhan.liu@linux.intel.com, jianfeng.tan@intel.com From: Ferruh Yigit Message-ID: <34e127bd-1f8c-46ea-f602-1f39cb08b698@intel.com> Date: Thu, 24 Nov 2016 11:42:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479751574-5704-1-git-send-email-david.marchand@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net: remove dead driver names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 11:42:55 -0000 On 11/21/2016 6:06 PM, David Marchand wrote: > Since commit b1fb53a39d88 ("ethdev: remove some PCI specific handling"), > rte_eth_dev_info_get() relies on dev->data->drv_name to report the driver > name to caller. > > Having the pmds set driver_info->driver_name in the pmds is useless, > since ethdev overwrites it right after. > The only thing the pmd must do is: > - for pci drivers, call rte_eth_copy_pci_info() which then sets > data->drv_name > - for vdev drivers, manually set data->drv_name > > At this stage, virtio-user does not properly report a driver name (fixed in > next commit). > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit > Reviewed-by: Jan Blunck Series applied to dpdk-next-net/master, thanks.