From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04C0EA0C4D; Mon, 4 Oct 2021 14:50:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DD9A41367; Mon, 4 Oct 2021 14:50:05 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0624E41340 for ; Mon, 4 Oct 2021 14:50:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="224175829" X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="224175829" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 05:50:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="622132151" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 04 Oct 2021 05:50:01 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 05:50:01 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 4 Oct 2021 05:50:01 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 4 Oct 2021 05:50:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWr9YV99mC96ruUkWQkhTHz7SSax1nxuRG7afYACCEXDp6WvtFD8Sneu21iwjlMHG5MjJ8l6Tb+/OdxrnG1IKxdOYWe5Y1PVfEUgbU/rZDN8Lk8Ce69ReCjv+aSzU9v9kR4ZX8JDS2vljVo3yOoPLZnMoRI7YmJhgQVic1D9d+zdJiYVcphzMP5nf7JgDNGGhfWSz3zjuoVvlMwg5DiHBrCrKdVepgEL6tgQ+9KzPh3jkT9juHReqiWOthy/NqorWxNkYjav6+P6bp+NrBlObFbns/JBsnxIQnwZRTnPzUytlcDXXbXmObi3oAusmuXBf86yd3EA8JHMScRjebSaUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T56mb4h/iUdsOsnoGaFYfRy1GCM3xJL3Dxuu0cR55jw=; b=lS/SsfhXPdhCngq1KpXj4wWICbrB+voIQvhK5/KvEbMZh+z3zh9Svdaobzu0LDLGLINBZIweT0s3HvU1jkEb0ddxgp1FGE/1mJL4gGhxlrWhZpUjqbxP5rANye8sAmNE063ax5aevtMkDjxq9tuidtXVkhiHvsaAMs/KYEWZgdLuDwqTbFuNn4j2MvCc5kJ3lkz8vjt05WS4zA6Jl2lLanEzdOHr+YSWslL2iPYhvHh9SiaDouea4/QUqr/0i1dnFfnLGmb/9Ix2Iopc/krqJUIJlI6uOLsBydq2SWwMDWCfgMHjdU/b7peIgmblkt+arsIUC3ks42yfMiqQcX4lfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T56mb4h/iUdsOsnoGaFYfRy1GCM3xJL3Dxuu0cR55jw=; b=nUSmpBlbPB+ZYSAlV97KuR1NNAZEiqoHfk3evs/ffeSs8qLDuPZV3NJwanD56k/NbW18c0Ra2sSHK6Wn/4QwOTR+C0ZLt5GDWH5pnSFZkFYa+vhv2pCq+lw8gLeDIBiNh6z/FWqVGk6ehcET5bwoBmYe1D1TLZ3G4TBUlBZ2kE8= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4904.namprd11.prod.outlook.com (2603:10b6:510:40::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Mon, 4 Oct 2021 12:49:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 12:49:59 +0000 To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Maciej Czekaj [C]" CC: "dev@dpdk.org" References: From: Ferruh Yigit X-User: ferruhy Message-ID: <34ea1ee8-1ba2-4a70-8d9a-85b30fed4a6c@intel.com> Date: Mon, 4 Oct 2021 13:49:53 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6P18901CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P18901CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 12:49:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e67443c-28f5-4635-280b-08d987357990 X-MS-TrafficTypeDiagnostic: PH0PR11MB4904: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: omwXRGqKqWhy+LkVUhr5t/bGEXNAbOt18XxTRGi8eXPtpQ2HmdDmYwky9kkyW9FrsOh8wd0JUvj0KUx/LHnX+uWXnpzaZcRfXsAb8vjGkn5X0Eezy8xe+u0rqTrDcMyZaPQ6bVjQeU2+O4Dvw3SUfin4MH7vKFnbyitG2H+PSZinKqSfXkcLvzF6npyDs3ZsCRgda3uZgkf/bPcIj/Jou3Q7uIZ9rA4EFUc0yuwUkZpEIfGhcSsRmXLqrINC9BkcOncOvqjHXr7V/AVJAwzfQUo/pitgy9LR3coVdzLyS80xmstj4bpR4itvdD6o1E9Db4LdoYoCRtbD3P41/LoYNXulJ3dFuh+W/sJzHX+KuWMYdkzoZKqv3PA/PQxekCotrIXIo2mPf9e0sOko5TTUT8vXdKO6FpzqZejgd+ZutnO6HGsdpuEjA0sp8a2sZn6H4S2+FPffP35Ob8kPmZq4RXvZWQMOHyXq0OrPhvnrqp2HJ1Fnr1acBX9Mgk511S1U2AX7ItyeH5Uy2S8tJyoDkDht6azVd9MuQhbOR2F8eqieMe5WpsDkvP4IXEB5Wm7CDDCRZhuHuq0pxYeXVwmP9oiSRMNSTnHx81CTKonjLe0wmCMLowi6S6O00JSpL8VLtKAzPbw3l6efNmW7fjHRQwnx7qIPD6Hbrip3GlbG/t+wx3i885kRxcaPt0hf8WEB3JA+ZVBZoe/QjGDe769mIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(5660300002)(83380400001)(6486002)(508600001)(53546011)(6666004)(2616005)(38100700002)(8936002)(31696002)(4326008)(186003)(36756003)(86362001)(31686004)(44832011)(16576012)(26005)(110136005)(956004)(8676002)(66476007)(66556008)(66946007)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aExGdThJOWo1MDBiajIrblB6bGQvOE0xeVVoQXp5QkVabTdhOS9RY2h2OUZk?= =?utf-8?B?QzkrcklWZGlKa0hZcHMzODJYbWVHbk4rbjFKM3NObTdtaE1SYWI2M3FsNVkx?= =?utf-8?B?WXovZFRTMURialFkczBpOERqZVFxdnhRSkVJT3VOOWlVbDhEbHRaamZSNkl2?= =?utf-8?B?dzlpcVo3anAyK29KS1pOYkRXNWNYV0xNL3N3T1d0Ukg3Zjl1aW9jNUVHckJM?= =?utf-8?B?VXNISnBreXBKVm1MMFgvb0pFKzZlRHZ4N2ZKY1hCVExydGpNMURkMVI5akRy?= =?utf-8?B?aWVocVMzQXpYblg1VDVwcWVFa1lDREtGTGJqU2V5NWpWejJSOVFGN092VGhv?= =?utf-8?B?ZzZHU3owa2ppWTMxSHp1dlFlVVpaQ2ZOMmFnVUJFWHlhNk1vZnlUbkIzSS9x?= =?utf-8?B?bWVoRWt6NllpOWdLUUVLWFI2UURGc1BPZXB0SmRaTzFtYVB3ZHptOXBwVW9r?= =?utf-8?B?NzhkV0hZY3JheDVwaUl5Rlk4aW5qc3JsTXNjdU9Ub29ZaE1NTjlscFN4NU50?= =?utf-8?B?ZER5N3RwR2RoY1RLYTFZV2FhaDhaTVNFTTNPVmVYVDYwYkNjOW5ISTk5MGIr?= =?utf-8?B?VVppODVjOHMxTHhaSTJOSHVSaHJieUZsaExNNjhOZlcxeFhWbFFXeXVJUWMr?= =?utf-8?B?UDZ2elJobDliUklGandxU0xSU1RmNXYrSVRtOUdTSEhXdTB4NVBhNXV4OTNQ?= =?utf-8?B?UGNtNzZRclhzajBLRXNYU3JRRzZYTStaRVFIc1p4RHhTQUFCenlMcTBWeEUx?= =?utf-8?B?M1kwY2NjbEFuczk3MGx3N2xITUR1U0RINWpjT25rSTBKNFlGeFM4THRMVjNj?= =?utf-8?B?Z3hVWWVzOGJtRFkzcDNZMmV0L2RBLzk4SXB0cGtJeWFidjVGWE1nTytNK1Mw?= =?utf-8?B?MDNhb2hJcDE0R2tNVi9FNkM2QzNxVjltUHBrdlhsK09jV2M5cURoMDhPZEFU?= =?utf-8?B?cEltNlVFU2EzeS9MejRmZjBORlJicFZTK3VHYXlwbmd6Z3p6Z2NPYVY5TDM0?= =?utf-8?B?eWRSVEtnbkJ2MnozZHJZR1RvdVZHUVhjbHpCZWZGb1d2Zzloam9NWGhrNk9Q?= =?utf-8?B?Ylg0Q1FsZytvRS84SlhVcXFiUTVCb01zckdGNGFTNjVFN2Jnckhtc3pXdnhy?= =?utf-8?B?VUI2WDBXc0FXZ0JRSXlaOExyd29GeW11OVBBQU9wTVBnU2Y5Z3dIalBTUGpJ?= =?utf-8?B?WmEyT3VDR1l0bkdrMThqa2piWGRhMFFyNDlqZm5DLzAvM1h0SDBMUFFKNWtR?= =?utf-8?B?dUdTMUNZSjloYUNxWEhvVXkzZUhPRmpUR3lHdUpPcVZLbnpXS2dPQmIxWFFP?= =?utf-8?B?NUNsVDdqTnF1UzRtVGI0dzRnSjMzanhUL0FqQlF3clBNZTluQlhrS2EwcVVN?= =?utf-8?B?K3hzczBGdDlqMU50N3l2Unc0a1pZcGx0cUNXVzNaVldIelR0ZzFnZ3VnR1dr?= =?utf-8?B?cUk2MDZZbW9qT251azAySnpPMFdTWTVia01wWGpnK2sxS3llK3dVRWd5K21a?= =?utf-8?B?dDVNNmVMa2h4eUg1YjVMemc4OXp6cXZMTGFlZ3REMy9iSU8yZ2x0dWtjK1Ry?= =?utf-8?B?UVpIaWRSRWJDVTFPbFFMZVYyb0NZcDlqUjFudzBRVXpQK0dORHE3eXAzOVBr?= =?utf-8?B?VlBlcExvM0JjUmtNOEw1WFEyOCsycDNVUE84TzFOU3BYUFQ1cXR6MjBDdkdZ?= =?utf-8?B?ZW51VE94dEczT2poNUovWEhOOE44Q2lRclZpSy8ycld5VTRFZ2tiT0JhTDBq?= =?utf-8?Q?Dysls/1ZuArh87plpaaCWXkkl4AzPUsvBQZDkCS?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4e67443c-28f5-4635-280b-08d987357990 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 12:49:59.3247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7c/OMgRKOCDxDdRs8j39qgsUnTjSl4svfkjOXC4YWzgrDmTdrSmefzrpbPH4x0RZ4vcZ+n2Ag9VATQP0ELYRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4904 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote: >> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote: >>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote: >>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote: >>>>>>> From: Pavan Nikhilesh >>>>>>> >>>>>>> Due to Linux kernel AF(Admin function) driver dependency, only >>>>>> enable >>>>>>> build for 64-bit Linux. >>>>>>> >>>>>> >>>>>> Hi Pavan, >>>>>> >>>>>> Isn't it possible to provide a commit log in the kernel side etc, that >> let >>>>>> others to verify why only 64 bit is required, or if someone want to >>>>>> support >>>>>> 32bit that may help them to investigate the source of the >> restriction. >>>>> >>>>> Arch 32 support is not implemented on ThunderX, so 32bit will not >>>> run. >>>>> >>>> >>>> I see, is following correct: >>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK, >> and PF >>>> is >>>> supported by Linux kernel driver. And Linux kernel driver doesn't >>>> support arch32. >>> >>> AF != PF, AF is something that manages all the shared resources >> between PF/VF. >>> >> >> I see, I though AF is part of PF functionality. Are there two different >> kernel >> modules for PF and AF? >> >> So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by >> Linux >> kernel driver. > > Yup that’s correct. > >> >>>> >>>> Is something changed in kernel driver side to drop the 32bit support? >>>> If it was not supported at all, what is the motivation to disable the >> DPDK >>>> drivers now? >>>> >>> >>> It was never supported to begin with, motivation is that build will fail if >> we try to >>> compile with 32b. >>> >> >> If there is no plan to support 32bit in the kernel side, that is reasonable >> to >> disable 32bit build, please provide above details in the commit log. >> >> And after above said, how much maintenance cost to support 32bit, if >> the build >> error is on the logging format "%lx" etc .. (as we mostly have 32bit build >> errors), it is better to fix them using 'PRIx64' which is more proper way >> anyway. If there is more logical issue with 32bit pointers, I agree with >> you to >> disable it. >> Can you please provided the build error in the commit log as record? >> > > Apologies, I meant that all the functions that don’t fall under 64b are stubbed out > so the driver wouldn’t work. > so is there build error or not? >>>>>> >>>>>>> Signed-off-by: Pavan Nikhilesh >>>>>>> Acked-by: Jerin Jacob >>>>>>> --- >>>>>>> v5 Changes >>>>>>> - s/fuction/function. >>>>>>> >>>>>>> v4 Changes: >>>>>>> - Update commit message regarding dependency on AF driver. >>>>>>> >>>>>>> drivers/net/thunderx/meson.build | 4 ++-- >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/net/thunderx/meson.build >>>>>> b/drivers/net/thunderx/meson.build >>>>>>> index 4bbcea7f93..da665bd76f 100644 >>>>>>> --- a/drivers/net/thunderx/meson.build >>>>>>> +++ b/drivers/net/thunderx/meson.build >>>>>>> @@ -1,9 +1,9 @@ >>>>>>> # SPDX-License-Identifier: BSD-3-Clause >>>>>>> # Copyright(c) 2017 Cavium, Inc >>>>>>> >>>>>>> -if is_windows >>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') >>>>>>> build = false >>>>>>> - reason = 'not supported on Windows' >>>>>>> + reason = 'only supported on 64-bit Linux' >>>>>>> subdir_done() >>>>>>> endif >>>>>>> >>>>>>> -- >>>>>>> 2.17.1 >>>>>>> >>>>> >>> >