From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9AF98A0032;
	Fri, 24 Jun 2022 13:48:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 44C8F4069D;
	Fri, 24 Jun 2022 13:48:49 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 86397400EF
 for <dev@dpdk.org>; Fri, 24 Jun 2022 13:48:47 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 883C0AA;
 Fri, 24 Jun 2022 14:48:46 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 883C0AA
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1656071326;
 bh=g+zaJyhZ4upNtjjgWA23Ns3hnJypY9nAFqPdvbMYd+k=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=nLWHu0vkAagn+299+nyZlW1VSorI7tMiU6G2jFzON6dkkJVrFkOeZhPwbO2j8GGId
 bCup4JW4zXDSKa051bezPtS5hl9cFKNUo7VAZvDeq72rIdHcMp+z5jNoayixiibOGl
 8UFPJT886qvoSakyo3wVuLOZ3rKiN4Rr4Gtqc7NU=
Message-ID: <34eee5ae-69a5-b39a-9187-8ab536fd5e88@oktetlabs.ru>
Date: Fri, 24 Jun 2022 14:48:45 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0
Content-Language: en-US
To: Thomas Monjalon <thomas@monjalon.net>,
 "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>
References: <20220624060634.295136-1-ciara.loftus@intel.com>
 <9193135.JRmrKFJ9eK@thomas>
 <MW4PR11MB5872B6A1801C8D6BDB4335438EB49@MW4PR11MB5872.namprd11.prod.outlook.com>
 <3237285.2IRrRt1zHL@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <3237285.2IRrRt1zHL@thomas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/24/22 13:10, Thomas Monjalon wrote:
> 24/06/2022 10:37, Loftus, Ciara:
>>>
>>> 24/06/2022 08:06, Ciara Loftus:
>>>> Linking with libbpf v0.8.0 causes deprication warnings. As a temporary
>>>> measure, prevent linking with libbpf versions v0.8.0 and greater. This
>>>> limitation should be removed in the future when appropriate
>>>> compatibility measures are introduced.
>>>>
>>>> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>>>> ---
>>>> -bpf_dep = dependency('libbpf', required: false, method: 'pkg-config')
>>>> -if not bpf_dep.found()
>>>> -    bpf_dep = cc.find_library('bpf', required: false)
>>>> -endif
>>>> +bpf_dep = dependency('libbpf', version : '<=0.7.0', required: false,
>>> method: 'pkg-config')
>>>
>>> It is also removing the find_library() method.
>>> Any reason it was there?
>>>
>>
>> My understanding is that one can't check the library version using that method.
>> So it was a valid method of picking up the library until now where we always need to check the version before linking.
> 
> OK I see

IMHO checking library version is a bad approach. We should file
the library of whatever version and check for symbols etc in it
and provide corresponding HAVE_ defines to handle it in code.