From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 773BD45A01; Sun, 22 Sep 2024 20:59:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C5A2402B4; Sun, 22 Sep 2024 20:59:37 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2076.outbound.protection.outlook.com [40.107.223.76]) by mails.dpdk.org (Postfix) with ESMTP id BA7574028E for ; Sun, 22 Sep 2024 20:59:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GkM2Mbi3YnSfHJ7ON6+bfbREbdOKyfXrS38z89wwE+hcynjQ26D/ZoakzOaV6dupi3+4mhV4CXMyxM1oTIVLr1Cc9K6JBMOaTdv1XCzOGaA24X+AwzC64laWO/1BUKYxnelMV/X3ej9u8TU/SNLmKh0fKjT4bpwaob46OBZON15CDl/NdSUa5cZRKhIRwv3mP5352btHbYUp93Ktgdy1OfCyJdJK49H0ORBf1cjxI5lg6y+Cfe4Rn2a88zJU1IXg9uiIIuYQhRT2SwfGey3Fj4YZczYOWofg8mw193EKjRF6Symyga1WRNzx6Ey7NqXeHbI9eMZyHVhBZpyYqk334w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F79H5hT0V/6x7+e0Su7o4sy499RaN3MrF0RUrjVXnHk=; b=E6A1/hh7vMVH2GX3bJ7+kV9kDOSYiWElCy4MJv4CXDZOaNOpAMY4vlkjDidULrFEklZVyIggnMeiZdvRhu0yLzD7EjT9G58EXf5vsgskUU2XLe6Fkfz+ZBRiO87Wy/fY3o7sWcLSKNwjSr7FVr/G+PWF8GvsgcF9cP4fvjkGkviBhYRA/ObLwiZYtfMmi91vAEdQrkPw4JQofZc/qPhizI6zDt7Hr3gRkgIMj/fSXAjBc9p/D8lb5R+mtiyMcD8P8qtSFPz/G63hf9fzTi9d2uyozNH+6Ce2rW9etHEZKAsZ6tgmY+5USMMivRiecihH10vb564Yuz34moIQPhXHiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F79H5hT0V/6x7+e0Su7o4sy499RaN3MrF0RUrjVXnHk=; b=2FHA9jo81st5BCgaXqDsFvfW/Pebjr7ikqxaWQT8i+UZt+clYS+p3Bqvdky0ungGu7SQYOPZdCJ7zD3+ecbUh1JWaBJC6yL02PST6IPxrHz6Ky68A6Ows22FzgEVFmsTGwH/HK7nMuDUUBjGtQ7oI+qToOYtY4tdyqWSsBxBazU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by DM4PR12MB6183.namprd12.prod.outlook.com (2603:10b6:8:a7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.22; Sun, 22 Sep 2024 18:59:33 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Sun, 22 Sep 2024 18:59:33 +0000 Message-ID: <34f7bdc4-7605-4e61-963a-0b63ad4cc072@amd.com> Date: Sun, 22 Sep 2024 19:59:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] ethdev: add frequency adjustment API To: Mingjin Ye , dev@dpdk.org Cc: Simei Su , Thomas Monjalon , Andrew Rybchenko References: <20240905013144.844499-1-mingjinx.ye@intel.com> <20240910091328.922082-1-mingjinx.ye@intel.com> <20240910091328.922082-2-mingjinx.ye@intel.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240910091328.922082-2-mingjinx.ye@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0178.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::20) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|DM4PR12MB6183:EE_ X-MS-Office365-Filtering-Correlation-Id: 55078fc5-0de4-4eda-b607-08dcdb38b1f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cUhOeDRXWHpOZExQTndUVFhCczY1bGE4Ymc0OTcxQ1BpcStPcU84c285RGZk?= =?utf-8?B?ZFZybFRSK1p0aDNrTFNzMldnTkRGZXRIcTBGSHRUL05YWElWQXBQenpJcXRI?= =?utf-8?B?MW1YR3dIcVlpakc2Y3NkQ2kzUTFPZEQzOVFsL24rL3kyN0pJcDA3WHc1SFhN?= =?utf-8?B?L0NaK1dBV2xtSVkyQUZJQjhGRDlyV2o4TDczN0p2LzEyVHpwWG0yemdCT21T?= =?utf-8?B?QWlkV3lhRkxsMEpwNEJSMjl5Z2lUMHh5TWVmSXhYQ1N5NGk1VVZ2V3VLYlQ0?= =?utf-8?B?aVVOR0tHTXlFUElWWFM2YjRtODQ1R0R3dDdEcWxzdjF6TVJRMzBHR2VMbThL?= =?utf-8?B?ZldYOWN6QzNZVnoyQmVYVG82M3pQN25sNVo5YmtDVU9UeW13dDlJVGVhZmJP?= =?utf-8?B?N05MaGdkalNkblNUeSt2eGk1elpEams4OFI2eTc1bzJDKzFwSmxCeEtNRnQ3?= =?utf-8?B?VlNlZ3Eza3h6a2kyTWRmdUVBT3JMSGI0OU9OL2E0cGpVbExHbjhCbHczenVR?= =?utf-8?B?VGlkV2ZrMkJmallzNWZuMmt3NmJRL3AwcGJCQmFlb1gyenZtTVhCdVI1Yith?= =?utf-8?B?UWxpejdmWEpVSVdjbnpVYXpEbm1HY24veDh6L0c4V0RDeVN2aE9jai9TRll0?= =?utf-8?B?OVkyQjMxL0lLT3hrSXNhOG9TMzgyZ0Q1a3lFdWxsSDlUaFkrVmFhdmI5a0pU?= =?utf-8?B?VS9ORUVPU00wM2RMNnR2bkhHY2hxNW5DYVlVZXZicFE5SlNkQWRRMjVzcHhk?= =?utf-8?B?by9GZlI1b1ZhZkswSXhEano2MW5ZRDRFd1d6V3E3bGpQSFpTK0N5TS9ib3p1?= =?utf-8?B?TlpibkQ2b2N1S2twa2NVS1dTbERBK0FrN3VHM3p4VWdsKzdSbVBOaGN6NTd5?= =?utf-8?B?MkFQMzIyR09QOUZsdDVtTm15UE1YUjZ6T0h3cnFqclI1Z0MrT0cvSERPcVdI?= =?utf-8?B?RzFKSnFHQUU1ZkR5ZnJ0WnFFc0YrUGZSZCtHc3ZyNnZIbm9lbk01bHhwTjNh?= =?utf-8?B?aUczZ0tpM2t3cmErVlZKcEVNV0pUcFU5SkNodktZR2hnMENwQkhPQ1JqV0NK?= =?utf-8?B?WDZiaGJ3S0k1RmRoaTFReC9ESFhwMjV2bklRL0Rpa2xvNllJZ2hEb0o1aGdI?= =?utf-8?B?VENpS0NQK0gweTR0dCtFRU8xV0hhbDErZmJpdXc5a2ZBY1BXcnE0aW00YW5B?= =?utf-8?B?aDFxREx1OHgrc0xNS1Y5ZFdRRlBSdmIwNTBvOEgvbWw1RWczWE1pbElxVnFm?= =?utf-8?B?RUc0UnRMaWFuaFFNd2laeTZKa0VERkZOcktBNWI3Mk1ORytKUktRR05OU3dT?= =?utf-8?B?QWc1NEROeE5FbHFpSnZkSmdCcUdpWFRZdzlhT3k2SEswOGJKTWFTTnRUKzk5?= =?utf-8?B?R1VZQ0VOcGVVRnRNRVdvL2dMR1FaMVRyWmt4MlpRdDNYbWordFd5RjF2bFQv?= =?utf-8?B?Y0RFT1Z3dC90K0pvZ2pjdVQrRitCQmVTQUQ0a2NGdHR2VDBoRTZqTkRFOEZ5?= =?utf-8?B?SzdPZVBJTHhYbWgycnAxYWhnNTFwWTlZOXNzbTlKL1VrZjVqSXcyMStnU1hP?= =?utf-8?B?RlYxSkVIQVpvL1hzSjl5b3paanZOQzJ1T0dPdzhpd1RtWEMyRXpBOHVJMi83?= =?utf-8?B?QWZrVUpEMjQwNDNMUE43bkFSQjNiVVF3eUc1Q0UwSHdnN0ZFQ2lIZnJ5ZVVB?= =?utf-8?B?Vjc1WWs5MmJDd1hIcHVjNXdNTVlWVngrZ2RtbHMySFI3TDVhWWIrSmRRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amZlVlRCZEJlVUhMTnRqN1kzclhHWVVTWTllcTV6dWQyZGlQRTlwYXlBOFdo?= =?utf-8?B?RXlQR2E1MVJDTElxTzhQT0J1RTB4RzZHVno3NU9CUEpwNER3Y3drakl5Qkho?= =?utf-8?B?aW9RVjhHamlvUDZUbjkzdEIyVEFTb0phbDNCNjMrbDNQaVMzOTlZRjJ4MUk5?= =?utf-8?B?VkdPMU5BOHJzdE9NbTkzT0JVamw4NmU2b3NBN0VIRkZKWkNLZCszUnZwcDZI?= =?utf-8?B?M3lVTDh1T1R1TkRhY3N6RnVFSWJ3M1dVY3ExRDkyTmxkNENxaHVRb1E2SlV1?= =?utf-8?B?YXBWWW9PT3B5aFpHSnZTQlJxNUJscXMzTk1nOGhWWkZ3a3dqYzJYdUoxK09z?= =?utf-8?B?ay90NkZteUdxczNUdzJrK25UeC9uNlRNZFZFSkFLUW93aDJFRTlYYjE1L0pI?= =?utf-8?B?eExxK3JjYlV4VGpocW1IUUZXSWxTQlFCbXpEWWdBRWZVUE1ManRMQmFGUmNC?= =?utf-8?B?MklTKy9wM2NXWTNidGQyY28yT0tneTBEVUp4NWZtU2FFWXdpeGpsVDhqeXRs?= =?utf-8?B?ZDlrb2F6aFFyWDFiaEZZdUJiVW9JeXJTU0FES2JBZXNFdWZlYjMvdk9KVitF?= =?utf-8?B?Vk1XdklPWlU0MWZIQUFrOU9UNzhndXBSSmRqMnBtK0UxNXd0T0U1a3EzTzUy?= =?utf-8?B?bnEwclZ2aE1TRzFCSXF6ZFd3bkc2ZXRLSFkwRkN1eVNxTlgrNlpyTkpBaTRw?= =?utf-8?B?YWltY0srKytPN0hJUmhDbDNnRmxZMG5RTEFDQ0N4aTZiby9CLzJQM3hKQnBp?= =?utf-8?B?c0lTdEVoMzkveE5RbVZlZXc0NW5BdUMrR3Bpak5CRi9rd0pWL2xkN2MyZ1Rz?= =?utf-8?B?V0dLQlFyaEdqTW5jeWlWeko2bllDZFFrZ1U4QTlzWFQyaytsczlndlBzZ05U?= =?utf-8?B?TWVYM0lkOGViUVN5SjJEV1gvQmNHSXRZeVhGNktnR3NVTzR4RUErTmZKSmRH?= =?utf-8?B?dVdUYnlOUklHUWd5UHlrRGd3VGJDRXZvNFRrdnM4eWxPK2ZET2RIaUJ6M1Zk?= =?utf-8?B?UkNkM2k0bE0rbTRMU00vYlhvd1FGaE9jU1I3R0E3WXlGTlAzdkIwRFlaOTgz?= =?utf-8?B?Smk1OUF0S25SYTA2VURwZ0wySFo3emkrUllBZjN0ZmVBYUszV09JVXBQWXdN?= =?utf-8?B?UlBKSHVpR0g3SzNnVExtT3dWNDBCdmxiUTNXb3NXMTlycWV3cmRqZ2M0Sk9i?= =?utf-8?B?RkdIM1N3WFUzNlRpMVhwaTJhaXZBT3g4TGd0cTkzb1JzTTZoVEJRRU5ZaDFM?= =?utf-8?B?bll0L0VOV293MUhpOFJ6azQ3MGV5TjZzVmZVWGxpNDJJRXZ5eG1CY1hsWiti?= =?utf-8?B?UEpFTVJ5cDdaOXZIamIzNjF2NkVmZUEyQnpTbUQyamJ2SDdRL2duVnpNbGpS?= =?utf-8?B?TzBiYWVpaGVTb1BaOWpaUnFTVU9QdlVhdm41RjhJZkVpeEJnZ09lOVhFa0pz?= =?utf-8?B?cU5wRFAxdmViOGtDV0tGOWlWQXB2ZGVTZUJPTGMyR1l0VWlnakZSc3hXcGRN?= =?utf-8?B?MW43bVdTcVdIcmh5L1hJQm9vZkFVdVpkUjgyQjNQbVpRNURpQ0hOazV1L0R0?= =?utf-8?B?SmxsZEgwbG4rQnVIWXVmVHM4bVRkV3BDNlVtR2xtR0tDdmgwdkNvWWJaU1Zk?= =?utf-8?B?TG9zbDN0eU1FT3l3Tldxa2k1eE12dEdSYjJEcUZKYmFNd0hvVU1WNHNWWVZP?= =?utf-8?B?MHA1WlIyRGpFdU4xQVZWOWpEMVNvZU9DZzN4R0IxWEtzeXVUTmhERU5UMFd6?= =?utf-8?B?TWttZVEraStWNmx0NGRUSys0eEJ3UDdIMmFnMGcwc0dac0tBR0FHcU1lRVZq?= =?utf-8?B?aUpZVDIrdUhuVXJITkRnRHBRK1hGQ0k0WXZmZFRXL05lSU95ZVZTdEFUUWNW?= =?utf-8?B?bzc2a2RvVW1hRHIxbVVYSmlnWGl3OHg4T0p1c1lxWG9zQjRZK05zc3JzN3ht?= =?utf-8?B?eFBWeldpL2d0b25wamlhOUlNbXlHRWdib0dGRmJST1VPM1UrbE9BcExOWTRQ?= =?utf-8?B?eFl5NlRCWm12MW9hRzZ2SElzWXppU01DQXJ5eHpHYzhreFFRd29NOTFYZFJx?= =?utf-8?B?SC9OMFQ4eHFoRzVVeFB1a0J2a2llbDYrektBNkZwUzk2KzhmV21xbkx2cWV1?= =?utf-8?Q?2ROsCnfcCM0WyDPTp7sUjHgxl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55078fc5-0de4-4eda-b607-08dcdb38b1f4 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 18:59:33.2044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pJqTrFsKHuZuUx52T7U1ouzwDax6EvpDAm2slbxHbQaabJJg1rLLyD9zRJep//WC X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6183 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/10/2024 10:13 AM, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye <...> > diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst > index 0ff70d9057..10ac35e5c0 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -25,35 +25,11 @@ New Features > ------------ > > .. This section should contain new features added in this release. > - Sample format: > > - * **Add a title in the past tense with a full stop.** > +* **Added Ethernet device clock incremental rate adjustment.** > > - Add a short 1-2 sentence description in the past tense. > - The description should be enough to allow someone scanning > - the release notes to understand the new feature. > - > - If the feature adds a lot of sub-features you can use a bullet list > - like this: > - > - * Added feature foo to do something. > - * Enhanced feature bar to do something else. > - > - Refer to the previous release notes for examples. > - > - Suggested order in release notes items: > - * Core libs (EAL, mempool, ring, mbuf, buses) > - * Device abstraction libs and PMDs (ordered alphabetically by vendor name) > - - ethdev (lib, PMDs) > - - cryptodev (lib, PMDs) > - - eventdev (lib, PMDs) > - - etc > - * Other libs > - * Apps, Examples, Tools (if significant) > - > - This section is a comment. Do not overwrite or remove it. > - Also, make sure to start the actual text at the margin. > - ======================================================= > + Added new function ``rte_eth_timesync_adjust_freq`` to > + adjust the clock increment rate for Ethernet devices. > Can you please check above, patch removes unrelated parts of the document, I assume caused by rebase issues. > > Removed Items > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index 883e59a927..68cadc14a5 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -664,6 +664,9 @@ typedef int (*eth_timesync_read_tx_timestamp_t)(struct rte_eth_dev *dev, > /** @internal Function used to adjust the device clock. */ > typedef int (*eth_timesync_adjust_time)(struct rte_eth_dev *dev, int64_t); > > +/** @internal Function used to adjust the clock frequency. */ > +typedef int (*eth_timesync_adjust_freq)(struct rte_eth_dev *dev, int64_t); > + > /** @internal Function used to get time from the device clock. */ > typedef int (*eth_timesync_read_time)(struct rte_eth_dev *dev, > struct timespec *timestamp); > @@ -1378,6 +1381,8 @@ struct eth_dev_ops { > eth_timesync_read_tx_timestamp_t timesync_read_tx_timestamp; > /** Adjust the device clock */ > eth_timesync_adjust_time timesync_adjust_time; > + /** Adjust the clock frequency */ > + eth_timesync_adjust_freq timesync_adjust_freq; > /** Get the device clock time */ > eth_timesync_read_time timesync_read_time; > /** Set the device clock time */ > diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h > index 3bec87bfdb..e273d5853e 100644 > --- a/lib/ethdev/ethdev_trace.h > +++ b/lib/ethdev/ethdev_trace.h > @@ -2183,6 +2183,15 @@ RTE_TRACE_POINT_FP( > rte_trace_point_emit_int(ret); > ) > > +/* Called in loop in examples/ptpclient */ > +RTE_TRACE_POINT_FP( > + rte_eth_trace_timesync_adjust_freq, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, int64_t ppm, int ret), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_i64(ppm); > + rte_trace_point_emit_int(ret); > +) > + > /* Called in loop in app/test-flow-perf */ > RTE_TRACE_POINT_FP( > rte_flow_trace_create, > diff --git a/lib/ethdev/ethdev_trace_points.c b/lib/ethdev/ethdev_trace_points.c > index 99e04f5893..a99fec0c1e 100644 > --- a/lib/ethdev/ethdev_trace_points.c > +++ b/lib/ethdev/ethdev_trace_points.c > @@ -409,6 +409,9 @@ RTE_TRACE_POINT_REGISTER(rte_eth_trace_timesync_read_tx_timestamp, > RTE_TRACE_POINT_REGISTER(rte_eth_trace_timesync_adjust_time, > lib.ethdev.timesync_adjust_time) > > +RTE_TRACE_POINT_REGISTER(rte_eth_trace_timesync_adjust_freq, > + lib.ethdev.timesync_adjust_freq) > + > RTE_TRACE_POINT_REGISTER(rte_eth_trace_timesync_read_time, > lib.ethdev.timesync_read_time) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index f1c658f49e..660eab2f1e 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -6310,6 +6310,24 @@ rte_eth_timesync_adjust_time(uint16_t port_id, int64_t delta) > return ret; > } > > +int > +rte_eth_timesync_adjust_freq(uint16_t port_id, int64_t ppm) > +{ > + struct rte_eth_dev *dev; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + > + if (*dev->dev_ops->timesync_adjust_freq == NULL) > + return -ENOTSUP; > + ret = eth_err(port_id, (*dev->dev_ops->timesync_adjust_freq)(dev, ppm)); > + > + rte_eth_trace_timesync_adjust_freq(port_id, ppm, ret); > + > + return ret; > +} > + > int > rte_eth_timesync_read_time(uint16_t port_id, struct timespec *timestamp) > { > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 548fada1c7..c3587089b9 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -5297,6 +5297,26 @@ int rte_eth_timesync_read_tx_timestamp(uint16_t port_id, > */ > int rte_eth_timesync_adjust_time(uint16_t port_id, int64_t delta); > > +/** > + * Adjust the clock increment rate on an Ethernet device. > + * > + * This is usually used in conjunction with other Ethdev timesync functions to > + * synchronize the device time using the IEEE1588/802.1AS protocol. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param ppm > + * Parts per million with 16-bit fractional field > + * > Can you please describe the API a little bit more? I assume frequency can be adjusted up and down, how this reflected via API? Can you please give some practical examples of how this API intended to use? I assume after an initial sync, some time later the externally received time information and device time mismatch and requires adjustment. In this case: 1. How to decide which one of the API use, 'rte_eth_timesync_adjust_time()' and this new 'rte_eth_timesync_adjust_freq()' ? 2. Lets say device is behind 1us after 1 minute (is these scale of the measurements makes sense, if not please give better examples), what should be the 'ppm' parameter to fix this? And similar sample for the case device time is faster than external case.